From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51037: [PATCH] Make `print-level` & `print-length` customizable in ERT batch tests Date: Mon, 25 Oct 2021 15:05:07 +0200 Message-ID: <87y26hz24c.fsf@gnus.org> References: <86tuhvmtpl.fsf@runbox.com> <877deqec10.fsf@gnus.org> <83fste2u4i.fsf@gnu.org> <87ily94662.fsf@gnus.org> <83fstd1bth.fsf@gnu.org> <87czogslm4.fsf@gnus.org> <86ily2mjtq.fsf@runbox.com> <87r1cp89o4.fsf@gnus.org> <86fst5m48v.fsf@runbox.com> <87a6jd5891.fsf@gnus.org> <86mtmykxro.fsf@runbox.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20404"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: gazally@runbox.com, 51037@debbugs.gnu.org To: Michael Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 25 15:11:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mezl7-00059F-9F for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 15:11:25 +0200 Original-Received: from localhost ([::1]:60776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mezl5-0005It-GH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Oct 2021 09:11:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mezfu-0004pF-Vj for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 09:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58575) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mezfu-0006Rl-MS for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 09:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mezfu-0005rX-Hl for bug-gnu-emacs@gnu.org; Mon, 25 Oct 2021 09:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Oct 2021 13:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51037-submit@debbugs.gnu.org id=B51037.163516712022474 (code B ref 51037); Mon, 25 Oct 2021 13:06:02 +0000 Original-Received: (at 51037) by debbugs.gnu.org; 25 Oct 2021 13:05:20 +0000 Original-Received: from localhost ([127.0.0.1]:41888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezfD-0005qQ-Mo for submit@debbugs.gnu.org; Mon, 25 Oct 2021 09:05:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezfC-0005q9-AR for 51037@debbugs.gnu.org; Mon, 25 Oct 2021 09:05:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uga6PvDG/94sdrM4i4th0J2iqboRcw3Y6C7Wx9mC6D8=; b=fX79NB9B4NT6Ky0F898KW8F8lN JTzfdh1oUlgG0CyUpf/oMLfZJgGNNjwb9OXi+swqfB1XTNd6ikH0eNnUCI6+OjgjrUrXyB3vwXRmc 2hZGGwL8MWZSWRplHOgxiGCejN7qujM/k48TSc9CxarFHCYMTKvKhYMG8cBTWGiGcjjs=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mezf3-0001Fa-7M; Mon, 25 Oct 2021 15:05:11 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW4oGLo4LhfSi7/ ///dCHUJAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+UKGQ0CC0DACHwAAAGzSURBVCjPNdDBitswEAbg UYgX45OzSEvZUzaUYusp7GBD6pMVNKHklJQutHmKpCSXnFrILqUnOySgzFN2pO765I/5NRoNiCJJ E4GrB4UIsZmeUkR7QgbE0z2UxkpfEX+q3Wdt7IvCGoocYaY5V3NlnA9d4xAXgrHWWp9chGbEyMa0 eaUDtr6bnjg6d3zGYwPF8fLCf77BantPJf7/wAxkkr6jLOJp6i/BygJ7CZCzrAXpETsVukmTzkHT QfnKKi1sP6Abx+5Ao7Hiq0d1hka1Mv6urxUuhjCzrXzUug+xFm3UZh44BKvm/QCSK4MvrdsM+uWF kfIEuIGnpjM+xpjtnpveYORjXF433V4JFRD/aIgOM+VjOHUDcuIbAhostcuIRD3ylTKjPKGJEh42 pz4hWT+HM2u6JMdtXYLfWPXYpUS/uQHOVX13vic6+YUUI/z48+i09LBKtoO/7tjX4UzdxgfaPrWM xesau+utHIeYvJp558rMA9UIC/pQxGHQqMCZ3lXbyGP4gMvzrerCBKrBLx7SV34V2J6dFQGWl64z CXVAhJbyFCA8gTGh/Rt4xZ90lIp/x1KvKUgs+CYAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMTAt MjVUMTM6MDI6MTErMDA6MDCeWyIKAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEwLTI1VDEzOjAy OjExKzAwOjAw7waatgAAAABJRU5ErkJggg== X-Now-Playing: Mike Rutherford's _Smallcreep's Day_: "Romani" In-Reply-To: <86mtmykxro.fsf@runbox.com> (Michael's message of "Sun, 24 Oct 2021 12:50:35 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218268 Archived-At: Michael writes: > The issue: stack traces are printed by the `backtrace` > package. backtrace.el was authored by Gemini (which is why I've > added him to this thread). backtrace.el doesn't directly work in > terms of `print-le{ngth,vel}`: it defines a custom variable > `backtrace-line-length` and then adjusts print-level & > print-length in let bindings in order to: > > 1. try to respect the desired line length > 2. not trigger bug 31919 (Lisp Debugger doesn't work when at > stack limit) [...] > For myself, I was quite surprised to all learn this: I had to > spend a fair bit of time digging through the source to find out > what was happening to my settings for print-length & > print-level. Yeah, I didn't remember `backtrace-line-length' either. Perhaps it should be linked to from the doc strings of print-length and print-level... > My personal incliniation is to remove the `backtrace-line-length` > variable entirely, and make the `debug` package responsible for > controlling print-level so as to avoid 31919. But that's me: is > there a compelling use-case for backtrace.el working in terms of > limiting line length rather than just using `print-le{ve,ength}`? Well... if we're talking in an ert context, it could increase both the backtrace-line-length and max-lisp-eval-depth variables when gathering the backtrace, I think? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no