From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51682: 29.0.50; [PATCH] Raise an error if creating an unknown xwidget type Date: Mon, 08 Nov 2021 15:07:45 +0800 Message-ID: <87y25znn0e.fsf@yahoo.com> References: <87y25znn0e.fsf.ref@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="978"; mail-complaints-to="usenet@ciao.gmane.io" To: 51682@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 08 08:09:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjymS-00007Q-N8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 08:09:24 +0100 Original-Received: from localhost ([::1]:57774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjymR-00023V-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 02:09:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjym6-0001ye-8q for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:09:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjym5-0002Ok-Vt for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjym5-0000bp-P0 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Nov 2021 07:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51682 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16363552862244 (code B ref -1); Mon, 08 Nov 2021 07:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Nov 2021 07:08:06 +0000 Original-Received: from localhost ([127.0.0.1]:55884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjylC-0000a8-8W for submit@debbugs.gnu.org; Mon, 08 Nov 2021 02:08:06 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:57280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjyl7-0000Zi-9t for submit@debbugs.gnu.org; Mon, 08 Nov 2021 02:08:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjyl6-0000Yb-VP for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:08:00 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjyl4-0002Gf-Bl for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 02:08:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636355276; bh=iyeeaSQWmu9wLaem2s/AEJgAfFfrBpp/LFsLqmqFtNw=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=KsTmfvFSpZjeYNl+IMxl+SVD4Z7n/bgzYHq8OsYcJLk9OAanJyGzX7K8AYEyht849dilPGKuALodwQEKKrios3DJUqvM3JX0reucZeOPV20xxM2my508KwFSUeLnK6jD2hpEDmDjeMbpaPrrSdLu9ww6UIDjaK1zgKhqWFC8eBIyNuJPWTUh/36CEXlYxp6WiSmyNB0cANVGAG9ortofBM5PvR4A2f5xjRK9RsuHxWrjAY5C3M7VwW5L5OU5wUKNnZlZpM7mu2GR7sFxiCNX3NGdfzCNoYg9f23Cfbq0XJ8bagutO4bPAQuT+CdexCCuHAJ/CUXKLI46wC4jhuQ1Kw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636355276; bh=vMmlYxClaQ624vRiGg4f6pYrWIb3K9AA6/NV5CTbf7b=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=S6+ejsY11s9Im2JAGt/YNtrQrUb7jzC+I4a8+rtI7uwMsu2x0DlrbQD6h13rfomxiBaypv/FGqG8eS0Z6EN3Qi5NrQ0d1q4eCIHQZo7z+JF51xm+VG0hasc6z8d717O4TiodpR/g76q3QPX7Ipurxj0aCXkmrk6W0miUbFu6JfMBDR6GBxn8otu2B304DcrsewZHSoww6Lua714c2DD72gHvX0Hhwv0zyu+O3+0xdbKBnwY44p4GPribrNH2L6NK+XixdzKwoKKnWZ7+jNGf4LI4Dp8AqmFUPwYmdzIKzEKQc61m+omJiw149zo3S0fMpAQ88rIMMv+0CV3214fGmw== X-YMail-OSG: zfVbbfgVM1nJaSZQ8hLHeRvlWAYgJRf7UJYtT5ovRpWz1QSNAJDigijwFEwPC2m a2O6TTYYMY5U56XBbySdW51qqjs0a7WhaWR4MV2j_zu4tziHsqeWt0cDhW1fdleTEnM4UMhoKbXa k0AoBgWTOcic2GatvjphORc4inlG3O3QgRQaDu09I1Aa._3GAYg6NonCvGTYmISmoW1YpZSF1emo ja4DMOPa.ipwkSn2Jou8YyzY.F02dWPf8VNXmsTs826Y4NWGEo5yTgfEMqbiIaU5ucv.ouu3kKiL kVH0KtsjAnDktlM_Sh8mz_aXt5KcCdrjmXIP8O_n7yPxbqx9fjMGSr6y.2UMLpsDwIPjW8H0_9sK uvDuO8FZtg9jonP.mJNUtJ1Xqkaos_WX_zCr26dzr3MUZNj47LSU59mXcvjUqzvxYdYnLoWP.jGb vjVDxuqKJiCrS9tmDqapd8i1mxJ7K9oNfw09_tuLPSmNuNvkpelXVUN278.wUSix_PDL4892WNJV LlfyDA3lx_rSg6HAK2hg2v2H1Cnh.9fratWBh7npzAmMZZMokqx__YhMrnOgSzlz5IrIwO69u_Jm sBZd.cz0kPDviuv9hsDi_du9Kgh26oPGpaIhgMAvXtRm8IK8Qwu4zhLGI0CFUV8W8S54oDvqrcMn wizwnRiV4K5Av_pEJCJvwcCFc5rbf94mU8mICHROxEfFJPsY7atWLP1M5lICRhAryCPpdDiml8dP t654wxK9cn22V8gibMeED0oqPB4zMVCUVvMZGItHdTW7g3.wMhi7eMI4kKOuPxPHPTTQebUkf4tB nKnnt_.8Z2P6FILcU.AB9ktpZMsI7.JX6OhaWBK95a X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 8 Nov 2021 07:07:56 +0000 Original-Received: by kubenode514.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 62c128b5df7be8bbe89122b9a663d46b; Mon, 08 Nov 2021 07:07:49 +0000 (UTC) X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.31; envelope-from=luangruo@yahoo.com; helo=sonic307-56.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219336 Archived-At: --=-=-= Content-Type: text/plain Otherwise code can create bogus xwidgets for whom widget_osr and widgetwindow_osr are NULL, which can cause crashes. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Raise-an-error-if-creating-an-unknown-xwidget-type.patch >From c9155cfe0f1c8c0d51c81db01a0e942f6bed4345 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Mon, 8 Nov 2021 15:06:10 +0800 Subject: [PATCH] Raise an error if creating an unknown xwidget type * src/xwidget.c (Fmake_xwidget): Error if TYPE is invalid. --- src/xwidget.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/xwidget.c b/src/xwidget.c index 2d9351308e..ec0c283c80 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -128,6 +128,9 @@ DEFUN ("make-xwidget", CHECK_FIXNAT (width); CHECK_FIXNAT (height); + if (!EQ (type, Qwebkit)) + error ("Bad xwidget type"); + struct xwidget *xw = allocate_xwidget (); Lisp_Object val; xw->type = type; -- 2.31.1 --=-=-=--