unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: miha--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 51892@debbugs.gnu.org
Subject: bug#51892: 29.0.50; [PATCH] Don't ignore restriction in indent-region-line-by-line
Date: Wed, 17 Nov 2021 19:19:10 +0100	[thread overview]
Message-ID: <87y25mejc1.fsf@miha-pc> (raw)
In-Reply-To: <87r1bfnqsc.fsf@gnus.org>

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> miha@kamnitnik.top writes:
>
>> Emacs convention is that low-level functions should respect restriction
>> so that their callers can set restriction according to their needs. For
>> example, 'c-indent-region' is a lower-level function which respects the
>> current restriction and 'indent-region' is a higher-level user command
>> which sets the restriction for lower-level functions, it calls
>> "(widen)".
>
> I think that makes sense, so I've pushed this to Emacs 29.  (But I
> renamed dont-widen to inhibit-widen, since I think that's what we're
> calling arguments like this these days.)

Thanks, but maybe you forgot to actually push to origin/master? I
fetched it just now and the last commit touching indent.el was about two
months ago.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-11-17 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 12:57 bug#51892: 29.0.50; [PATCH] Don't ignore restriction in indent-region-line-by-line miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-17  8:13 ` Lars Ingebrigtsen
2021-11-17 18:19   ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-11-18  9:03     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y25mejc1.fsf@miha-pc \
    --to=bug-gnu-emacs@gnu.org \
    --cc=51892@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).