From: Robert Pluim <rpluim@gmail.com>
To: Manuel Uberti <manuel.uberti@inventati.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
52158@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#52158: 29.0.50; Add key binding fo vc-git-stash
Date: Mon, 06 Dec 2021 09:58:24 +0100 [thread overview]
Message-ID: <87y24ygle7.fsf@gmail.com> (raw)
In-Reply-To: <e331d65c-d6bc-f78f-81e0-e670da2039b1@inventati.org> (Manuel Uberti's message of "Mon, 6 Dec 2021 07:32:33 +0100")
>>>>> On Mon, 6 Dec 2021 07:32:33 +0100, Manuel Uberti <manuel.uberti@inventati.org> said:
Manuel> On 06/12/21 07:31, Lars Ingebrigtsen wrote:
>> Manuel Uberti <manuel.uberti@inventati.org> writes:
>>
>>> Thank you for this. May I suggest to add 'z p' bound to
>>> vc-git-stash-pop to vc-dir-git-mode-map?
>> But that command pops the stash under point, so you have to move
>> point
>> to a stash line first. So it doesn't seem very helpful to have in the
>> minor mode map.
>>
Manuel> I thought vc-git-stash-pop-at-point did that.
It does, and thatʼs the one bound to 'P' in the stash area
keymap. 'pop' is destructive, so I think it should be bound only when
youʼre actually looking at the stash list (unlike the new 'z c' and 'z
s' bindings).
BTW, the stash area bindings are all upper case, and the new ones are
lower case. Can we make them more consistent?
Robert
--
next prev parent reply other threads:[~2021-12-06 8:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 8:36 bug#52158: 29.0.50; Add key binding fo vc-git-stash Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-28 13:51 ` Lars Ingebrigtsen
2021-11-28 13:55 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-28 14:12 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-29 13:58 ` Lars Ingebrigtsen
2021-11-29 14:03 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-29 14:12 ` Robert Pluim
2021-11-29 14:18 ` Lars Ingebrigtsen
2021-11-29 14:30 ` Robert Pluim
2021-11-29 14:40 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-29 15:32 ` Lars Ingebrigtsen
2021-11-29 22:16 ` Dmitry Gutov
2021-11-30 12:59 ` Lars Ingebrigtsen
2021-12-06 1:00 ` Dmitry Gutov
2021-12-06 5:42 ` Lars Ingebrigtsen
2021-12-06 6:29 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 6:31 ` Lars Ingebrigtsen
2021-12-06 6:32 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 8:58 ` Robert Pluim [this message]
2021-12-07 7:07 ` Lars Ingebrigtsen
2021-12-07 9:08 ` Robert Pluim
2021-12-07 12:56 ` Dmitry Gutov
2021-12-07 7:06 ` Lars Ingebrigtsen
2021-12-07 7:19 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-06 17:32 ` Juri Linkov
2021-12-07 5:06 ` Manuel Uberti via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-29 17:12 ` Juri Linkov
2021-11-29 18:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y24ygle7.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=52158@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=larsi@gnus.org \
--cc=manuel.uberti@inventati.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).