From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#53352: 29.0.50; IMAP INBOX not refreshing using `gnus-group-get-new-news' Date: Mon, 24 Jan 2022 11:20:57 -0800 Message-ID: <87y235ym7a.fsf@ericabrahamsen.net> References: <87fspkiqxt.fsf@md5i.com> <87o845tm9b.fsf@gnus.org> <874k5vg2ld.fsf@md5i.com> <87o842boci.fsf@gnus.org> <87iluae6ij.fsf@md5i.com> <87ee4x5w5g.fsf@gnus.org> <87o841cdq1.fsf@md5i.com> <8735ld854r.fsf@igel.home> <878rv56mm6.fsf@ericabrahamsen.net> <87wnip2dep.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35280"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Welsh Duggan , Andreas Schwab , 53352@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 24 20:24:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nC4wo-0008yk-A5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 20:24:14 +0100 Original-Received: from localhost ([::1]:47764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nC4wn-0002O7-BJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 14:24:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nC4us-0000j8-Px for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 14:22:18 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53043) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nC4uf-0002sR-PX for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 14:22:14 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nC4uf-0003ry-NJ for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2022 14:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jan 2022 19:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53352 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53352-submit@debbugs.gnu.org id=B53352.164305207114812 (code B ref 53352); Mon, 24 Jan 2022 19:22:01 +0000 Original-Received: (at 53352) by debbugs.gnu.org; 24 Jan 2022 19:21:11 +0000 Original-Received: from localhost ([127.0.0.1]:45946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nC4tq-0003qq-V8 for submit@debbugs.gnu.org; Mon, 24 Jan 2022 14:21:11 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:42642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nC4tk-0003pn-JM for 53352@debbugs.gnu.org; Mon, 24 Jan 2022 14:21:09 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 88E37FA01F; Mon, 24 Jan 2022 19:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1643052058; bh=H/5lpKQBv261Hh66Ou57LXM0HiZ15ReJvAPwnuYm2Rw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QCPzvzGjBCXsUxEQ8P+AZw6wShPxg5yn9x5986doD1mJlh8w2cI7RYNCDTZpRtf1U nETp0ZCJAiwcCUohQOSZNvkLjTj1v/UtuuTsYkjHSgnw4/GaCAfBunSZWHzGUZJuHY mOmtK1KKVlRG2iFYMaQpgcWhLoVzbLSxqhkSY6zU= In-Reply-To: <87wnip2dep.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 24 Jan 2022 19:31:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225107 Archived-At: --=-=-= Content-Type: text/plain On 01/24/22 19:31 PM, Lars Ingebrigtsen wrote: > Eric Abrahamsen writes: > >> I suppose the Emacs 28 ship has sailed? It would be nice to include this >> fix in the release. > > It's a regression from 27.2, so including a fix in Emacs 28 would be > appropriate (if it's simple enough). But we can run it on master for a > while before backporting. Okay, good. I'm attaching the patch I'm using right now -- this appears to fix it. I'll give it another day or two. Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=preserve-gnus-newsrc-alist.diff diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index 2cf11fb12f..dd9c277805 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -2867,12 +2867,6 @@ gnus-gnus-to-quick-newsrc-format (princ "(setq gnus-newsrc-file-version ") (princ (gnus-prin1-to-string gnus-version)) (princ ")\n")) - ;; Sort `gnus-newsrc-alist' according to order in - ;; `gnus-group-list'. - (setq gnus-newsrc-alist - (mapcar (lambda (g) - (nth 1 (gethash g gnus-newsrc-hashtb))) - (delete "dummy.group" gnus-group-list))) (let* ((print-quoted t) (print-escape-multibyte nil) (print-escape-nonascii t) @@ -2891,17 +2885,20 @@ gnus-gnus-to-quick-newsrc-format ;; Remove the `gnus-killed-list' from the list of variables ;; to be saved, if required. (delq 'gnus-killed-list (copy-sequence gnus-variable-list))))) - ;; Encode group names in `gnus-newsrc-alist' and - ;; `gnus-topic-alist' in order to keep newsrc.eld files - ;; compatible with older versions of Gnus. At some point, - ;; if/when a new version of Gnus is released, stop doing - ;; this and move the corresponding decode in - ;; `gnus-read-newsrc-el-file' into a conversion routine. + ;; Sort `gnus-newsrc-alist' according to order in + ;; `gnus-group-list'. Encode group names in + ;; `gnus-newsrc-alist' and `gnus-topic-alist' in order to + ;; keep newsrc.eld files compatible with older versions of + ;; Gnus. At some point, if/when a new version of Gnus is + ;; released, stop doing this and move the corresponding + ;; decode in `gnus-read-newsrc-el-file' into a conversion + ;; routine. (gnus-newsrc-alist - (mapcar (lambda (info) - (cons (encode-coding-string (car info) 'utf-8-emacs) - (cdr info))) - gnus-newsrc-alist)) + (mapcar (lambda (group) + (cons (encode-coding-string group 'utf-8-emacs) + (cdadr (gethash group + gnus-newsrc-hashtb)))) + (remove "dummy.group" gnus-group-list))) (gnus-topic-alist (when (memq 'gnus-topic-alist variables) (mapcar (lambda (elt) --=-=-=--