From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53817: 28.0.91; sh-mode indent misses on 'if test; then' when 'then' is on 'if' line Date: Mon, 07 Feb 2022 00:50:49 +0100 Message-ID: <87y22n367a.fsf@gnus.org> References: <87czk0zk43.fsf@maxeygroup.tech> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , 53817@debbugs.gnu.org To: Doug Maxey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 07 00:52:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGrKH-0003p4-JL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Feb 2022 00:52:13 +0100 Original-Received: from localhost ([::1]:50294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nGrKF-0007KK-W7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Feb 2022 18:52:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nGrK6-0007IK-9v for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 18:52:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46367) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nGrK5-0007TO-Sy for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 18:52:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nGrK5-00087m-PV for bug-gnu-emacs@gnu.org; Sun, 06 Feb 2022 18:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Feb 2022 23:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53817 X-GNU-PR-Package: emacs Original-Received: via spool by 53817-submit@debbugs.gnu.org id=B53817.164419146931154 (code B ref 53817); Sun, 06 Feb 2022 23:52:01 +0000 Original-Received: (at 53817) by debbugs.gnu.org; 6 Feb 2022 23:51:09 +0000 Original-Received: from localhost ([127.0.0.1]:40261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrJF-00086Q-IL for submit@debbugs.gnu.org; Sun, 06 Feb 2022 18:51:09 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:33304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nGrJA-00085s-MY for 53817@debbugs.gnu.org; Sun, 06 Feb 2022 18:51:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mqn4AovCvZsv06vWgZv4d1WR4ztSX7eKidNZzVOXqMc=; b=hDhVFxY81Q3y6DxYWiiRGyn59D hqWbfMhOIwLAuURSi1vtV3oBMlh4FL1SjTtxohvmbobIQqWIlPEaDhCiOCAusntJ7wIBzbZwoPcM6 Ij9YEXkbJpepzeykxc7abCwX/zSG8aNmC9ISbtBIylB37MZJdpRrzg2V+qRghN761nCE=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nGrIy-0001EP-WD; Mon, 07 Feb 2022 00:50:56 +0100 X-Now-Playing: The Rolling Stones's _Black and Blue_: "Cherry oh Baby" In-Reply-To: <87czk0zk43.fsf@maxeygroup.tech> (Doug Maxey's message of "Sat, 05 Feb 2022 22:37:00 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226192 Archived-At: Doug Maxey writes: > However, lots'o bash gets written here, and one of my idioms is: > > if test;then > do something > fi > ^ > The problem seems to be here: (defun sh-smie--default-backward-token () [...] (progn (skip-syntax-backward ".w_'") (or (not (zerop (skip-syntax-backward "\\"))) (when (eq ?\\ (char-before (1- (point)))) Semi-colons have punctuation syntax, so we're skipping back over the entirety of "test;then" instead of stopping after "then". This looks easy enough to fix, but the overall logic of that function is somewhat obscure to me, so I've added Stefan to the comments; perhaps he has some comments. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no