unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Gustavo Barros <gusbrs.2016@gmail.com>
Cc: 54271@debbugs.gnu.org
Subject: bug#54271: 28.0.91; browse-url-of-dired-file fails with wrong type argument error
Date: Mon, 07 Mar 2022 04:57:18 +0100	[thread overview]
Message-ID: <87y21mbejl.fsf@gnus.org> (raw)
In-Reply-To: <87sfructrp.fsf@gmail.com> (Gustavo Barros's message of "Mon, 07 Mar 2022 00:37:06 -0300")

Gustavo Barros <gusbrs.2016@gmail.com> writes:

> As I'd mentioned in the original report, I use this fairly frequently,
> and did not recall having problems with this while using the current
> release. Now I've just checked this statement and indeed, the failing
> example of this report works just fine with 27.2.  So, it is a 28
> regression, right?

Hm, right.  The change on master is too invasive for Emacs 28, though,
so perhaps something like the following would be better:

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index ccb4e12a9f..6c86b8fab7 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -555,8 +555,7 @@ browse-url--non-html-file-url-p
 ;;;###autoload
 (defvar browse-url-default-handlers
   '(("\\`mailto:" . browse-url--mailto)
-    ("\\`man:" . browse-url--man)
-    (browse-url--non-html-file-url-p . browse-url-emacs))
+    ("\\`man:" . browse-url--man))
   "Like `browse-url-handlers' but populated by Emacs and packages.
 
 Emacs and external packages capable of browsing certain URLs


Which reverts to Emacs 27.2 behaviour for these files.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-03-07  3:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06 11:54 bug#54271: 28.0.91; browse-url-of-dired-file fails with wrong type argument error Gustavo Barros
2022-03-06 16:20 ` Lars Ingebrigtsen
2022-03-07  2:28   ` Lars Ingebrigtsen
2022-03-07  3:17     ` Gustavo Barros
2022-03-07  3:27       ` Lars Ingebrigtsen
2022-03-07  3:37         ` Gustavo Barros
2022-03-07  3:57           ` Lars Ingebrigtsen [this message]
2022-03-07  4:14             ` Lars Ingebrigtsen
2022-03-07 10:01               ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y21mbejl.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54271@debbugs.gnu.org \
    --cc=gusbrs.2016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).