From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54437: 28.0.92; command-modes returns nil for native compiled functions Date: Sun, 20 Mar 2022 16:18:24 +0100 Message-ID: <87y214odof.fsf@gnus.org> References: <87y218pr4x.fsf@dell.mail-host-address-is-not-set> <87fsngsfto.fsf@gnus.org> <87a6dosf58.fsf@gnus.org> <87y216owss.fsf@gnus.org> <83fsneezor.fsf@gnu.org> <874k3tq0lo.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10062"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: kahatlen@gmail.com, 54437@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 20 16:19:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVxLC-0002Qd-Sw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 16:19:34 +0100 Original-Received: from localhost ([::1]:57160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVxLB-0001Vn-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Mar 2022 11:19:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVxKg-0001VF-36 for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 11:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVxKf-0005Kw-Qg for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 11:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVxKf-0002ac-L2 for bug-gnu-emacs@gnu.org; Sun, 20 Mar 2022 11:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Mar 2022 15:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54437 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54437-submit@debbugs.gnu.org id=B54437.16477895199924 (code B ref 54437); Sun, 20 Mar 2022 15:19:01 +0000 Original-Received: (at 54437) by debbugs.gnu.org; 20 Mar 2022 15:18:39 +0000 Original-Received: from localhost ([127.0.0.1]:34971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxKI-0002a0-R3 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 11:18:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVxKF-0002Zm-RG for 54437@debbugs.gnu.org; Sun, 20 Mar 2022 11:18:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0wtyj91iaDJmyOOkMHrrvFE0DtVYOmHxfW8x+FdziB8=; b=ZDAt/vBmy8zpmC5uFlbLRKgKp4 wbkAg8ObuiLuwbG2r9ZrOeGpTs1yLoQA2MbMMLqZKfYiYrq7X0EsQgCGZ4zTmbYOCkLrF6AEkugkH q/uE7TQEgI/0UG7BKlhorP9KkVOzdRS3VPfeCZmSj6/xSZgAZON2ttp+fnN+LNmQhMZw=; Original-Received: from 109.179.236.69.tmi.telenormobil.no ([109.179.236.69] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVxK6-00015V-34; Sun, 20 Mar 2022 16:18:28 +0100 In-Reply-To: (Andrea Corallo's message of "Sun, 20 Mar 2022 10:40:05 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228625 Archived-At: Andrea Corallo writes: > Yes, we'd still need to store the information in each .eln and update > the value of this new global hash table each time (probably in > comp--register-subr). So some C should be modified anyway even if > (maybe?) less, I doubt is doable in the realease branch at this point > anyway. There's also the problem with stale entries -- if you're re-loading an .eln with different functions with different command modes, you'd need some way to nix out the old ones (for instance, if a command goes from having modes to not). Or you'd have to register all the commands in the hash table, which seems awkward. I think if we want this in Emacs 28, it's probably safer to just cherry-pick the commit to master, as invasive as that is. On the other hand, the command-modes stuff is new functionality in Emacs 28, so just documenting that it doesn't work with native-comp (yet) would also be fine, and then perhaps do an Emacs 28.2 later with the patch. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no