unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 54481@debbugs.gnu.org
Subject: bug#54481: 29.0.50; [PATCH] Rewrite hl-line
Date: Mon, 21 Mar 2022 16:09:32 +0100	[thread overview]
Message-ID: <87y213mjf7.fsf@gnus.org> (raw)
In-Reply-To: <877d8o8vuk.fsf@dick> (dick's message of "Sun, 20 Mar 2022 11:52:35 -0400")

dick <dick.r.chiang@gmail.com> writes:

> The fashion of dual global and minor modes, each managing a replica of
> state, has long been outmoded by globalized minor modes (nee
> easy-mmode-define-global-mode) around the turn of the century.

Makes sense to me, so I've applied the patch to Emacs 29.  The one thing
I was unsure about was things like this:

> -(defun hl-line-unload-function ()
> -  "Unload the Hl-Line library."

We normally don't remove functions like this, but just make them
obsolete.  But in this case it seems unlikely to me that anybody would
actually ever use these functions, so I didn't alter that part.  But if
anybody complains, we should take them the normal obsoletion route.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-03-21 15:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-20 15:52 bug#54481: 29.0.50; [PATCH] Rewrite hl-line dick
2022-03-21 15:09 ` Lars Ingebrigtsen [this message]
2022-03-22  0:25   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-23  8:48     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-23 11:35       ` dick
2022-03-23 11:55       ` Lars Ingebrigtsen
2022-03-23 13:02       ` Eli Zaretskii
2022-03-22  3:13 ` Michael Heerdegen
2022-03-22 14:12   ` dick
2022-03-22 14:12   ` dick
2022-03-22 14:59     ` Lars Ingebrigtsen
2022-03-22 14:14   ` Lars Ingebrigtsen
2022-03-22 14:24     ` dick
2022-03-22 14:35       ` Lars Ingebrigtsen
2022-03-23  2:21       ` Michael Heerdegen
2022-03-24  3:23         ` Michael Heerdegen
2022-03-24  3:39           ` Michael Heerdegen
2022-03-24  3:53             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-24  4:42               ` Michael Heerdegen
2022-03-24  4:55                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-24  5:13                   ` Michael Heerdegen
2022-03-24  5:51                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-25  3:45                       ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y213mjf7.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54481@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).