From: Sean Whitton <spwhitton@spwhitton.name>
To: Jim Porter <jporterbugs@gmail.com>, 54603@debbugs.gnu.org
Subject: bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks
Date: Thu, 31 Mar 2022 15:48:33 -0700 [thread overview]
Message-ID: <87y20pbuwu.fsf@athena.silentflame.com> (raw)
In-Reply-To: <ade910fc-6a93-960d-3848-d97a6e5e7c89@gmail.com>
Hello,
On Thu 31 Mar 2022 at 03:19pm -07, Jim Porter wrote:
> This could probably be resolved with some additional logic (setting
> `eshell-current-argument' as appropriate?), but I hope there's a
> cleaner way that doesn't involve reimplementing
> `eshell-parse-argument' within `eshell-parse-external-pipeline'.
Well, quite.
Thank you for testing. In the meantime, I've thought it all through
some more, and I think that your original idea of catching the
'eshell-incomplete is the right thing, assuming all tests pass.
I think the error should be caught inside the `or', though? The idea
would be that if eshell-incomplete is thrown within one of the
disjuncts, that disjunct should return nil.
--
Sean Whitton
next prev parent reply other threads:[~2022-03-31 22:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 2:21 bug#54603: 29.0.50; [PATCH] Eshell's external pipe module interferes with other argument parsing hooks Jim Porter
2022-03-31 11:46 ` Lars Ingebrigtsen
2022-03-31 16:26 ` Jim Porter
2022-03-31 16:50 ` Eli Zaretskii
2022-03-31 17:35 ` Michael Albinus
2022-03-31 22:55 ` Sean Whitton
2022-03-31 18:26 ` Sean Whitton
2022-03-31 20:58 ` Jim Porter
2022-03-31 21:55 ` Sean Whitton
2022-03-31 22:19 ` Jim Porter
2022-03-31 22:48 ` Sean Whitton [this message]
2022-03-31 23:31 ` Jim Porter
2022-04-01 21:16 ` Sean Whitton
2022-04-02 1:31 ` Jim Porter
2022-04-02 14:09 ` Lars Ingebrigtsen
2022-04-02 15:52 ` Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y20pbuwu.fsf@athena.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=54603@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).