From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43397: 28.0.50; Adding tool bar items: update tool bar Date: Tue, 03 May 2022 18:09:30 +0200 Message-ID: <87y1zivbr9.fsf@gnus.org> References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> <874kban5vm.fsf@gnus.org> <87tuj9io2e.fsf@gnus.org> <87sfpqws8m.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4420"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 43397@debbugs.gnu.org, Eli Zaretskii , Caio Henrique To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 03 18:17:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlvD3-0000uo-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 May 2022 18:17:09 +0200 Original-Received: from localhost ([::1]:56866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nlvD1-0005mn-Mt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 03 May 2022 12:17:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nlv6A-0005SB-Kc for bug-gnu-emacs@gnu.org; Tue, 03 May 2022 12:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nlv69-0003fq-TH for bug-gnu-emacs@gnu.org; Tue, 03 May 2022 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nlv69-0000QZ-Lo for bug-gnu-emacs@gnu.org; Tue, 03 May 2022 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 May 2022 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43397 X-GNU-PR-Package: emacs Original-Received: via spool by 43397-submit@debbugs.gnu.org id=B43397.16515941991631 (code B ref 43397); Tue, 03 May 2022 16:10:01 +0000 Original-Received: (at 43397) by debbugs.gnu.org; 3 May 2022 16:09:59 +0000 Original-Received: from localhost ([127.0.0.1]:40747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlv5s-0000Pt-5i for submit@debbugs.gnu.org; Tue, 03 May 2022 12:09:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nlv5q-0000PZ-EW for 43397@debbugs.gnu.org; Tue, 03 May 2022 12:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EnZ4L8GMUdbp7giD2sGswX3Po/+7x6sXcTI2iHzS6XI=; b=fqsViX9Iso12Q51RZeFblNti+q by86HYrQIyRfUiPgmdDwT/pGQGg5Jo/nQgnFtD7JrJ8SzLtM4dcsyDdqNuENZx8C7ySvp+bDVomFe upCIftZYNju/26im/iOfa66Fni1cDban61X8+yz3sxMUMrrmNRfzEab8huy9CyQJaLYc=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nlv5f-00082b-5h; Tue, 03 May 2022 18:09:33 +0200 X-Now-Playing: Grace Jones's _Living My Life_: "Everybody Hold Still" In-Reply-To: (Stefan Monnier's message of "Tue, 03 May 2022 11:41:58 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231334 Archived-At: Stefan Monnier writes: > My crystal ball suggests there's a weak hash-table in here somewhere. That's a really good crystal ball: (defconst tool-bar-keymap-cache (make-hash-table :weakness t :test 'equal)) If I remove the :weakness t there, then the toolbar is never updated. So it's a caching problem, one of the two difficult problems in programming. Hm... poking around in that code, I don't quite follow how this is all supposed to be hooked up, or which caches should be flushed. Does the crystal ball have more insights? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no