From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45328: 28.0.50; [PATCH] Compare raw syntax descriptors with equal in `python-indent-region' Date: Mon, 09 May 2022 15:54:56 +0200 Message-ID: <87y1za6cb3.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7255"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 45328@debbugs.gnu.org, Stefan Kangas To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 15:56:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no3rw-0001fJ-Ux for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 15:56:12 +0200 Original-Received: from localhost ([::1]:59602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no3rv-0005e8-Er for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 09:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no3rm-0005W9-7U for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 09:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36829) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no3rl-0005zR-UW for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 09:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no3rl-000360-Nu for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 09:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 13:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45328 X-GNU-PR-Package: emacs Original-Received: via spool by 45328-submit@debbugs.gnu.org id=B45328.16521045099605 (code B ref 45328); Mon, 09 May 2022 13:56:01 +0000 Original-Received: (at 45328) by debbugs.gnu.org; 9 May 2022 13:55:09 +0000 Original-Received: from localhost ([127.0.0.1]:56689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no3qv-0002Up-2B for submit@debbugs.gnu.org; Mon, 09 May 2022 09:55:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no3qt-0002Tz-N6 for 45328@debbugs.gnu.org; Mon, 09 May 2022 09:55:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q7bQtqh+KkonEeheSquhnMFAyWCcqb+T4UxwYxTyba8=; b=ee4pTlU1ajkwOnZmeSrpC/n1X2 GryxXB2XP9QrFrQxSAUqDzKPLKAlz7pGzNtnR+4nLV2Z5Qbtbw48zqcM1cMGdYIkgbhfEftdecsYO fDRz/9+vqcK28bGa1NVBC7e4yNdZ0aFSp4YnQ3Ct8orhA4MHOXpIOCoCrl42jIhrZcQo=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no3qj-0006WV-0c; Mon, 09 May 2022 15:55:00 +0200 X-Now-Playing: Joni Mitchell's _Wild Things Run Fast_: "Solid Love" In-Reply-To: (Andrea Corallo's message of "Sun, 21 Mar 2021 21:19:33 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231744 Archived-At: Andrea Corallo writes: > Uhmm, I thought the patch was correct but re-testing it this is now > breaking the `python-indent-region-5' test. > > Maybe there's a reason why we should use eq there or maybe this is > unveiling a real bug? Not sure, I guess some expert of that code should > probably have a look. I tried applying Andrea's patch to Emacs 29, and it didn't lead to any test failures that I can see (and the patch looks "obviously correct"), so I've now pushed it to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no