unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Thomas Jost <schnouki@schnouki.net>
Cc: 55362@debbugs.gnu.org
Subject: bug#55362: 29.0.50; Super key no longer works on Wayland
Date: Wed, 11 May 2022 20:46:55 +0800	[thread overview]
Message-ID: <87y1z8z16o.fsf@yahoo.com> (raw)
In-Reply-To: <871qx08k43.fsf@schnouki.net> (Thomas Jost's message of "Wed, 11 May 2022 12:00:12 +0200")

Thomas Jost <schnouki@schnouki.net> writes:

> Hey folks,
>
> When using recent builds of Emacs with PGTK on Wayland (Sway), the Super
> key is no longer detected. I use it in a lot of shortcuts, but now
> typing e.g. `s-/' just inputs /.
>
> If I run an older build with the exact same config (or even with `emacs
> -Q'), I don't experience that issue, and shortcuts using Super still
> work. So, this seems to be an Emacs bug.
>
> Using git bisect, I was able to find that this started in commit
> 1c1ae6ba802cc5813fa6f8f90f21050aae6bb459. Further investigation revealed
> that when typing a shortcut with Super, the GDK_SUPER_MASK bit isn't
> set, but GDK_MOD4_MASK is.
>
> I'm not sure what the best option is: restoring the former
> x_find_modifier_meanings() function, or hard-coding that Mod4 is the
> same as Super (like Mod1 and Meta).

The bug is in GTK, not in Emacs.  It doesn't set the virtual modifier
masks corresponding to the Super key on some Wayland compositors, which
it is supposed to.

That patch (and the old code) is incorrect, and the code before its
removal was another example of the PGTK port haphazardly copying code
from xterm.c to do stuff GDK is supposed to do by itself.  Mod4 is a
real modifier and can correspond to any (number) of virtual modifiers,
which might or might not contain Super.

Please report the bug to the GTK developers.  Something along the lines
of "GDK_SUPER_MASK not set on keyboard events on wlroots-based
compositors when the Super key is held down".  After you do that, I'd
appreciate it if you gave us a link to the bug report, so we can at
least put it in etc/PROBLEMS.

Thanks in advance.





  reply	other threads:[~2022-05-11 12:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 10:00 bug#55362: 29.0.50; Super key no longer works on Wayland Thomas Jost via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 12:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-05-11 13:04   ` Lars Ingebrigtsen
2022-05-11 13:22     ` Eli Zaretskii
2022-05-11 13:54       ` Thomas Jost via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 14:09         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 14:08       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 14:14         ` Lars Ingebrigtsen
2022-05-11 14:26           ` Eli Zaretskii
2022-05-11 14:25         ` Eli Zaretskii
2022-05-11 16:22         ` Dmitry Gutov
2022-05-11 13:23     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-10  3:08       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 13:51   ` Thomas Jost via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-11 14:09     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-24  8:34 ` daanturo
2022-11-25  0:37   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1z8z16o.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=55362@debbugs.gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=schnouki@schnouki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).