From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20663: page.el (forward-page): Avoid skipping pages Date: Thu, 09 Jun 2022 12:21:55 +0200 Message-ID: <87y1y687cs.fsf@gnus.org> References: <20150526171440.GG647@gmail.com> <877d7h2uic.fsf@gnus.org> <87pmjje5mt.fsf@kraus.my> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 20663@debbugs.gnu.org, Pierre Neidhardt To: Daniel Kraus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 09 14:35:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzHOB-0006Md-Kr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 14:35:51 +0200 Original-Received: from localhost ([::1]:45446 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzHO9-00068b-Cz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 08:35:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzFJe-0007cP-Hz for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51161) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzFJe-0000xS-6s for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzFJe-0001TE-1a for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 10:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20663 X-GNU-PR-Package: emacs Original-Received: via spool by 20663-submit@debbugs.gnu.org id=B20663.16547701295571 (code B ref 20663); Thu, 09 Jun 2022 10:23:01 +0000 Original-Received: (at 20663) by debbugs.gnu.org; 9 Jun 2022 10:22:09 +0000 Original-Received: from localhost ([127.0.0.1]:45058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzFIn-0001Rn-11 for submit@debbugs.gnu.org; Thu, 09 Jun 2022 06:22:09 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzFIk-0001RD-EQ for 20663@debbugs.gnu.org; Thu, 09 Jun 2022 06:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dwSc0r0Wr5ozQWeOeaS83Qe4ZhPYsQvS4mC79l/gxMI=; b=kgHDzQ2Lkh9nM7fhPLZNm/qRxV qkAAwo2dZlyMWskBURzyrXRBcxJW5RLKKrliIwVwzmpA+YA8S9KjiXdkaauVcD3rnlVpz09GG/4k5 TJV+X/riVLx6MsPmt0v0bmSu+FHi0H04LE0zp8rZJoOXRnxqw8aIVveBegnciNL+XvSw=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzFIa-0006H1-BE; Thu, 09 Jun 2022 12:21:58 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXCta2+sarFubG3 q6WwpZ6topupnpfNwLj///+vw1mlAAAAAWJLR0QIht6VegAAAAd0SU1FB+YGCQoNFStl92UAAAF1 SURBVDjLbVPJTQRBDLRNArYmAat5zBs1hLAhEAIJkP8DX+3pWdZaIabKt6sBGcZmMBQcQHBrWIMr M5fGoQ0bBBoeqhehBnm8iPh3mYDhan/QcGGwXwYIRK1EMYIyYBqR4dY2gnTtw4ixiN0EVufY3tHM gNV+EQ3mf+pDsOxLSK8cS2hfWm3lln/f2GWUu6tma3JS0pGVYJDG/mxoCfe7IYvcgP7yRBtnU5F2 9Fpt+K3ie48cBBdOebE4XhyNYzy6XT1aYXMl7/NtPuYnRyXx4rL28P7z/fXgukvWyDznb6VCYXQi k59j4asjXnXPTXLeube0qVfXUFCC3a9AjvoPnohKB7yrvYQLsatr8mddaRQMj/0Z3A70TwTIry+I rvZdvf1QgukvoOsF9cEVWuhUmuaSKxUxlg4iinqk4U8who066x342tNZ5ocToyRgiSmIY05jWm1j 9eT4lLq3R0YrKDNM2hhTd0cSXiXNmjFtNR4xmVP+ALMAQJrUEnDKAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA2LTA5VDEwOjEzOjIxKzAwOjAwMY8jwwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w Ni0wOVQxMDoxMzoyMSswMDowMEDSm38AAAAASUVORK5CYII= X-Now-Playing: Massimo's _invalidObject Series (var)_: "function Jump() {" In-Reply-To: <87pmjje5mt.fsf@kraus.my> (Daniel Kraus's message of "Wed, 08 Jun 2022 13:50:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234036 Archived-At: Daniel Kraus writes: >>> When `page-delimiter` starts at the beginning of the line and the position is >>> also at the beginning of the line, calling `forward-page` will skip one page. >>> >>> Running `emacs -Q example.txt`: >>> >>> M-< >>> C-x n p >>> M-> >>> M-1 C-x n p >>> >>> This should bring us from page 1 to page 2, but page 3 gets >>> displayed instead. [...] > This patch seems to change the behavior of `forward-page` compared to before. > Before when the point was inside (/beginning) of the page-delimiter regex > it would jump imho correctly to the next page. > > Now it just skips the page delimiter and goes to the end. Well, that was the point of the change, really The problem with the old behaviour was most obvious when narrowing to a page. If you're narrowed to page 1 (with point at the end of the buffer), issuing a "go to the next page" would take you to page 3. I.e., there was a disconnect between what it was considering the "current page" and how narrowing to a page would display that, and the change made these things match up -- now (with point just before the page delimiter) it says that it's on the previous page, not the next page. Perhaps this should be tweaked for longer page delimiters, so that we're on the next page when point is inside the delimiter? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no