From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56255: 28.1.50; sxhash-equal does not change when object is modified Date: Tue, 28 Jun 2022 00:56:48 +0200 Message-ID: <87y1xhu34f.fsf@gnus.org> References: <87v8sm70ma.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24559"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56255@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 28 00:58:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5xgO-0006BW-Ty for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 00:58:16 +0200 Original-Received: from localhost ([::1]:40480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5xgN-0006bL-IV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 18:58:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5xgA-0006T2-Bb for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 18:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5xgA-0001cu-3e for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 18:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5xgA-00058P-1j for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 18:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2022 22:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56255 X-GNU-PR-Package: emacs Original-Received: via spool by 56255-submit@debbugs.gnu.org id=B56255.165637062519670 (code B ref 56255); Mon, 27 Jun 2022 22:58:02 +0000 Original-Received: (at 56255) by debbugs.gnu.org; 27 Jun 2022 22:57:05 +0000 Original-Received: from localhost ([127.0.0.1]:53566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5xfF-00057C-As for submit@debbugs.gnu.org; Mon, 27 Jun 2022 18:57:05 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5xf9-00056e-Ty for 56255@debbugs.gnu.org; Mon, 27 Jun 2022 18:57:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EMkHLPzg8bALJABVuxIfuRfdXAIatFxjrrNvWO+DG9U=; b=U6zEyTr15K9dTwlCjyFN0UHPXe sqVOvaTf5PXHLr03dC82FzgOs1LJk+9KaEFaZebAUDwNCazir5h+RQGpsIJYGTGWeSY7QqiTWUW25 UXaOBtafiE7hnURhJ61Tv5fGYv+2dD0hXbSB6JUkVH/er+PndeoAVMY2j0KtC+ZgeTrg=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5xf0-0003Ic-45; Tue, 28 Jun 2022 00:56:53 +0200 X-Now-Playing: Arthur Russell's _The Deer in The Forest (March 2 1985: Live at Roulette)_: "Singing Tractors" In-Reply-To: <87v8sm70ma.fsf@localhost> (Ihor Radchenko's message of "Mon, 27 Jun 2022 20:27:09 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235504 Archived-At: Ihor Radchenko writes: > The result of sxhash-equal does not change despite `a' object being > changed. Here's a self-contained example: (require 'org-element) (setq c (avl-tree--create #'org-element--cache-compare)) (avl-tree-enter c '(headline (:begin 2))) (setq d (avl-tree--create #'org-element--cache-compare)) (avl-tree-enter d '(headline (:begin 5))) (equal c d) nil (sxhash-equal c) 1776904311275 (sxhash-equal d) 1776904311275 This is due to: /* Maximum depth up to which to dive into Lisp structures. */ #define SXHASH_MAX_DEPTH 3 Since this record nests to a depth of 4, and that's where the difference is. So I think the doc string overstates things. -- If (equal A B), then (= (sxhash-equal A) (sxhash-equal B)). -- Is not remotely true, but: -- If (= (sxhash-equal A) (sxhash-equal B)) then it's quite likely that (equal A B), but the opposite is not true for deeply nested structures. -- -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no