From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56641: Deprecate `lsh` Date: Sat, 23 Jul 2022 18:42:56 +0300 Message-ID: <87y1wj96nz.fsf@tcd.ie> References: <87a69047eb.fsf@gnus.org> <4C2D62F6-0581-4E0D-8C2A-AC5235C976A5@acm.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13050"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: mattiase@acm.org To: 56641@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 23 17:44:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFHIm-000379-On for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 17:44:24 +0200 Original-Received: from localhost ([::1]:36978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFHIl-0004An-HN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 23 Jul 2022 11:44:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFHIQ-00049q-5v for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 11:44:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFHIP-0000r3-Sz for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 11:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oFHIP-0008O4-Jd for bug-gnu-emacs@gnu.org; Sat, 23 Jul 2022 11:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2022 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56641 X-GNU-PR-Package: emacs Original-Received: via spool by 56641-submit@debbugs.gnu.org id=B56641.165859098932136 (code B ref 56641); Sat, 23 Jul 2022 15:44:01 +0000 Original-Received: (at 56641) by debbugs.gnu.org; 23 Jul 2022 15:43:09 +0000 Original-Received: from localhost ([127.0.0.1]:46088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFHHZ-0008MG-6U for submit@debbugs.gnu.org; Sat, 23 Jul 2022 11:43:09 -0400 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:46669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oFHHU-0008Lg-A3 for 56641@debbugs.gnu.org; Sat, 23 Jul 2022 11:43:08 -0400 Original-Received: by mail-wr1-f47.google.com with SMTP id z13so10170495wro.13 for <56641@debbugs.gnu.org>; Sat, 23 Jul 2022 08:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=HjNWc/859NlVyojGcIG+IqoMcJdeXfMCcnhAJLfS89o=; b=fQSicFsCVNxaV0ozj+LTclhec9n9Gz7ZxjMYCQSqeOGjiNSCGUzkEUhr3SsIY13udE PRjWx6ncME/yAT7Dk8eJbb4hpceuh9wF612IqhJVK5CxiL+W6oFUFFSW0c41BLujw4Ya Eg+snczVfR3WOgF9pxLoeZX9z3FLBsSG7EJeoXNbN+A3SgGjSOHfggISyyK9ouA2zKNg 8hDavfFyug1rCpNeFYfmp4GsY06qz9uxQvjWgJ+54Q7BI5bylhMW1L7JdX5Z0o/XCX2E W1KbC6tvA6obKBrQCZHpoDm+p2R9yKClWZ2MCurmmyZUnTBF0V/0vnrqIdpnsh9mDsjd ZhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version:content-transfer-encoding; bh=HjNWc/859NlVyojGcIG+IqoMcJdeXfMCcnhAJLfS89o=; b=ntLszuh2jLBCYd4ZNqxqYbDX+peZ0L6bXs8i/pLjIDqyMCdwhC1NOnZocBE5kx8+3n I6q77GIiGYibKWaAci7kF74NjBRj5EObdAXfo/5hNuGg0D/+cINy1T5sJptu9XleiLsM eWOcx3iR9OhCkyxnxTqpzoTGoM0mjIasromgJHaGXfdKwuhXc/LxTbYDGWOGQzfBgAJN IvJm5nAwKoDp9F2+1ukxrrsDckegzpCXEDazzhWUUDgU6tpyo0e6z3DOiADh2JZocTUS ECObp3TEHdc3x2Xzz1IIw7WIGf+IiCSzPBGzhHgDwW13OAIvfTg0HIJQOiEZK3gl9CS5 6spw== X-Gm-Message-State: AJIora+CouBPnO79iuMbLzZFt3O0iMsLaKsLJb523fPAR/7aHJ4uv/t6 TcxtL7U8l0zcqSud+HazY8skU241LqwCzg== X-Google-Smtp-Source: AGRyM1vjlRu/4G8U4k/B/WW+gxLHO4SzteuEWOPUiNZJW1NbTTTmW0Nn0n4LkCnxUxy3A8Hrgsp7pA== X-Received: by 2002:a05:6000:2a4:b0:21e:6e0e:df1f with SMTP id l4-20020a05600002a400b0021e6e0edf1fmr2660145wry.516.1658590977953; Sat, 23 Jul 2022 08:42:57 -0700 (PDT) Original-Received: from localhost ([2a02:587:320a:74a5:f794:77c1:e192:d382]) by smtp.gmail.com with ESMTPSA id j13-20020a5d448d000000b002167efdd549sm7138301wrq.38.2022.07.23.08.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jul 2022 08:42:57 -0700 (PDT) In-Reply-To: <4C2D62F6-0581-4E0D-8C2A-AC5235C976A5@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Sat, 23 Jul 2022 12:32:24 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237761 Archived-At: Mattias Engdeg=C3=A5rd [2022-07-23 12:32 +0200] wrote: > There is now a compiler warning about calls to `lsh`. Thanks, but the warnings are being stubborn with and not listening to me. Could you please have a word with them? First, they are a bit repetitive in parallel 'make -j8 check': In toplevel form: lisp/international/ccl-tests.el:29:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:29:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:33:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:33:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:37:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:37:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:41:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:41:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:29:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:33:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:37:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:41:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:29:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:33:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:37:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:41:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:29:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:33:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:37:15: Warning: avoid `lsh'; use `ash' inst= ead lisp/international/ccl-tests.el:41:15: Warning: avoid `lsh'; use `ash' inst= ead Note that each warning is emitted five times. The same happens with src/data-tests.el. Some ERT quirk perhaps? Second, wrapping the respective ert-deftest bodies in (with-suppressed-warnings ((suspicious lsh)) ...) or (with-no-warnings ...) does not actually silence the warnings. Interestingly, suppressing warnings around the whole ert-deftest form eliminates the duplicate warning lines, but still emits the originals. Third, the docstring of with-suppressed-warnings says: The types that can be suppressed with this macro are `free-vars', `callargs', `redefine', `obsolete', `interactive-only', `lexical', `mapcar', `constants' and `suspicious'. For the `mapcar' case, only the `mapcar' function can be used in the symbol list. For `suspicious', only `set-buffer' can be used. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Fourth, the warnings seem to be nondeterministic, sometimes being emitted only for one of the two files in question, and sometimes for neither file (particularly with serial 'make check'). How can these issues be addressed? Thanks, --=20 Basil