From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56739: 29.0.50; `cl-psetq' and `cl-psetf' fail to recognize symbol macros Date: Wed, 03 Aug 2022 02:20:55 +0200 Message-ID: <87y1w6xjmg.fsf@web.de> References: <8735eeyz7e.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22134"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56739@debbugs.gnu.org To: Wing Hei Chan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 03 02:22:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJ2A6-0005cE-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Aug 2022 02:22:58 +0200 Original-Received: from localhost ([::1]:44826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJ2A5-0001oY-0J for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Aug 2022 20:22:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ29F-0001Dp-C3 for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 20:22:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJ29D-0004cC-Cr for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 20:22:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJ29C-00017N-Bb for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 20:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56739 X-GNU-PR-Package: emacs Original-Received: via spool by 56739-submit@debbugs.gnu.org id=B56739.16594860724237 (code B ref 56739); Wed, 03 Aug 2022 00:22:02 +0000 Original-Received: (at 56739) by debbugs.gnu.org; 3 Aug 2022 00:21:12 +0000 Original-Received: from localhost ([127.0.0.1]:45530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ28N-00016G-Kq for submit@debbugs.gnu.org; Tue, 02 Aug 2022 20:21:11 -0400 Original-Received: from mout.web.de ([212.227.15.14]:44631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ28H-00015M-Md for 56739@debbugs.gnu.org; Tue, 02 Aug 2022 20:21:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1659486056; bh=aezxof+s/wJbi8nzTBQjcU2EOJdvtqSmKxzlq+RsIzc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=E6lNSTWkCbXabCjpreEuZpFv5dqajPrQktZ+6rC0SvGC/57W9gv2X2eXfrjTjnOHx gZ3hiMa5Kj5nNw/WvJk8KEtmJDxMcZvBFPA4Ktc/raRvUs0ndLKIjycBsJmi8MwM9y fS70z21a2v2BYebKO6sAlV8uP0m02CT7wbrdPRok= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MGQC9-1oDC2H0xYL-00GfSx; Wed, 03 Aug 2022 02:20:56 +0200 In-Reply-To: <8735eeyz7e.fsf@web.de> (Michael Heerdegen's message of "Wed, 03 Aug 2022 01:59:01 +0200") X-Provags-ID: V03:K1:NMcqkymw3rA7QjOE3ny6oWJtmgA+iMwadkxh/pbeyl8rsCe4mxA LBMTAKFlqbnFr64t22p6/stfXafuk1yMpXS+esI+QodeeuVJvGMRVLS74asWgFM8ZEhZ4ib TAn4Zm8YkGT+RLtgj03F7pPw7qzXOq/Ivw0A9hMxX2v1kTdbmIKmvkMP8v5/TpNWiPq51Dn 9ty9VmXNVb5mb8UQdxXFg== X-UI-Out-Filterresults: notjunk:1;V03:K0:4jVbzibFpiE=:jCQH7qVtC8bHM+0vYIbNWJ 2Inhfe7boNca6MDsdHRgaGwOQPgk2Jq0FFMKl1MOdw8Iv6SRU/wxrwjXaHm3wpDbKtK7wtMUv /aBcVguCbxNn/xeOlR3nGQR36lQCBVl8dmUmzpNMLw/zq5XwUJELlLiBuDFEu3EMptRLx7R3v CK8hv/92Knxocyyl6KcSPHP2eiz4BO0NZb2IIY+a/QMDKAi942C2gOC6rZxk3rIKSm3wzcQVC 7ivQjRfkCpUh0suSGL2bprWCJpOQUm6lISNq1JnN/u9dCPiHukPP3U0gCEuzpHi537h7PVUO1 7rcBQy4Bhzy0Yxu7HIT5KSPqK7Bh6b0MeTos1MIX/Bpm6b0W2+fZy6IEeOdpQh4wv5THDTl4n M9qgZlHvZjoSd2f9V/cTa6SabUIz9LI5vHIJSN7irKLdQfbP8Ip8KDEr5tKMSo90ZDPLY0+57 xwvGVphEz//KF8EfPuqkrWpikHmva8ndX5TY9/RGE3Ych/Ubxhkr1xFg5jzbsUEARIFjbvaIo Z8mrMJml+sC6TBaqcdIXJGcaZOpL6pt4NmFkMwL6KTG9AXy230pfd6Y6yP/HhnsHVmjplwKWi oeRTLI+/vch7AXToR6Mfyio08Tkc+DnJxKuz09a5GwAWrrctAcEf/KG3UJrsNZAyNavoSPcme OBhuNfWyxPPvixfbfqL2CNX276APU0UosZVmET7GsZjpD2q45U3Ury4af/uY68187LguTL8Tl x4ELHiKS2Z2bVlYwzhmPUG+AJFSH8qp0ZNO3ORkeUOk93B+g1MK6VpkB3Mt9/RPyreyhe9tE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238602 Archived-At: --=-=-= Content-Type: text/plain Hello, I think we can fix this (both cases mentioned) similarly as in cl-letf: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Fix-symbol-macros-used-in-cl-psetf-Bug-56739.patch Content-Transfer-Encoding: quoted-printable =46rom 29ea21a751ab6e71b2fb34c781131e31fc7b950d Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 3 Aug 2022 02:06:16 +0200 Subject: [PATCH] WIP: Fix symbol macros used in cl-psetf (Bug#56739) =2D-- lisp/emacs-lisp/cl-macs.el | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 78d19db479..f3051752ba 100644 =2D-- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2653,12 +2653,17 @@ cl-psetf \(fn PLACE VAL PLACE VAL ...)" (declare (debug setf)) - (let ((p args) (simple t) (vars nil)) + (let ((p args) (simple t) (vars nil) + (smacros (alist-get :cl-symbol-macros macroexpand-all-environment= ))) (while p - (if (or (not (symbolp (car p))) (cl--expr-depends-p (nth 1 p) vars)= ) - (setq simple nil)) - (if (memq (car p) vars) - (error "Destination duplicated in psetf: %s" (car p))) + (when (or (not (symbolp (car p))) + (assq (car p) smacros) + (and (symbolp (nth 1 p)) + (assq (nth 1 p) smacros)) + (cl--expr-depends-p (nth 1 p) vars)) + (setq simple nil)) + (when (memq (car p) vars) + (error "Destination duplicated in psetf: %s" (car p))) (push (pop p) vars) (or p (error "Odd number of arguments to cl-psetf")) (pop p)) =2D- 2.30.2 --=-=-= Content-Type: text/plain But I'm not a fan of symbol macros any more: the concept sounds nice first, but actually you only save one pair of parens when coding while they introduce a special case that one always has too keep in mind for macro expansions: any symbol might not just be a symbol. I guess this is not the only place where they are not handled correctly. Michael. --=-=-=--