From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Fri, 26 Aug 2022 13:29:22 +0000 Message-ID: <87y1vbjfpp.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <83sflj1dbo.fsf@gnu.org> <87fshjmeje.fsf@posteo.net> <83mtbr1b6l.fsf@gnu.org> <87tu5zky6k.fsf@posteo.net> <83lerb197w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21801"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57400@debbugs.gnu.org, ane@iki.fi To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 15:44:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRZdk-0005ZD-Qs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 15:44:53 +0200 Original-Received: from localhost ([::1]:60814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRZdj-0005aC-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 09:44:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44550) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRZPQ-0001Jk-OZ for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34748) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRZPQ-0005ZS-Ef for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:30:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRZPQ-0003Gf-4J for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 09:30:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 13:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166152058112482 (code B ref 57400); Fri, 26 Aug 2022 13:30:04 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 26 Aug 2022 13:29:41 +0000 Original-Received: from localhost ([127.0.0.1]:52726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZP3-0003FF-7A for submit@debbugs.gnu.org; Fri, 26 Aug 2022 09:29:41 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:39965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRZP0-0003F1-Pm for 57400@debbugs.gnu.org; Fri, 26 Aug 2022 09:29:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E9E9F240027 for <57400@debbugs.gnu.org>; Fri, 26 Aug 2022 15:29:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661520572; bh=/KExMXW469SfSsKOCSvgCt7yeNANQktNhFk3ZGF/jEQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=IRb8y/RCRw/+AKBehFvxmqSBh8yRzAINbDKj7bhxAamjl62QHW1iSdf3TGqLutpRl tTOCCXaCDutw/IerIlzRCUsJvbzLQK8OfHhEMWfMYos0fYvZoAmvYu6lh/zRbFzxy7 1x+lwjc8xWmjGw7Cg+H6yCRenpYKzjYBgM0tf3pYUrsRS/S/I4I9v6f+hAnR8LVrgQ 1dls/noQvu5KLV5RViP0CgHcaLiO/ejwotGeNU96Sc1rmo+C+YEHsxS0mvxYIHzWGE 4p9YydXX+jD773jBicyylMUq3JEF7nncQzEepyViA/N8vwWRQmyq2hqvIUHkhjTRjh o40RDYU9kNftA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MDgfd4W8Zz9rxK; Fri, 26 Aug 2022 15:29:27 +0200 (CEST) In-Reply-To: <83lerb197w.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Aug 2022 15:26:59 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240838 Archived-At: Eli Zaretskii writes: > >> From: Philip Kaludercic >> Cc: ane@iki.fi, 57400@debbugs.gnu.org >> Date: Fri, 26 Aug 2022 12:05:07 +0000 >> >> >> > Also, I'm not sure why we'd need to send each patch file separately. >> >> > Why not add them one by one as attachments to the same email message? >> >> >> >> This wouldn't work if we are sending patches to a mailing list that >> >> assumes patches are sent out by git send-email, and that the messages >> >> can be filtered through git am. >> > >> > "git am" handles attachments without any problems, I do it all the >> > time. >> >> Only if the MUA can recognise the patch and pipe it into a git am >> process. > > What do you mean by "MUA can recognize" here? which Emacs MUA > recognizes Git-formatted patches and applies them? The MUA recognizes the patch as a an attachment. E.g. in Gnus the patch is highlighted and "|" is bound to a command that pipes the contents of the attachment through a command. > What I do is invoke "M-|" and send the region to "git am". That > requires myself to recognize the patches, not the MUA I use. I hadn't considered that, but again, if we are thinking about preparing messages that are sent out to other developers using other MUAs, then I don't know if this kind of functionality is available. >> But if we are trying to re-create the behaviour of "git >> send-email" (as I think is necessary if we want the feature to be of use >> outside of Emacs circles, such as sending a patch to the Linux Kernel >> Mailing List), then we need to consider people using clients like Mutt >> or Aerc (https://aerc-mail.org/) that just pipe the entire message >> through "git am". > > Do you intend to provide a VC front-end to applying the patch-set, as > part of this job? Because if not, what happens on the receiving end > is out of the scope of the feature we are discussing. No, this is just about sending patches, but if the patches sent out are of no use to the developers receiving them, then the feature is not as useful as it could be. >> > But I don't object to having optional behaviors here. My point is >> > that we should allow sending all the patches together, as that is the >> > preferred/usual practice in Emacs development. >> >> Of course, the idea that was proposed on emacs-devel was to have this >> behaviour be controlled by a (file-local) variable that could be set on >> a per-project basis. > > We should have a user option that doesn't require project.el > (project.el can override it, of course). There should be no > requirement to use project.el to send patches from VC. There should be no need for project.el, this could just be set in dir .dir-locals.el file in emacs.git. But I don't think there is an actual issue here, the plan has been all along to provide both kinds of patches (git am-style, attached) to be sent out.