From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Wed, 21 Sep 2022 11:46:06 +0000 Message-ID: <87y1udlzlt.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <877d269kgv.fsf@gnus.org> <87bkriyqci.fsf@posteo.net> <874jxa6kyj.fsf@gnus.org> <87o7vdg97w.fsf@posteo.net> <831qs926np.fsf@gnu.org> <871qs9fzz5.fsf@posteo.net> <83h715yxz2.fsf@gnu.org> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19612"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 57639@debbugs.gnu.org, Protesilaos Stavrou To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 13:51:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oayG1-0004qx-1p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 13:51:13 +0200 Original-Received: from localhost ([::1]:40392 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oayFz-0005aW-UI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 07:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oayC7-0004C2-9Q for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:47:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33644) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oayBy-0001Y0-81 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:47:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oayBx-0002nk-Vy for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166376078010719 (code B ref 57639); Wed, 21 Sep 2022 11:47:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 21 Sep 2022 11:46:20 +0000 Original-Received: from localhost ([127.0.0.1]:60955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayBI-0002mp-88 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:46:20 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:56783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayBG-0002md-E0 for 57639@debbugs.gnu.org; Wed, 21 Sep 2022 07:46:19 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DFD6F240104 for <57639@debbugs.gnu.org>; Wed, 21 Sep 2022 13:46:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1663760772; bh=n3KvYLs/2FmlOJkGdHMfeJPDMlAJEwdBVhmEWvUg8RM=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=O5nLZxOanFasjaeSLU/xskK55ewBfPT2kmKfawTPSWhI43X89OdHmbfDG0WotPkrN 5BV2egPN3M8kMieuy9H30ykmONo7vTus0lo3HpmIUijsyYbEDAHNmRrtU19Aoww4WZ dU4n3T07Ik3FtIOCGue93hD/FRSUtVzdB4z+aek6kVzudH1x+at4B9u2ycDMBQbCis 7wKwqwc0LewaE3S+lAs11thItt7C8gNsQ3skWmXbYcOvKN6IkHyqsmKNbL8P1bAvNM 04LoDIIy4e/itFgiMKHHHDKrs7V/0kpEFyLxmlyluDv7GTPW5NxCKj/j/WxuBH+uRR WWvSK0aBCRhmg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MXc7R6YCyz6tmK; Wed, 21 Sep 2022 13:46:11 +0200 (CEST) In-Reply-To: <871qs57yai.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 21 Sep 2022 13:38:13 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243309 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> Ok, that sounds good. Here is the updated patch: > > [...] > >> This is actually done a few times by the modus themes and at least once >> by `leuven-dark' (see `leuven-dark-scale-font', tough I don't see why, >> and if the autoloads aren't being generated to begin with the cookie is >> pointless anyway). >> >> Should this be addressed before the patch is pushed? > > Hm... are these themes also distributed via ELPA or something? But in > any case, I don't see why you'd have: Modus-themes is distributed via GNU ELPA, and Leuven via MELPA. I didn't modify Modus-themes because I know it is sync'ed back regularly, but now that I think about it I don't know if I ought to have changed those either... > ;;;###autoload > (defun leuven-dark-scale-font (control default-height) > > If you've activated the theme, you've loaded the file, so autoloading a > function like that doesn't seem helpful in any case. > > So I think that sounds like it's just a mistake, and the ;;;###autoload > should be removed. And the same with the commands autoloaded in modus > themes? But perhaps there's a reason; I've added Prot to the CCs. > Perhaps he can clarify why those autoloads are in modus*.el. > > But this looks more problematic: > > ;;;###autoload > (when (and (boundp 'custom-theme-load-path) > load-file-name) > ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. > (add-to-list 'custom-theme-load-path > (file-name-as-directory (file-name-directory load-file-name)))) > > We don't want that in the Emacs loaddefs file, so just adding etc/themes > to our Makefile won't be the right thing to do, and we have to find a > different way to fix this. > > Uhm... Uhm... I don't immediately see a good way to fix this... There probably is not automatic way to resolve this issue, but perhaps it might be enough to remind all the external theme maintainers to remove these snippets before updating the files in emacs.git.