From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57969: 29.0.50; `device-class' errors when NAME is nil Date: Wed, 21 Sep 2022 19:53:40 +0800 Message-ID: <87y1udeyez.fsf@yahoo.com> References: <87r105tblc.fsf@gmail.com> <87k05x6jas.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20565"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 57969@debbugs.gnu.org, Visuwesh To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 14:07:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oayVL-000552-Ui for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 14:07:04 +0200 Original-Received: from localhost ([::1]:41202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oayVD-0003zi-Az for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 08:06:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oayIo-0000hq-39 for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:54:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oayIl-0002j8-9J for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:54:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oayIl-00031i-5N for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 07:54:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 11:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57969 X-GNU-PR-Package: emacs Original-Received: via spool by 57969-submit@debbugs.gnu.org id=B57969.166376124111610 (code B ref 57969); Wed, 21 Sep 2022 11:54:03 +0000 Original-Received: (at 57969) by debbugs.gnu.org; 21 Sep 2022 11:54:01 +0000 Original-Received: from localhost ([127.0.0.1]:60984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIj-000318-Ew for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:54:01 -0400 Original-Received: from sonic315-20.consmr.mail.ne1.yahoo.com ([66.163.190.146]:37038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIf-00030s-1o for 57969@debbugs.gnu.org; Wed, 21 Sep 2022 07:54:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663761230; bh=omlwB6blVITcLNTvXbcTYznu8Vjsn3QEZAci0vSFkkg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=q6gxB7cxPtC5l88j0aV9qcxWQutsoxJv1nj6R4X+ILYPESylyw3DYo6LgBHVkD+YY+ik9mO0m6e/UZptUi7hnTvs32q0/36ocyHPL0Ghijyhccask777Heh3KI+oN7+e+lHUVBv2y7XgYOWW0lJguGFyWtmKN4LcfypgeF9QCEsOiRT/IV+CFpeVoxs88Y/eCTug7tWdHF4wyDWwl5oleTMU86fczPik08+QJIcLHJCXEzCjo20yuuuMXpjoa+BOS8digRVoRv/e3B8kK/cOe+F5far9IlZPsAN57ps7y2YBqymDbpQo9fOuH6n5r8wk1NiMivevU2Zc7RuQ+gkHdQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663761230; bh=c0wFiEyGEfPINvHKAxIEvhpK/EpPruqiq8vC1lx3WhB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=BJX3V4xR/SKNkivrvh/cKfYKTgmnkJN/nRystxB8eskGWr6JVW2TbdNkBRzE+czGJlHIa4JrD0JLhhzqDnnnV5i934pyCX43OZom5BlaDe8LcQXZwKExUs01ofKYOl3viGB6wbxk5I5uL2gG7DzKmillmmY30MwA1xY5UyY3Gy6qThiMEQWoJBZMBkltC5Zq9vFbrTUytvxNQVHUIco2TPbqulijqKJ33Y/2pKJQsBaP3QejqS2tP30Y5CEFXn7rz6htZQFyWTXCTd0RVjNAGPrzCFJvlALvd+2JGRfPc3lba7kwThu9WAKeUYzpnLmU5RL0lerSkoy1x9u7EE+gcg== X-YMail-OSG: jnulUOgVM1l18dg.103KJH5Z1KngD_a7vmA7gVK9Oii3OVfOkMO7ydi.UxqMuZL GS2oC_pSMzUeEmVxqoT.ttYzkQ5o5gKnbJnKwp2.BrMfhBgE58bGXmFit43Rj0ZVgDq3c6P5J42u zmPLaz4S7RJyGYmPUnxA1C.Xmywfavymk.fu2Zk2iNkIhgW2_P5ZNr71lWkWDNJJ4qYA8RVhOWl6 Sl3u62y7Y3VqoblRfz4a7lSPfx3as1qWZ6fpwIQB.i6hYbc.DNo.XcOROooTpjLWlyH.vDkYQ2HZ 5ItJ286nzxfkLZUuvK0wJHYfiAxAZdR3upiV1Xie.FOISwkYezqIn6IWqou0PmAyT2XnMhyX7D5o cQ.MlUH_lEM1bIITX26NXZ2ElPANJLJe.vpaiCvXd0xbCaN4NLV8w3EtHZ0UT7wWs9VWNcgM.kO2 7QoGmnKUQ8S7uvog0EyNE4Ck1bGVdOdXbzDuMJEWV4EIR8RdWaI33249XC9lUNVqmoikGx5kIeyk jfjFxDhK1FEHrnPKdyjAKxIiTc2cI6JH3dHd7m2NeOs9FV0_mPv1q9rBJvgzs7rLTmkK9w53nEfU PuP6.dsSVvtOPDcfMsnTqiEYjxAzfjive6I816REQTrNcWHfeyzXnsW2FdYC4HM5pezPcYKNG6Uc GRC9IZ7CVLszBlV1th5o6Qb1ly3Ap1a9ctAdUH.3pwO08XP7ttVXrvKKa3xCh_NeMcPfQoNse07A DVoF602Gu8sNIcwkhEGVotuB5EuSXDj3RueaxN3Kfdd4OC9RAkq6.f50EWeT9mgYKkUpClL6Ke9p STZzLHaVoEbHUBW9UF30N7WMDvhcmlwD_.rWO7HYo. X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.ne1.yahoo.com with HTTP; Wed, 21 Sep 2022 11:53:50 +0000 Original-Received: by hermes--production-sg3-6d76f6b48d-sxspw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7385cec5ada702a3faf430941497c160; Wed, 21 Sep 2022 11:53:45 +0000 (UTC) In-Reply-To: <87k05x6jas.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 21 Sep 2022 13:47:23 +0200") X-Mailer: WebService/1.1.20663 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243316 Archived-At: Lars Ingebrigtsen writes: > Visuwesh writes: > >> According to the docstring of `device-class', nil is a valid value for >> the NAME argument however it errors out since `x-device-class' uses >> `downcase' without checking if NAME is non-nil. Backtrace is below, >> >> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil) >> downcase(nil) > > Yes -- > > -- > Return the class of the device NAME for an event generated on FRAME. > NAME is a string that can be the value of last-event-device, or > nil. > -- > > But it's not clear what the meaning of nil should be. Perhaps Po Lu > knows; added to the CCs. It does say later on that if the type could not be determined, the return value is nil. So that is what I made it return. > (And if nil really is a meaningful value for NAME, and not just a > documentation error, then perhaps that argument should be optional?) Well, no, it's only intended to be valid so you can do this: (device-class last-event-frame last-event-device) FTR, I consider `device-class' and `last-event-device' low level interfaces that will be eventually replaced with a better user-facing one, based on keymaps and virtual function keys, but that is still WIP. Thanks.