From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#58543: 29.0.50; The 'q' key is not shown by "C-h ?" Date: Sun, 16 Oct 2022 22:39:35 +0000 Message-ID: <87y1tf1jh4.fsf@posteo.net> References: <838rlh77cy.fsf@gnu.org> <87mt9wjdxa.fsf@gnus.org> <87wn903w8e.fsf@posteo.net> <83v8ok3ve7.fsf@gnu.org> <87k0503twn.fsf@posteo.net> <83r0z83sga.fsf@gnu.org> <87tu433n27.fsf@posteo.net> <83h70350i7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15218"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58543@debbugs.gnu.org, larsi@gnus.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 17 00:40:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1okCIq-0003rD-2Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Oct 2022 00:40:16 +0200 Original-Received: from localhost ([::1]:55100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okCIo-0006Pp-Rr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Oct 2022 18:40:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okCId-0006Pf-3e for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 18:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47317) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okCIc-0003IS-Ib for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 18:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okCIc-0000Rz-4Y for bug-gnu-emacs@gnu.org; Sun, 16 Oct 2022 18:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Oct 2022 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58543 X-GNU-PR-Package: emacs Original-Received: via spool by 58543-submit@debbugs.gnu.org id=B58543.16659599851703 (code B ref 58543); Sun, 16 Oct 2022 22:40:02 +0000 Original-Received: (at 58543) by debbugs.gnu.org; 16 Oct 2022 22:39:45 +0000 Original-Received: from localhost ([127.0.0.1]:46395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okCIK-0000RP-Ou for submit@debbugs.gnu.org; Sun, 16 Oct 2022 18:39:45 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okCII-0000RA-W0 for 58543@debbugs.gnu.org; Sun, 16 Oct 2022 18:39:43 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 05D77240103 for <58543@debbugs.gnu.org>; Mon, 17 Oct 2022 00:39:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665959977; bh=+9IXu8GgZ1mlIbohsRlxe01+JO5HcLoLfl/f4ySFl0g=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=JmKXs9Z1v4wAcI8LiHiP1/prFPEpIUpC1Qs6OTJHb6TvVL1hITcrMnHfiLscm8lMi lXg81OsVyJ8o49nXWo9gTIhPAEiuYQOspOYO8hj2XxIQBb9qBksWB6rPbkGj+2BazG 7JA+QLy5LiOFuh6ez1BVgh0uUDjlTtiioJBuU+MeL7SVuLwPvkhdzL/IM/RiOZHyG1 X/j99v8G9PtTRyLLKUqZKq7POCugmzhl9CzYkcI6oS619FFIN4Ln+V3Vw00e5z5pvL P/V/gRZIuiobOzRItN8DQV3A6FwkcnqVKphPiQC9ljBz/NVOfMfE299QNldnghy+IV ME3Pm5ZAUeiHw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MrFRq5BQsz6tnG; Mon, 17 Oct 2022 00:39:35 +0200 (CEST) In-Reply-To: <83h70350i7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 16 Oct 2022 17:03:28 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245677 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 58543@debbugs.gnu.org, stefankangas@gmail.com >> Date: Sun, 16 Oct 2022 13:39:12 +0000 >> >> Eli Zaretskii writes: >> >> >> > How about mentioning it in the "C-h" prompt itself? >> >> >> >> Do you mean the "C-h (Type ? for further options)-" prompt? >> > >> > Yes. Make it say >> > >> > C-h (Type ? for further options, q for quick help)- >> > >> > or somesuch. >> >> That sounds good. How about this patch: > > LGTM, but please wait for others to comment. After all, I'm not the > main audience for this stuff ;-) Will do. Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> LGTM, but please wait for others to comment. > > Makes sense to me. > >> After all, I'm not the main audience for this stuff ;-) > > Me neither. Looks like nobody will be using the feature :') Stefan Kangas writes: > Philip Kaludercic writes: > >> diff --git a/src/keyboard.c b/src/keyboard.c >> index 8ab4a451b4..8386b599c3 100644 >> --- a/src/keyboard.c >> +++ b/src/keyboard.c >> @@ -503,7 +503,7 @@ echo_add_key (Lisp_Object c) >> if ((NILP (echo_string) || SCHARS (echo_string) == 0) >> && help_char_p (c)) >> { >> - AUTO_STRING (str, " (Type ? for further options)"); >> + AUTO_STRING (str, " (Type ? for further options, q for quick help)"); >> AUTO_LIST2 (props, Qface, Qhelp_key_binding); >> Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str); > > Also add the text property to the "q" here. Something like: > > Fadd_text_properties (make_fixnum (30), make_fixnum (31), props, > str); You're right, I've added it and it does the right thing: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-src-keyboard.c-echo_add_key-Mention-quick-help.patch >From c25e78d8020364e1ecae795ffb79b1612bdc0d0b Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Mon, 17 Oct 2022 00:36:06 +0200 Subject: [PATCH] * src/keyboard.c (echo_add_key): Mention quick-help --- src/keyboard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/keyboard.c b/src/keyboard.c index 8ab4a451b4..224512bfc9 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -503,9 +503,11 @@ echo_add_key (Lisp_Object c) if ((NILP (echo_string) || SCHARS (echo_string) == 0) && help_char_p (c)) { - AUTO_STRING (str, " (Type ? for further options)"); + AUTO_STRING (str, " (Type ? for further options, q for quick help)"); AUTO_LIST2 (props, Qface, Qhelp_key_binding); Fadd_text_properties (make_fixnum (7), make_fixnum (8), props, str); + Fadd_text_properties (make_fixnum (30), make_fixnum (31), props, +str); new_string = concat2 (new_string, str); } -- 2.37.3 --=-=-=--