From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59415: 29.0.50; [feature/tree-sitter] c-ts-mode fails to fontify a portion of a large C file Date: Sun, 20 Nov 2022 21:17:20 +0100 Message-ID: <87y1s5qt2n.fsf@thornhill.no> References: <83v8n94ij9.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26850"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu To: eliz@gnu.org, 59415@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 20 21:18:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owqlg-0006lY-7g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Nov 2022 21:18:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owqlQ-0006zS-LY; Sun, 20 Nov 2022 15:18:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owqlO-0006w9-7O for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 15:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owqlN-0006Wj-QX for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 15:18:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owqlN-0000mT-Ks for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 15:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Nov 2022 20:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59415 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Eli Zaretskii , bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16689754572968 (code B ref -1); Sun, 20 Nov 2022 20:18:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Nov 2022 20:17:37 +0000 Original-Received: from localhost ([127.0.0.1]:44733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owqky-0000lo-PM for submit@debbugs.gnu.org; Sun, 20 Nov 2022 15:17:37 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owqkx-0000lg-ET for submit@debbugs.gnu.org; Sun, 20 Nov 2022 15:17:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owqkx-0006qh-A1 for bug-gnu-emacs@gnu.org; Sun, 20 Nov 2022 15:17:35 -0500 Original-Received: from out2.migadu.com ([2001:41d0:2:aacc::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owqku-0006V4-Qb; Sun, 20 Nov 2022 15:17:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1668975448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QUYvKiQogoi24tqcQRxXO2euezYRAEXotaYPgURnXKo=; b=Bkg2qCOXrY8bRTEM/Q6dCpCs78hzo7neimk9ueaSiSx5CmJyDWpbgEWBdZrqILOdfpjbjS WP1wmOtqfvKfKInLu+buG0apvjOwwY92YdH+b15E+Sgm/Gv9FL7sWJrazsXGwbYHWfRlKh 6oORIYVhsHztomQilXdFYHE7uIOEFihHbFNxhbJx6BfzVOahYKrsbrlGFmAJWguU1MiALN 3hs88/5vhpF3QIk2hW1MmShpPiUjLLJAiLqv3tgLqEPFfc9DRFFcfp8Y0BU/sU5992XCVj 8ivyQNMKGw2yUzivXYUAj/Z5kDf5SW8WYTiflIKeRoOaejaRdWr2rPu9g1y9cw== In-Reply-To: <83v8n94ij9.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=theo@thornhill.no; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248472 Archived-At: > > P.S. Btw, isn't the treesit-max-buffer-size limit too low? 4 MiB? I thought it was supposed to be 4 gigs, as seen in this function: ``` static void treesit_check_buffer_size (struct buffer *buffer) { ptrdiff_t buffer_size = (BUF_Z (buffer) - BUF_BEG (buffer)); if (buffer_size > UINT32_MAX) xsignal2 (Qtreesit_buffer_too_large, build_pure_c_string ("Buffer size cannot be larger than 4GB"), make_fixnum (buffer_size)); } ``` So my guess is that that is a typo, and should be (defcustom treesit-max-buffer-size (* 4 1024 1024 1024) "Maximum buffer size for enabling tree-sitter parsing (in bytes)." :type 'integer :version "29.1") or something like that :-) Theo