From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58919: 28.2; dired-copy-file-recursive fails to overwrite directory Date: Sat, 17 Dec 2022 10:52:25 +0100 Message-ID: <87y1r69x2e.fsf@gmx.de> References: <87y1sws6eq.fsf@posteo.net> <83wn8gdu4k.fsf@gnu.org> <31dc6bb7-ada3-aeac-c65b-d7de4a326026@cs.ucla.edu> <87k04ebhvn.fsf@gmx.de> <83zgbutdz5.fsf@gnu.org> <83h6xuihgc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26873"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: thievol@posteo.net, 58919@debbugs.gnu.org, Paul Eggert To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 10:53:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6Tsf-0006n0-Ue for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 10:53:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6TsS-0000lM-7F; Sat, 17 Dec 2022 04:53:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6TsN-0000fu-43 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 04:53:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6TsM-00057w-JZ for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 04:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6TsM-0005le-69 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 04:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 09:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58919 X-GNU-PR-Package: emacs Original-Received: via spool by 58919-submit@debbugs.gnu.org id=B58919.167127077122158 (code B ref 58919); Sat, 17 Dec 2022 09:53:02 +0000 Original-Received: (at 58919) by debbugs.gnu.org; 17 Dec 2022 09:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:54922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Ts9-0005lK-Mr for submit@debbugs.gnu.org; Sat, 17 Dec 2022 04:52:51 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:54795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Ts4-0005lC-30 for 58919@debbugs.gnu.org; Sat, 17 Dec 2022 04:52:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1671270747; bh=veZ0QS3IM3xKSIPCC8vZKQFhtg1KbUP3NTG8u5y6bJI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=UH/cpEPEg09o5ZgHXTOFia4bFY5uNOYDNj2bcfp85YVtw+ZEcM4a9GOpOrIsyd9mZ +7oiWQbmt2VUbIwSBO7rgh7tEu9CSgIVaSPMIosqLMZLyBhuBgs4J4xBkdHcg4WMap oUOjhXw/4kcBj5aN5W+pa9pEzt1QvByw/ePy2iFB0vWwRpoDYmtMg2fsHDDydmTWtg TTRBWCbgu7dn58z+tHS9ECK92w6mWCQFV8I0TVDwxQp6jWVBzRZR4pdZi4K32tqYNa 587t/VUpIkvbOH6+YYync9DI5+c1HqQjHNYPNKncQHK5GaLR3j+KHSOovG6lmRTuIY qCcRkDX5CXr7A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.11]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MlNtF-1ocPuo13F7-00lmqQ; Sat, 17 Dec 2022 10:52:27 +0100 In-Reply-To: <83h6xuihgc.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Dec 2022 10:04:51 +0200") X-Provags-ID: V03:K1:2cpVfF3PPU5gvgc/l/c+HlHMVNtQMHo3Vd2ZnYbg4gF/M1sgFkJ N0QmglCEQwOQyMl/VyXBLimgGmpe4ekXMRL9rmhmXBA2xJcBEZ9DZX7yWsikeUWQvezsXyF IeIwVXEkLlBLiZZ0hZMN0JLy+Qp66CPfXAHubQlJKXjFpXu/UJk4UPIZP1Q8fIxZudDfsBL KMy7XjTo8mJYGzC9Dzlmg== UI-OutboundReport: notjunk:1;M01:P0:7uyBxAZHtJY=;twdJJAlrgX4izwc8X3UDCeNUMrG ZqabzfRm/WfBc10ufzWGxC0CZo7H8t2LsEfQhCCL7qu4WdZnQrh6ESaynC/dnGqb80R7YwOQz k9E2vKPxRC7Unx1VybYOCuKYnsH6cWJE4lLUlMHlQZFJdwgqDYO4Z9g/yv3HdwM0WC8UBGQQt BAYvlRU6/y9BSYtgBzhCXPSexqupVNCwbm/QMgi9XSF7FynNxa+zYmdCuuKIVMXq82RLjV2pc Ly+JJ3OBvSPPENwizzCsq+rLCAUtkIbf1s5UYmWSB6QhOw2d78KKmdC5G5UAaJEcD3F289ovH GNfLyKBO1C8IyEIRx8uw4qQH21s79FORDBe4xouGo4/zEn3h5uCCoZquQcfpYNLsyC6NMX10D 0cVY9gtIsm7Rx17JKHnjReBzzmdjWpwKwE8CUHFO0xq8oAfvyFWzeeWlWyRBlvu7bXcWCMhYt kn5bw4jNZhKzp3nFxt0IeLXUBZSaaLiKMrHGyOXQTcqqLU5m2kXVvOH/KhM7esV2v+kAGNCec hy06zRUBI7k/zsYz3CGD2XjRodPzDa/w+w/P1FfuYxfpFT/ekAECqd7C/pq8RAHHPw/yREz5D zvf09YBRMtCtAB6BN6l7CFPUCOeji/FNEL4Jpxfo6fPgZ3mR73u155eRzDJTF+dF5DvZcy3sH 5wOIMW1WgujcTvx7P3VxcVoy/vYBIaKc5jUrxOvULCeB0AiA+biOkdO1HBv+FuLYc9O8/X+6H 97k2IFgodXDvDj4R2Z3LpZ/8Q6Oyxss+9az1Zgebf0jHRNOH0Lcc52GaW0NyI0WymNilmlRr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251266 Archived-At: Eli Zaretskii writes: Hi Eli & Paul, >> These patches address the issues raised by Michael by passing only >> single arguments to make-directory handlers. That way, we don't need to >> worry about whether the handlers follow the new convention. At our >> leisure, perhaps in Emacs 30, we can upgrade the make-directory handler= s >> to support the new convention. > > Michael, are you okay with this? do you see any problems, real or > potential, that could endanger the release of Emacs 29? I've reviewed them, and in general it looks OK. Needs some testing, of course. Since file name handlers still raise an error in case DIR exists and PARENTS is nil, we might see surprises in code assuming the new behavior. I guess I'll add a change in tramp-*-handle-make-directory like =2D-8<---------------cut here---------------start------------->8--- (if (and (null parents) (file-exists-p dir)) (if (>=3D emacs-major-version 29) t (tramp-error v 'file-already-exists dir))) =2D-8<---------------cut here---------------end--------------->8--- And, of course, the return value (nil or t) must be added. But this doesn't break compatibility, because until now no return value is specified. Similar changes to ange-ftp-make-directory. tramp-test13-make-directory of tramp-tests.el must be adapted as well, but this is minor. Will do. These changes must be applied anyway, for Tramp's compatibility over several Emacs versions. In short, I guess we could add the patch to the emacs-29 branch. Best regards, Michael.