unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Evgeni Kolev <evgeni.d.kolev@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 60557@debbugs.gnu.org
Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists
Date: Mon, 16 Jan 2023 11:53:14 +0000	[thread overview]
Message-ID: <87y1q24rx1.fsf@gmail.com> (raw)
In-Reply-To: <CAMCrgaWJYJY7N4C1=3ioZfks8bYJDPJ6FnvPwrk8u8K6vaz=bw@mail.gmail.com> (Evgeni Kolev's message of "Sat, 14 Jan 2023 08:02:59 +0200")

Evgeni Kolev <evgeni.d.kolev@gmail.com> writes:

> Hi João, thank you for the detailed reply.
>
> Regarding 2.2), I don't fully understand it - could you clarify how
> 2.2) is different from the _user's_ perspective?

Hi Evgeni,

Because I think you've found an important flaw in Eglot, and in the
interest of speeding up this discussion I've just pushed a change to
progmodes/eglot.el that effects the alternative 2.2 I describe earlier.

I hope you have a chance to test it.  If you agree with the new
behaviour, this ticket can be closed.

[ Eli, I pushed this change to emacs-29 as this in effect a bugfix and
Eglot is a new package anyway.  Let me know if you'd rather I push this
to master instead (it doesn't make much of a difference in practice
since eglot.el is a GNU ELPA packge) ]

João






  parent reply	other threads:[~2023-01-16 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 15:44 bug#60557: [PATCH] Fix eglot prompt when connection already exists Evgeni Kolev
2023-01-12  9:35 ` Eli Zaretskii
2023-01-12 10:53   ` João Távora
2023-01-14  6:02     ` Evgeni Kolev
2023-01-14 17:22       ` João Távora
2023-01-16 11:53       ` João Távora [this message]
2023-01-16 14:08         ` Eli Zaretskii
2023-01-16 14:15         ` Eli Zaretskii
2023-01-16 14:42           ` João Távora
2023-01-16 14:54             ` Eli Zaretskii
2023-01-18  5:58               ` Evgeni Kolev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1q24rx1.fsf@gmail.com \
    --to=joaotavora@gmail.com \
    --cc=60557@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=evgeni.d.kolev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).