From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Date: Wed, 22 Feb 2023 11:03:03 +0100 Message-ID: <87y1oq3tm0.fsf@web.de> References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14697"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 61460@debbugs.gnu.org To: Ulrich Mueller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 22 11:04:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pUlzD-0003f7-4Z for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Feb 2023 11:04:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUlyl-00008y-Ro; Wed, 22 Feb 2023 05:04:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUlyk-00007T-Cc for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 05:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUlyk-0000N6-27 for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 05:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pUlyj-0000aR-Tq for bug-gnu-emacs@gnu.org; Wed, 22 Feb 2023 05:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Feb 2023 10:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61460 X-GNU-PR-Package: emacs Original-Received: via spool by 61460-submit@debbugs.gnu.org id=B61460.16770602172216 (code B ref 61460); Wed, 22 Feb 2023 10:04:01 +0000 Original-Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 10:03:37 +0000 Original-Received: from localhost ([127.0.0.1]:58058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlyL-0000Zf-4M for submit@debbugs.gnu.org; Wed, 22 Feb 2023 05:03:37 -0500 Original-Received: from mout.web.de ([212.227.17.11]:55697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlyJ-0000ZT-3N for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 05:03:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677060190; i=michael_heerdegen@web.de; bh=ueQ/hUo4WummvLxPvNxHnj875vppsCmAt93Vm8n0J6k=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jpNck1M7l/UozVvbHqp5Y+g3xn65ot9igQzUD0GyxtKDsYn6D+ki5RCemyDz609h7 GfPD7/W8OlSQNdbQV1nwNJEQj8A4Z4Tf46Js4kdxmyaxyywjTSvS1LVyh2XXnsgupT mgGmaJ8Hc/aWlQjWIYdk39fQuejU3eth+SQpfmxMeOKb2zwAtqxPGHPI1/iw4rr+sv U78uuarSjZ0PDJl8UdD8vkBXbbOG782tQ7CRsoND+84OOdHo61YYm6/2x4xJMoNmvW rJONfg3dxtyhjUQ8TiAsTqQ7IGtSyGeXPsBd1DbHobSakVx8bp5fsO7fDTvevIOBBb W0O5ccmAw1aQg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MwR4R-1ocOtP3FAr-00sAt7; Wed, 22 Feb 2023 11:03:10 +0100 In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 10:00:38 +0100") X-Provags-ID: V03:K1:pW8QBrJdyBMRG9jS9hm+DOC6+20QPndeGehfYTQar7+Edwzb3AE dBFeTv7S8+Kw0ioOEe6MDz1w52GqX3NgdS1swponkw9FGXq0V1f90W+trqx5fVuPLSa0WYN nRJDpLnzgkJdkY9W+wDGbPPdsyEwgi8rX9ETz+ejO4uLOQJvIW+qj1kPMFovNpJ1RoHcDDZ XYwgpNM6A0Fy/np1+J++Q== UI-OutboundReport: notjunk:1;M01:P0:ZD6M2qW8Z5A=;BKFxih5xJrBv0gJA8q2bxvWRuhw r9uueCCuOCejUZBTsb0D2nwRfHkVgXte6p5nydMtybbYUtIfT8qS/Wn+qrhoZquZrn5LTe8o8 83tuPwZHDVoqg+KOta/za6zz/1i8fXMlLPgI9oxIFRL8gVl7wZOzus6VOGItUWRPVCpUqM1ZS Xt3BLu29X6ECLkG9MaKTsPyxIFILtYcK+roj1Ht6SQOTs9STSLPza1q71rvl0mNYofWAi54mT k5/gOU/CnSgLFPoQGbmJpwg+YjoAx8Cum4OLW/4UyZ8qCOf4XiTyLiDqDq3+NAlz5Oug48CSD wJ/Zpi2J6fGxjgWByGf1j8r7+1lZcifzlhMhjCmEE0gB6LNNc8sFLFD71x/rtTbTvl8JHWH5n tweMxgLQ7XmzGb3q+PO/8IGFBZwNwJpl/5b/6qI6CJOxMpmwu/up1fAkeFs9qP9ISksOWKWOH 2m7o7TjDmGCYa8ctldPqDNOUzyY40MKfFSOnr85jV2YR3U6jrKhCbR0sY/fz+o8hdtvxZbpJI wZR+FvLafn2EIM9GMyz8EMEBYgTrCcNLupetOWopzYsE5NVttebMTy1+vuC0+JDRebhh0OGQp F+HpBRgPw5ilJUthG0eGPiGZKql3tB4gHR6suKyo6BGw7muWIbe3p6HobDHaI1PoWut2nSxzf ewjSXac2HU1l0X+NWdcTaj6+5jc72CVK3kne8sjiLOsbXer0hnDcDObotkeVxXNBWhgMGSXl+ rnu3eKID57Zw4hLMbQPY98Nrmy9b/gUw6uDIV3CcPN28wrF41fw/RGbXtvfYVYAHjBlqHWpV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256328 Archived-At: Ulrich Mueller writes: > It is probably a matter of personal taste, but I dislike the nested > concats. This seems simpler (not tested, though): > > - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " > - (cadr phase)))))) > + (cons mark > + (let ((eclipse (nth 3 phase))) > + (concat (lunar-phase-name (nth 2 phase)) " " > + (cadr phase) > + (if (string-empty-p eclipse) "" " ") > + eclipse)))))) Fine by me (my preference would be Andreas' suggestion). We also need to fix the space handling in calendar-lunar-phases aka M in calendar - when no eclipse occurs, the descriptions end with a trailing space. Michael.