From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#61726: [PATCH] Eglot: Support positionEncoding capability Date: Thu, 23 Feb 2023 18:01:35 +0100 Message-ID: <87y1oofh8w.fsf@betli.tmit.bme.hu> References: <87a614g628.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4019"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Augusto Stoffel , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: 61726@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 23 18:04:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVF0n-0000o3-BO for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Feb 2023 18:04:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVEzB-00033g-OD; Thu, 23 Feb 2023 12:02:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVEyx-0002rh-Hd for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 12:02:21 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVEyo-0000pB-AV for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 12:02:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVEyo-0002iz-1z for bug-gnu-emacs@gnu.org; Thu, 23 Feb 2023 12:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Feb 2023 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61726-submit@debbugs.gnu.org id=B61726.167717170410444 (code B ref 61726); Thu, 23 Feb 2023 17:02:02 +0000 Original-Received: (at 61726) by debbugs.gnu.org; 23 Feb 2023 17:01:44 +0000 Original-Received: from localhost ([127.0.0.1]:35167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEyW-0002iM-Ca for submit@debbugs.gnu.org; Thu, 23 Feb 2023 12:01:44 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:35663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVEyU-0002i9-Vk for 61726@debbugs.gnu.org; Thu, 23 Feb 2023 12:01:43 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id q16so863319wrw.2 for <61726@debbugs.gnu.org>; Thu, 23 Feb 2023 09:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WoRKa7gZGJNJRRJfLQ8q2TNy7gtCK+uu3rzvgkdCImo=; b=bRhYgVBJxyr9/tSMM5zWyRqAvYyX76nhspL1m3Mi/PgPNyjjhiP+BuWyGLvlQXgdzU 7gQ6hWRgVhgDj6bXov/XAK1Q5cQj/sDN8N84W00VQIUYfsLsR2rcKtt21M4FAY3giy2j ABu0WYpayWTtH54NuN0VnRwm1ymLhb04h93wGAQ0mM2FzrKQM15sil1wfn8A6ruxvzN9 jPLsOHMZo5ps0YDSAovxs6w6Pm5YOisUH5eOA/cJyl7ZO21oxWB0ng/eH6sLAlss4/Eq PqZJsV4IM0seyW2wkziZGBJR6xaXXL8Eu1LMxqJIgYBLhz1PJu0Pccs7OyeH1OzyUE05 YxUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WoRKa7gZGJNJRRJfLQ8q2TNy7gtCK+uu3rzvgkdCImo=; b=AxL2EqAMUKIGs7IEhprYsQEUkhBDic4GN28sLcXOv4TOOu4nTOCAtrYj0WY4/2kir3 WQiGaqh6iBrK0Et9mMbL5oTUjGtXNZ3FZEK2nQ1qjnoQKXZxOiy0SQ2+0269S+6XBgc1 22wrHxGSF+847x3GF4strnT+moTFzAnKr+Q3EPE0dys6Bu1CcAWoeydx9/DG04wMLtrU qYuGqKaEfMWNS5QpW55N/jUKzstS5Dko3I/ELnuKMB+JrG/8GJn/ccRWJoigNNZ3Adlh g0DSA5SUd5WzZEDuxB2iBEf+r1cp0sKPHM5unRtWqo7GnfGewXRy/r/nDzekYuOjHkI/ V8sg== X-Gm-Message-State: AO0yUKXxo4uht7pTT+PO+PPmKNaQeggwhB/a6sgYQWEsYWcwuFxHCRbT MAEVzP/M1QZM4xUlUVeeHt4= X-Google-Smtp-Source: AK7set8r9aIPf8Lo7/SjdhIVMMVQFzwbxEx+McImRaWwAyGjmc3/rC9eb+QfWldrqCkRBTgeCQJ+Vw== X-Received: by 2002:a5d:558d:0:b0:2c7:103f:7122 with SMTP id i13-20020a5d558d000000b002c7103f7122mr2439894wrv.28.1677171696940; Thu, 23 Feb 2023 09:01:36 -0800 (PST) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id s14-20020a5d510e000000b002c569acab1esm11069721wrt.73.2023.02.23.09.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Feb 2023 09:01:36 -0800 (PST) In-Reply-To: <87a614g628.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 23 Feb 2023 09:05:35 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256494 Archived-At: Augusto Stoffel writes: > Tags: patch > > There is a new LSP capability allowing the server and client to agree on > a way to count character offsets. What do you think fo the attached > patch? It closes https://github.com/joaotavora/eglot/pull/916, hooray! I think the patch has a small bug. With it, Eglot always negotiate the encoding with the server, but when the user sets eglot-current-column-function or eglot-move-to-column-function, the result of the negotiation is ignored, which might confuse the server. (In the long run, it might make sense to let the list of the offered encodings configurable.) Thanks.