From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails Date: Mon, 27 Feb 2023 17:20:10 +0100 Message-ID: <87y1oj9j2d.fsf@ledu-giraud.fr> References: <878rgoid4e.fsf@ledu-giraud.fr> <87zg94gmq4.fsf@ledu-giraud.fr> <87a6134d91.fsf@ledu-giraud.fr> <87356rb5yf.fsf@ledu-giraud.fr> <83zg8zgqfi.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61734@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 27 17:21:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWgFb-00015y-Sh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Feb 2023 17:21:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWgFM-0001Bv-Ea; Mon, 27 Feb 2023 11:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWgFK-0001BL-BJ for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 11:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWgFJ-0002Pz-UN for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 11:21:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWgFJ-0004kV-Jm for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 11:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2023 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61734-submit@debbugs.gnu.org id=B61734.167751481618137 (code B ref 61734); Mon, 27 Feb 2023 16:21:01 +0000 Original-Received: (at 61734) by debbugs.gnu.org; 27 Feb 2023 16:20:16 +0000 Original-Received: from localhost ([127.0.0.1]:48649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgEa-0004iT-7c for submit@debbugs.gnu.org; Mon, 27 Feb 2023 11:20:16 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:13903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgEW-0004iI-K3 for 61734@debbugs.gnu.org; Mon, 27 Feb 2023 11:20:14 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=yLqzm2wC wXSwiZtKzAXcmrkezkQY4sLcf8Xxi/6FmeM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=3PmZTWd74MGuWJm0YGcPWdVIbsXCc6 Jz6SuyeME2kLhkJP6xTkEnOuw+CDUnn3uKGlvEH7vmYQ+Eu5J2oPMSBw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=yLqzm2wCwXSwiZtK zAXcmrkezkQY4sLcf8Xxi/6FmeM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=f1m/KvJemyF53cxBaJs1/IeQOgyegOOBzp1N5K lylwUppnVJomJNQ3SlwUL43+oQZbs0YkDzkjLsZchUrQcT3etDyxVRum9JQZo8BbwjWF3N UNgSiWHEVljAwK+bZM7iE+EXzdy6JzY/66rrYJwKVbUY6l7BYhM7He8sKWVhzQ8rPaUYKU Q9MVHZX9imah86kZZjRVP5l8W181nmjeXmSLb7kvg7l+DKA3/+ybIEILxQurmV8X1/tSx6 TQdvAMlU50Qp7OdBt3kUI8kPLzaiKnY09VfGGg/eYzTNDb1l4+TTuPEEg9cjOXvD6F/dSG XD50C1oi9BCb4WYs6/QtktdA== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fcef0c27 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 27 Feb 2023 17:20:10 +0100 (CET) In-Reply-To: <83zg8zgqfi.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Feb 2023 15:59:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256889 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > I only ever keep the last version, and it's certainly not for > emacs-29. Ok, sorry. So here is the first version. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch >>From c88f74aaa381580c183a8692bc467bfef7cd192b Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 23 Feb 2023 16:42:48 +0100 Subject: [PATCH] Defaults to zero for image-dired--number-of-thumbnails * lisp/image/image-dired.el (image-dired--number-of-thumbnails): Defaults to zero to avoid wrong type error down the line. --- lisp/image/image-dired.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 8e2a75a418f..6ecb307ce12 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -546,7 +546,7 @@ image-dired--line-up-with-method (t (image-dired-line-up-dynamic)))) -(defvar-local image-dired--number-of-thumbnails nil) +(defvar-local image-dired--number-of-thumbnails 0) ;;;###autoload (defun image-dired-display-thumbs (&optional arg append do-not-pop) -- 2.39.1 --=-=-= Content-Type: text/plain > What do you want to install on emacs-29, and what problem(s) is that > supposed to fix? This fixes a "wrong type error" when comparing image-dired--number-of-thumbnails to zero. Here is a recipe to make it happen: - Do not have an existing *image-dired* buffer - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file from Dired And you're right that the rest of the patch should not go into emacs-29. -- Manuel Giraud --=-=-=--