From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#61954: 30.0.50; [PATCH] Simplify structured commands in Eshell Date: Sun, 05 Mar 2023 18:15:54 -0700 Message-ID: <87y1oar86t.fsf@melete.silentflame.com> References: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61954@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 06 02:17:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYzTh-0005sC-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Mar 2023 02:17:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYzTM-0001sT-HK; Sun, 05 Mar 2023 20:17:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYzTL-0001s6-9v for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 20:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYzTK-0005N6-Uy for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 20:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYzTK-00012T-D1 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 20:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2023 01:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61954-submit@debbugs.gnu.org id=B61954.16780653713924 (code B ref 61954); Mon, 06 Mar 2023 01:17:02 +0000 Original-Received: (at 61954) by debbugs.gnu.org; 6 Mar 2023 01:16:11 +0000 Original-Received: from localhost ([127.0.0.1]:40979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYzSS-000118-18 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 20:16:11 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYzSM-00010E-8Q for 61954@debbugs.gnu.org; Sun, 05 Mar 2023 20:16:06 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 422255C009F; Sun, 5 Mar 2023 20:15:56 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 05 Mar 2023 20:15:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1678065356; x= 1678151756; bh=j8m0bQzwMyVd8AAIW/zZoc/gPNrNxArAv3VZDNT4ZwU=; b=I eMnuHe2dfFUG7SK6re7K3lbqB5spAoTCn6322CFz5gwk+R4An7V1Vzx2VWxIY9/A qgKIIncSezV0bEHD2fpfLps31mtUzAdjMnOTQeRfXswZ8SigYJSKVYumX/XQZOnT 2fK4BjBoEBu0ku2vl9Rnwybk5S/ecP2QcDygZ1cYSqn12eYYddEQpqQqVXgxfrCs TpWOrOJz9HR7SiQ1YmjBVMKhax8958Y918k3AdqWyfqDQHXjpaDbrj+eUFa7UHw4 SFpdtttCeklbxg4sHypSaA4cQEEeHSYAGW7drNkdzcm23Hnw1Yz4Hr+OfIMfD0kN Y03d7czmeC+UaZp6bqmFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678065356; x=1678151756; bh=j8m0bQzwMyVd8 AAIW/zZoc/gPNrNxArAv3VZDNT4ZwU=; b=bGpLjXJPMYT6dd7jC0UJYNVCmwqzP rf/kw81sfILxAHsqc5lFn+AJ/siPSOEJZkUddfp+2DMSmEy4iHdocC2nzV23C+Rl oFMkJmupcFEW+WLOGthamth3cMkCJ+JVwnV7sI/d/I1UZd2l8ZAvRffUtPcqp2Zu 4YLe2SewHCgjRLLXgvd/FnaaKHzVOWEkYwYmBkCGGNZlpnxPFdnPARe5fDE/bsjN mlmkqfSawq0dEX6GxuuDM2EkygRExT3f34Z4baYKxbQkvgEkQoBM8wNyzrokgK9X av1EpP842iXc15gg9dtOuaVbioD3N1vjuYmeroZeNEXqRQjzrvBbK6Ypw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddthedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtsehttd dttddtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhn sehsphifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnheptdffvdffueelue dvteekvdevhefghedvgeevgffhvedukeeggeelveegjeekteeknecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfi hhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Mar 2023 20:15:55 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 797CF7E7D3B; Sun, 5 Mar 2023 18:15:54 -0700 (MST) In-Reply-To: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com> (Jim Porter's message of "Fri, 3 Mar 2023 23:28:46 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257365 Archived-At: Hello, On Fri 03 Mar 2023 at 11:28PM -08, Jim Porter wrote: > Structured commands are just Eshell flow control commands, like 'if' and > 'while'. These expected you to set 'eshell-test-body' and > 'eshell-command-body' when implementing them, and were very hard to get right > (see bug#12571 for example). > > Instead, let's improve Eshell's iterative command evaluation some more so that > you can write the implementations for these commands like normal. I think this > is beneficial for two main reasons: a) it should get us closer to replacing > Eshell's iterative evaluation with the CPS machinery in generator.el > (bug#37635)[1], and b) third-parties should have an easier time writing their > own fancy Eshell commands using the command-rewriting hooks. I think you have typo'd the bug number? I would like to read about what the advantages of moving to CPS in particular will be. My understanding was that CPS is only rarely a good idea. -- Sean Whitton