From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Fri, 12 May 2023 06:56:36 +0000 Message-ID: <87y1luvxzv.fsf@posteo.net> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> <83zg6gc5yp.fsf@gnu.org> <87sfc8gd9s.fsf@posteo.net> <87fs877tgz.fsf@breatheoutbreathe.in> <875y936iec.fsf@posteo.net> <87y1lyhbfy.fsf@breatheoutbreathe.in> <83sfc6azol.fsf@gnu.org> <87bkitgj3c.fsf@breatheoutbreathe.in> <87lehwfzli.fsf@posteo.net> <87a5ybsjum.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org, Eli Zaretskii To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 08:57:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxMiN-0005VA-Oz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 08:57:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxMi8-0005Tz-4q; Fri, 12 May 2023 02:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxMi6-0005Tf-Ib for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxMi6-0000GR-Ah for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxMi6-0007tR-7B for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 02:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 06:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.168387460430317 (code B ref 63337); Fri, 12 May 2023 06:57:02 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 12 May 2023 06:56:44 +0000 Original-Received: from localhost ([127.0.0.1]:53880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMho-0007sv-CC for submit@debbugs.gnu.org; Fri, 12 May 2023 02:56:44 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxMhm-0007sd-PT for 63337@debbugs.gnu.org; Fri, 12 May 2023 02:56:43 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3134B2402AD for <63337@debbugs.gnu.org>; Fri, 12 May 2023 08:56:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683874597; bh=450ht7fyzT6mZjftd9lBem8spJSrE+9w8wAASaiqOCU=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=NQsMbRYHEnrfvhOaUhxvihE7b+2oQPuOS3PBwZxhpFSyj+SgiOVLx9obkrVOZYH8r N5xoZPyYPlWRFZ7xdxvuE9uQESRXmWmR7au6aKRpV4KFq0HB2BCdvOxnfr890xbNEA yBFVw/KRBxq93ZzTcAlTLCX5SZ9aoaQhBdJArW0SLUw7WjTQfKW/tfNnOIl4bzwaMf XhZpjlM0lmBIGHZHhTJ3UHE4fy01XdzZmY6r3RMPNH2ArIOWBIdxgyJCEwPuVBn2Yx 4SURGckJ28/BJzYOLTnkv4ZaX9ysxIqkOHvVVXjR03o087Lt43r+UP4SyXNOCtfs1b Gxrenyw+1jhOA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QHfgm5JG4z6tsj; Fri, 12 May 2023 08:56:36 +0200 (CEST) In-Reply-To: <87a5ybsjum.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Wed, 10 May 2023 19:04:02 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261607 Archived-At: --=-=-= Content-Type: text/plain Joseph Turner writes: > Philip Kaludercic writes: > >> Ok, do you have a few example repositories that we can use to test edge-cases? > > I first noticed this issue when attempting to build the docs for > org-transclusion. Besides that, we could select a few package specs > containing :make at random from > https://git.savannah.gnu.org/cgit/emacs/elpa.git/tree/elpa-packages ? Oh, and a big problem is that the "dir" file is written into the wrong directory. It has to be located in the root directory of the package, not in docs/ (in the case of org-transclusion). Sadly adjusting the second argument doesn't fix the issue: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index e9794eac783..9876705e57f 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -369,7 +369,8 @@ package-vc--build-documentation (message "Failed to build manual %s, see buffer %S" file (buffer-name))) ((/= 0 (call-process "install-info" nil t nil - output (expand-file-name "dir"))) + output + (expand-file-name "dir" (package-desc-dir pkg-desc)))) (message "Failed to install manual %s, see buffer %S" output (buffer-name))) ((kill-buffer)))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable While the entry does appear in (dir) Top, the file cannot be opened: Info-find-file: Info file =E2=80=98org-transclusion=E2=80=99 does not exi= st; consider installing it > Joseph --=-=-=--