From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64425: [PATCH] Mention minibuffer-next-completion in completion-help Date: Sun, 02 Jul 2023 16:31:21 +0000 (UTC) Message-ID: <87y1jygtra.fsf@catern.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31395"; mail-complaints-to="usenet@ciao.gmane.io" To: 64425@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 02 18:32:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qFzzj-0007uV-7I for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jul 2023 18:32:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFzzY-00079G-NY; Sun, 02 Jul 2023 12:32:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFzzW-000797-H3 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFzzW-0006CG-84 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFzzV-0008Ts-Ll for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 16:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64425 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168831549432562 (code B ref -1); Sun, 02 Jul 2023 16:32:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jul 2023 16:31:34 +0000 Original-Received: from localhost ([127.0.0.1]:60958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzz2-0008T6-GP for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:31:34 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzyx-0008Sw-Lj for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:31:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFzyx-000768-DK for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:31:27 -0400 Original-Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFzyu-00068s-HX for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:mime-version:to:content-type:cc:content-type:from: subject:to; s=s1; bh=SP7JrDrDjCElCKpXYqwAod+Siz76o2uizo0YLI49qW4=; b=nAGGGWGUZXASotmAF4UzH3dzBiLJoFGbx+SFaKuBIIvlrbykuLUaM5mOJm1EN+c1LGHC XfYCpJuVfId3bcvAOr6XyJ5mr9vRXm5meyXx7ZnskpusjbsP2moMG15JrpubZPFdZGfQd9 H+MKhbqjLMIB37ShKMNPB7pYCbDyKp+lNy0Lpo+y7kA2UKztnT45aMigXYdoswwdrJqlj3 rmp8g0n62yNHELJxPBVX9pRl/9r6etVRxt04HSapc+mhxeLJntsmVJV53fYQV/Wqe8WJYp zGX+6XyBLqrCfEYYQgbMej1zucGq5CiZDdA+wy0Ey5v8w85jO8G/bilKp0XpMoIg== Original-Received: by filterdrecv-66949dbc98-mtdwq with SMTP id filterdrecv-66949dbc98-mtdwq-1-64A1A659-27 2023-07-02 16:31:21.800080721 +0000 UTC m=+654981.049870638 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-7 (SG) with ESMTP id z7Mh3b3GQney9YBZMBhc0Q for ; Sun, 02 Jul 2023 16:31:21.692 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 2CCB560087 for ; Sun, 2 Jul 2023 12:31:21 -0400 (EDT) X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbJi8jNmQ0tOrF3+AHjvcW7RSZsWxldU99ngPH94VGl5OuW098K0Th1gr17O9wUBzC3Wm/mdGjVUUR2pv3dSkyQW3ydJxypqQEtZhaUvtJ16wQtRVrzgeHjShl3Clbikevx7XPbF0/PSH3OURYafhW3y/b1Sh/7cqeKdRd9bFt1EIQ== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Received-SPF: pass client-ip=149.72.154.232; envelope-from=bounces+21787432-3678-bug-gnu-emacs=gnu.org@em8926.catern.com; helo=s.wrqvwxzv.outbound-mail.sendgrid.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_BTC_ID=0.259, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264492 Archived-At: --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Tags: patch Now that it's not necessary to switch to the *Completions* buffer to switch between and choose completions, we should make that clear in the help text. Let's also make the bindings uniform both in and outside the *Completions* buffer so users don't have to think about the difference. In working with new users, they've assumed that since the help text in *Completions* says "Click on a completion to select it", that that's the only way to select a completion. This text should help clarify that. * lisp/simple.el (completion-list-mode-map): Bind minibuffer-{next,previous,choose}-completion. (completion-setup-function): Mention bindings for minibuffer-{next,previous,choose}-completion. In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: NixOS 22.11 (Raccoon) Configured using: 'configure --with-x-toolkit=3Dlucid --with-tree-sitter CC=3Dgcc PKG_CONFIG=3Dpkg-config PKG_CONFIG_PATH=3D/nix/store/va9r2bdg56jc6qizpm6dyb97lnxfrhsy-file-5.44/li= b/pkgconfig:/nix/store/2jinas874l3zqnprvniqjk8yb1mmikz3-ncurses-6.4-dev/lib= /pkgconfig:/nix/store/0z5wasald7dmipjpbx8kw31pj0kzjxpg-libxml2-2.10.3-dev/l= ib/pkgconfig:/nix/store/qgqsyg7gmqy3fz6shvzhcc7m7pkfw2ig-zlib-1.2.13-dev/li= b/pkgconfig:/nix/store/998srgfg7b1i0yfbpqcykmy8znadjq04-gnutls-3.8.0-dev/li= b/pkgconfig:/nix/store/d5sfvi0cvg8zkvg4qahxlj1822i47knj-nettle-3.8.1-dev/li= b/pkgconfig:/nix/store/8s5by4sa822nnqfnxj41clqhn39ys2av-gmp-with-cxx-6.2.1-= dev/lib/pkgconfig:/nix/store/22hqhw3rkv97mamdy4s4d754bnavpw3r-jansson-2.14/= lib/pkgconfig:/nix/store/vddrjv0wnknv73njnwzj3in0467dk9qa-harfbuzz-7.0.0-de= v/lib/pkgconfig:/nix/store/vgasd5zjsvdvq3w7ik13sfyyj1n0m5v7-graphite2-1.3.1= 4/lib/pkgconfig:/nix/store/l8d014vy8n42sp6r6j3wjqldylcyvqyk-dbus-1.14.4-dev= /lib/pkgconfig:/nix/store/gqvyvc9ckzijwcw641v6qgg7fz8z63mc-expat-2.5.0-dev/= lib/pkgconfig:/nix/store/dvgpj4kwxp5pxhax93zqv80b4ql8xwla-libselinux-3.3-de= v/lib/pkgconfig:/nix/store/2gm71c7yljswz2yz3i6125nx2rwkg9n6-systemd-252.5-d= ev/lib/pkgconfig:/nix/store/2gm71c7yljswz2yz3i6125nx2rwkg9n6-systemd-252.5-= dev/share/pkgconfig:/nix/store/1p3dv53skl06k4fin8dsravd96ayljia-libXaw-1.0.= 14-dev/lib/pkgconfig:/nix/store/vrx9hvcqqp8iyfx2dr1p1ih202myi4z7-libXmu-1.1= .3-dev/lib/pkgconfig:/nix/store/q2sjb83p9kh7j653237wr5xzsdc17sgj-libX11-1.8= .4-dev/lib/pkgconfig:/nix/store/9d1fbfvijywjsxh5b060qy5dd01cqbrs-xorgproto-= 2021.5/share/pkgconfig:/nix/store/rr353rjxy36vvakib4cyajjj2r3gqw5x-libxcb-1= .14-dev/lib/pkgconfig:/nix/store/ij7494rz9pphaslcs288mkyrvj6k7vl4-libXt-1.2= .1-dev/lib/pkgconfig:/nix/store/sp4f99w0gwv5mgfr1gr9j75z83v2fp4x-libSM-1.2.= 3-dev/lib/pkgconfig:/nix/store/23wcgigbj2kjxq214agc4hhgs7x9f4w0-libICE-1.0.= 10-dev/lib/pkgconfig:/nix/store/pzlc01k3n6512frzjcsrrs31dzrx6fhc-Xaw3d-1.6.= 3/lib/pkgconfig:/nix/store/p9q8bgh0qav78niqxjbrnzg8x8cwnmbn-cairo-1.16.0-de= v/lib/pkgconfig:/nix/store/6bdds6632r9fp7mrh27qxjv90d7lzh0y-fontconfig-2.14= .0-dev/lib/pkgconfig:/nix/store/ybd7brnb5kavanvz40mg2p5pmgnczi85-freetype-2= .12.1-dev/lib/pkgconfig:/nix/store/abs0rlwm6jh4l1k831fvqggpgfrs91pv-bzip2-1= .0.8-dev/lib/pkgconfig:/nix/store/84r63sb6w4l1y1ab3vmk3xg84is027y2-brotli-1= .0.9-dev/lib/pkgconfig:/nix/store/463cn57ci7xxwr28c1d68zwbr001ka8h-libpng-a= png-1.6.39-dev/lib/pkgconfig:/nix/store/hncbn4imig9h0nacd2j40by7br4d64c3-pi= xman-0.42.2/lib/pkgconfig:/nix/store/f5blw2z7jr4h2qkzfdmjkwak142353rq-libXe= xt-1.3.4-dev/lib/pkgconfig:/nix/store/jhxfmh0lh0dkk11fpys8350w8hk7ljf7-libX= au-1.0.9-dev/lib/pkgconfig:/nix/store/slpgdz4ha0w6y2c25n0ljda4536p9yi4-libX= render-0.9.10-dev/lib/pkgconfig:/nix/store/9qzw3zscs3b4gc97bsaq991iifgz4977= -xcb-util-0.4.0-dev/lib/pkgconfig:/nix/store/152gsygyjagsirvdg3icmz4px39wdd= wj-glib-2.74.5-dev/lib/pkgconfig:/nix/store/4j08mgygxhi9y3957hbwqn1bg02va18= y-libffi-3.4.4-dev/lib/pkgconfig:/nix/store/fqwihpqn2wmhjqw251w1r7dyw659abr= h-libGL-1.6.0-dev/lib/pkgconfig:/nix/store/y7fpp50b5l7l4g5hk76w2mm2p8jhrwyg= -libglvnd-1.6.0-dev/lib/pkgconfig:/nix/store/vwhy21hpsp8b4har28fv9sl4wf1xxx= f2-libXpm-3.5.15-dev/lib/pkgconfig:/nix/store/dra1y7qr8clxdssfx5s1grbg2lvg5= ifd-libjpeg-turbo-2.1.4-dev/lib/pkgconfig:/nix/store/mgv2qfkir2w084vwlk5ss6= pq2x6gh7n3-libtiff-4.5.0-dev/lib/pkgconfig:/nix/store/zfrjyd3s96gzdvnmdw9i3= n7mqqcipx3l-xz-5.4.1-dev/lib/pkgconfig:/nix/store/nkk74d97ywap31s3gcnw2a20r= 23mxyb3-librsvg-2.55.1-dev/lib/pkgconfig:/nix/store/k6ksm1l6b217wcjjx0klkji= bc4jns7nh-gdk-pixbuf-2.42.10-dev/lib/pkgconfig:/nix/store/nhz6cbjxjdnbvv06j= pmds8vv30fzlhk2-m17n-lib-1.8.0/lib/pkgconfig:/nix/store/3kfnq6nrh0kbcjv4yy2= v2srcl2r9f8hj-libotf-0.9.16-dev/lib/pkgconfig:/nix/store/i1h2yf133m4rfzgfgl= 0zdxjxniyy6kvg-sqlite-3.40.1-dev/lib/pkgconfig:/nix/store/ckvyb7jxzmnvp1pjh= m7y871zxwv4m9xq-libwebp-1.3.0/lib/pkgconfig:/nix/store/8mdyxvz3r70b99bpc8z8= b81j7lspl8nf-tree-sitter-0.20.7/lib/pkgconfig CXX=3Dg++ TREE_SITTER_LIBS=3D-ltree-sitter' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Mention-minibuffer-next-completion-in-completion-hel.patch >From c361966508e2da159b5e65c37dff7f78e87b3445 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 2 Jul 2023 12:30:00 -0400 Subject: [PATCH] Mention minibuffer-next-completion in completion-help Now that it's not necessary to switch to the *Completions* buffer to switch between and choose completions, we should make that clear in the help text. Let's also make the bindings uniform both in and outside the *Completions* buffer so users don't have to think about the difference. In working with new users, they've assumed that since the help text in *Completions* says "Click on a completion to select it", that that's the only way to select a completion. This text should help clarify that. * lisp/simple.el (completion-list-mode-map): Bind minibuffer-{next,previous,choose}-completion. (completion-setup-function): Mention bindings for minibuffer-{next,previous,choose}-completion. --- lisp/simple.el | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/simple.el b/lisp/simple.el index 406f1008df3..59e1311eb2b 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -9697,6 +9697,9 @@ completion-list-mode-map (define-key map [right] 'next-completion) (define-key map [?\t] 'next-completion) (define-key map [backtab] 'previous-completion) + (define-key map (kbd "M-") 'minibuffer-previous-completion) + (define-key map (kbd "M-") 'minibuffer-next-completion) + (define-key map (kbd "M-RET") 'minibuffer-choose-completion) (define-key map "z" 'kill-current-buffer) (define-key map "n" 'next-completion) (define-key map "p" 'previous-completion) @@ -10093,8 +10096,8 @@ completion-setup-function (goto-char (point-min)) (if (display-mouse-p) (insert "Click on a completion to select it.\n")) - (insert (substitute-command-keys - "In this buffer, type \\[choose-completion] to \ + (insert (substitute-command-keys + "Type \\[minibuffer-next-completion] and \\[minibuffer-previous-completion] to change completion, and \\[minibuffer-choose-completion] to \ select the completion near point.\n\n")))))) (add-hook 'completion-setup-hook #'completion-setup-function) -- 2.40.1 --=-=-=--