From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: sbaugh@catern.com
Cc: Spencer Baugh <sbaugh@janestreet.com>, 64423@debbugs.gnu.org
Subject: bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections
Date: Tue, 04 Jul 2023 11:58:10 +0800 [thread overview]
Message-ID: <87y1jwqqel.fsf@yahoo.com> (raw)
In-Reply-To: <87pm58phyu.fsf@catern.com> (sbaugh@catern.com's message of "Tue, 04 Jul 2023 01:45:46 +0000 (UTC)")
sbaugh@catern.com writes:
> Po Lu <luangruo@yahoo.com> writes:
>
>> Spencer Baugh <sbaugh@janestreet.com> writes:
>>
>>> When you do that, you interrupt the operation which is trying to add a
>>> new kill. If you interrupt it and try again, you'll just get the same
>>> long delay again. There's no way to mitigate this from within Emacs,
>>> other than by turning off save-interprogram-paste-before-kill.
>>
>> Then I guess the solution is to temporarily disable
>> `save-interprogram-paste-before-kill' if a quit arrives while it is
>> reading selection data.
>
> That would be a decent solution. Although I'm not sure how we'd
> implement it. We want to, somehow, know that after a selection-transfer
> has been aborted, we should not try to transfer that selection again.
> Is that something we can check? Whether the selection has changed,
> without transferring it?
Emacs will probably assert ownership of the selection after the kill
takes place, anyway, so there is no need.
> That is unfortunate. That seems like a terrible omission... An
> important network protocol principle is "tell the client up front how
> much data you are going to send"...
It's an intentional omission: INCR data transfer is designed to work
even if the owner itself does not know much data will be sent. For
example, if the selection data is being transferred from a pipe or
socket.
> Anyway, there's still a possible solution: we could return control to
> the user if the transfer is too large, and continue with the INCR
> transfer in the background, just to satisfy this ICCCM requirement,
> discarding the data as we receive it. This would be straightforward in
> a program with a normal event loop, but might be difficult in Emacs...
It's straightforward in Emacs, since that's already how it responds to
selection requests from other clients. But it's a bad idea: what if the
user requests another conversion from the same selection owner while the
transfer is in progress? This is technically possible, but will need
Emacs to specify a different property in each ConvertSelection request,
which will lead to lots of needless InternAtom requests and round
trips...
> If the round-trip latency is 500ms, then waiting for the first quantum
> of selection data will take at least 500ms, yes. Subsequent quanta will
> also take at least 500ms each. If the selection is large, there may be
> many. If there are 20, then kill-new will take 10 seconds. But if we
> can limit the amount of selection data transferred, kill-new will only
> take 500ms.
>
> Wait... am I missing something? You're saying it's okay for the user to
> interactively choose to interrupt an INCR transfer, even though that
> will leave things in a bad state?
Yes, because when the user choses to do so, it is already clear that
there is a problem with the selection owner. Transferring a lot of data
is not a capital offense, and Emacs shouldn't condemn the selection
owner just because it does.
> Couldn't we just do the same thing in code, then? Can we wrap a
> user-customizable with-timeout around gui-get-selection?
>
> I actually agree now: limiting the amount of data transferred makes no
> sense for user experience. But limiting the *time spent* transferring
> data makes total sense! Users are able to do that today: We should
> allow users to automate that!
>
> So I think some new save-interprogram-paste-before-kill-timeout variable
> would work perfectly. All it would do is something users are already
> capable of doing, but without aborting the entire kill-new operation.
> That seems perfect!
You mean, x-selection-timeout?
next prev parent reply other threads:[~2023-07-04 3:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 14:13 bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections sbaugh
2023-07-03 2:35 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-03 12:46 ` Spencer Baugh
2023-07-04 0:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 1:45 ` sbaugh
2023-07-04 3:58 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-07-04 11:46 ` sbaugh
2023-07-04 13:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 14:46 ` sbaugh
2023-07-04 16:18 ` Eli Zaretskii
2023-07-04 16:32 ` Ihor Radchenko
2023-07-04 16:41 ` Eli Zaretskii
2023-07-04 16:48 ` sbaugh
2023-07-04 17:02 ` Eli Zaretskii
2023-07-04 17:14 ` Ihor Radchenko
2023-07-04 17:30 ` Eli Zaretskii
2023-07-04 17:35 ` Ihor Radchenko
2023-07-05 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-05 2:29 ` Eli Zaretskii
2023-07-05 3:51 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-05 11:27 ` Eli Zaretskii
2023-07-05 0:19 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-05 13:59 ` Spencer Baugh
2023-07-06 0:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-06 0:50 ` Spencer Baugh
2023-07-06 1:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-08 16:39 ` sbaugh
2023-07-08 16:48 ` Eli Zaretskii
2023-07-08 17:07 ` Spencer Baugh
2023-07-08 17:49 ` Eli Zaretskii
2023-07-09 0:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 6:10 ` Eli Zaretskii
2023-07-09 6:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-09 6:46 ` Eli Zaretskii
2023-07-12 19:18 ` sbaugh
2023-07-13 0:32 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-13 4:48 ` Eli Zaretskii
2023-07-13 16:17 ` sbaugh
2023-07-13 18:39 ` Eli Zaretskii
2023-07-13 22:39 ` sbaugh
2023-07-15 8:31 ` Eli Zaretskii
2023-07-15 8:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-15 9:01 ` Eli Zaretskii
2023-07-15 9:35 ` Eli Zaretskii
2023-07-15 17:38 ` sbaugh
2023-07-15 19:12 ` Eli Zaretskii
2023-07-15 21:00 ` Spencer Baugh
2023-07-17 16:43 ` Mattias Engdegård
2023-08-03 15:53 ` Spencer Baugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1jwqqel.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=64423@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).