From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 65243@debbugs.gnu.org
Cc: philipk@posteo.net
Subject: bug#65243: [PATCH] Fix building of VC package manuals with relative org links/includes
Date: Sat, 12 Aug 2023 01:43:35 -0700 [thread overview]
Message-ID: <87y1ig3atl.fsf@breatheoutbreathe.in> (raw)
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
Hello,
This patch allows for relative includes and link in org files compiled
to texinfo.
Unfortunately, I missed this back in May
(commit 1e6a7594 ), when we fixed relative texi @include links.
I'm not sure how the Emacs release cycle works. Would it be possible to
include this fix in 29.2?
Best,
Joseph
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-building-of-VC-package-manuals-with-relative-org.patch --]
[-- Type: text/x-diff, Size: 1170 bytes --]
From e951b0ea4ffa90202ecee934eddd895b706c6794 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Sat, 12 Aug 2023 01:40:07 -0700
Subject: [PATCH] Fix building of VC package manuals with relative org
links/includes
* lisp/emacs-lisp/package-vc.el (package-vc--build-documentation):
Ensure that default-default is the docs-directory around
org-export-to-file to ensure that links to relative files work correctly.
---
lisp/emacs-lisp/package-vc.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index b4c911015b5..ffc7afeb2ee 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -356,7 +356,8 @@ otherwise it's assumed to be an Info file."
(with-temp-buffer
(insert-file-contents file)
(setq file (make-temp-file "ox-texinfo-"))
- (org-export-to-file 'texinfo file)
+ (let ((default-directory docs-directory))
+ (org-export-to-file 'texinfo file))
(setq clean-up t)))
(with-current-buffer (get-buffer-create " *package-vc doc*")
(erase-buffer)
--
2.41.0
next reply other threads:[~2023-08-12 8:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 8:43 Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-08-14 8:14 ` bug#65243: [PATCH] Fix building of VC package manuals with relative org links/includes Philip Kaludercic
2023-08-14 12:11 ` Eli Zaretskii
2023-08-15 1:57 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-19 9:46 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1ig3atl.fsf@breatheoutbreathe.in \
--to=bug-gnu-emacs@gnu.org \
--cc=65243@debbugs.gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).