From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrey Listopadov Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Fri, 17 Nov 2023 22:50:58 +0300 Message-ID: <87y1ewgnn7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.11; emacs 30.0.50 To: 67246@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 17 20:57:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r44xl-0006VQ-W4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 17 Nov 2023 20:57:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r44xa-0001AU-VD; Fri, 17 Nov 2023 14:57:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r44xa-0001AM-0C for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 14:57:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r44xZ-0004Xc-Ko for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 14:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r44xZ-0003Fo-P4 for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 14:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrey Listopadov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Nov 2023 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 67246 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170025097312438 (code B ref -1); Fri, 17 Nov 2023 19:57:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Nov 2023 19:56:13 +0000 Original-Received: from localhost ([127.0.0.1]:47180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r44wm-0003EX-Gk for submit@debbugs.gnu.org; Fri, 17 Nov 2023 14:56:13 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:34626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r44wj-0003EH-9x for submit@debbugs.gnu.org; Fri, 17 Nov 2023 14:56:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r44wd-000115-7o for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 14:56:03 -0500 Original-Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r44wa-0004Rd-Un for bug-gnu-emacs@gnu.org; Fri, 17 Nov 2023 14:56:02 -0500 Original-Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c5056059e0so33311521fa.3 for ; Fri, 17 Nov 2023 11:56:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700250959; x=1700855759; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=l7zqwFLp5CSz0ssZEkwK4m/b6nDdyZe5D+66jsVoILo=; b=kAfN8p/7k//Pd9EXEj6/ctFOofYJi58p8+20y0gFK+1lSLGDEfi6ruxiH5V1iT9tIY wWjOz+QCc7r6B3n/hn3y56RhdJl6zJF6kz8Qd8l6a88xrVh0LKjlXfqFA+6xNGyS0pew LoKJwAUuCqSwpcWmvjiOGVh6ZVqJ8evNXiBJpaaAuKpSu3rx9hmkRMx+N6n6ttqScH4E 4NH/6Z/XimwrMg+iDbqhzG5EU4lDOeJR0ZXR4eCdjsRvMJcMjEWb+D2XvK89QnAwjPFq nlGxXn27cU2aHZW+Gu/YYdck96RjKgVgUzqvJl8ATdy4dl/aulYFBUFb9PzylKDIZGGm craA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700250959; x=1700855759; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l7zqwFLp5CSz0ssZEkwK4m/b6nDdyZe5D+66jsVoILo=; b=Ak6xZ7+pvNVsRX6bbrCVPTtVLoKmW3BA3QeZLvqIWQDaMTjGk3s73AGogeuimPODod +EaBAwvZZzJhb9KKr8bofPHJp3MJIm0gqXg432Q+ct7Rqu8LKkts0OFMOLvoR0zyvlPB FgNpW3MwoyZuNvoIc70R3XQO56JcC8cZkV+zOLbiyh4Lr9llEGiXJa1VSZWOhGBr660u wMnbrkIHtUMERAMVJpPKmFduCnJhdTsAfX9laVeV7eP+i8cVDRwOb59Si6Y4vW3bSInJ Gv3EFKD0+FSTrIkktMedTJswUMu+ZRX16otxH2hHK31KpOkVTNPM5QBHApM4/9Xw97xF ihQQ== X-Gm-Message-State: AOJu0YzNcNBNTQZVHQPq4CsI4AFK6znX9k5D6NAlxprjzPxIY7d9eyk0 BRncar0VwPQhPB1vlrdNjCajQMa7SPW3tA== X-Google-Smtp-Source: AGHT+IGGFHGjTsQ2Aub17BD7XOaoSEIxyEF8njUA+RzVNRyHQv2l41zyedXNkTQYxqntxwVZ7oY6BA== X-Received: by 2002:a2e:a0d2:0:b0:2c5:a21:8388 with SMTP id f18-20020a2ea0d2000000b002c50a218388mr458197ljm.29.1700250958700; Fri, 17 Nov 2023 11:55:58 -0800 (PST) Original-Received: from toolbox.smtp.gmail.com (broadband-90-154-71-4.ip.moscow.rt.ru. [90.154.71.4]) by smtp.gmail.com with ESMTPSA id r7-20020a170906280700b009cc1e8ed7c5sm1102670ejc.133.2023.11.17.11.55.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 11:55:58 -0800 (PST) Received-SPF: pass client-ip=2a00:1450:4864:20::231; envelope-from=andreyorst@gmail.com; helo=mail-lj1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274514 Archived-At: I've upgraded from elixir-mode to elixir-ts-mode and noticed that the latter uses faces rather inconsistently. For example, the =font-lock-keyword-face= is used for both keywords and method calls, as well as for parentheses. The =font-lock-function-name-face= is used both for function definitions, parameter names, and calls. Some calls use the =font-lock-keyword-face=, for example the call to `raise'. The =font-lock-type-face= is used both for types and =:symbols=. All of that basically makes Elixir code mostly use 2 colors. Additionally, it makes impossible selectively disabling highlighting, as disabling the function call highlighting will disable the function definition highlighitng an so on. I believe, Emacs 29 introduced a lot of faces for all kinds of situations possible in Tree-sitter generated AST, so perhaps the fix is to use them more semantically, rather than for good looks. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-11-08 built on toolbox Repository revision: bf9cbc2354124a1e9eb3327007468ba384ba2945 Repository branch: master System Description: Fedora Linux 38 (Container Image) Configured using: 'configure --without-compress-install --with-native-compilation=aot --with-pgtk --with-mailutils --with-xwidgets --prefix=/var/home/alist/.local' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER XIM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: mu4e:main Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t mu4e-search-minor-mode: t mu4e-update-minor-mode: t mu4e-context-minor-mode: t electric-pair-mode: t savehist-mode: t delete-selection-mode: t pixel-scroll-precision-mode: t global-auto-revert-mode: t repeat-mode: t vertico-mode: t marginalia-mode: t corfu-popupinfo-mode: t global-corfu-mode: t global-region-bindings-mode: t recentf-mode: t gcmh-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t overwrite-mode: overwrite-mode-binary Load-path shadows: /var/home/alist/.config/emacs/elpa/transient-20231103.2312/transient hides /var/home/alist/.local/share/emacs/30.0.50/lisp/transient /var/home/alist/.config/emacs/elpa/modus-themes-20231031.716/theme-loaddefs hides /var/home/alist/.local/share/emacs/30.0.50/lisp/theme-loaddefs Features: (shadow face-remap emacsbug mu4e mu4e-org ob-fennel fennel-proto-repl fennel-mode inf-lisp xref magit-bookmark magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section cursor-sensor crm project ob-lua ob-shell shell org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs find-func mu4e-main mu4e-view gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win gnus nnheader range cal-menu calendar cal-loaddefs mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message shr pixel-fill kinsoku url-file svg dom flow-fill hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config bookmark ido message sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader vertico-directory mule-util highlight-defined advice noutline outline elec-pair isayt disp-table hideshow hl-todo savehist delsel pixel-scroll cua-base autorevert filenotify repeat vertico marginalia corfu-popupinfo cape corfu compat region-bindings recentf tree-widget gcmh init proxy gsettings s gvariant parsec dash zig-compilation-mode fennel-compilation-mode clojure-compilation-mode derived compile text-property-search server ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util sql-indent sql view thingatpt comint ansi-osc ring zig-mode reformatter ansi-color ol org-fold org-fold-core org-compat org-version org-macs format-spec blog use-package-delight formfeed modus-vivendi-theme modus-themes dbus xml common-lisp-modes novice cus-edit pp cus-load wid-edit font mode-line messages defaults edmacro kmacro functions use-package-bind-key bind-key local-config delight comp comp-cstr warnings icons rx use-package-ensure cl-extra help-mode use-package-core early-init finder-inf blog-autoloads cape-autoloads clj-decompiler-autoloads clj-refactor-autoloads cider-autoloads clojure-mode-autoloads common-lisp-modes-autoloads consult-autoloads corfu-terminal-autoloads corfu-autoloads csv-mode-autoloads delight-autoloads dumb-jump-autoloads eat-autoloads elfeed-autoloads expand-region-autoloads fennel-mode-autoloads gcmh-autoloads geiser-guile-autoloads geiser-autoloads gnugo-autoloads ascii-art-to-unicode-autoloads gsettings-autoloads gvariant-autoloads highlight-defined-autoloads hl-todo-autoloads inflections-autoloads isayt-autoloads jdecomp-autoloads lsp-java-autoloads lsp-metals-autoloads dap-mode-autoloads lsp-docker-autoloads bui-autoloads lsp-treemacs-autoloads lsp-mode-autoloads f-autoloads lua-mode-autoloads marginalia-autoloads markdown-mode-autoloads message-view-patch-autoloads magit-autoloads pcase magit-section-autoloads git-commit-autoloads modus-themes-autoloads mu4e-alert-autoloads alert-autoloads log4e-autoloads gntp-autoloads multiple-cursors-autoloads orderless-autoloads org-modern-autoloads org-tree-slide-autoloads ox-hugo-autoloads package-lint-flymake-autoloads package-lint-autoloads paredit-autoloads parsec-autoloads parseedn-autoloads parseclj-autoloads phi-search-autoloads popon-autoloads popup-autoloads puni-autoloads easy-mmode racket-mode-autoloads region-bindings-autoloads request-autoloads scala-mode-autoloads separedit-autoloads edit-indirect-autoloads sesman-autoloads sly-autoloads spinner-autoloads sql-indent-autoloads tomelr-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads hydra-autoloads lv-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads dash-autoloads vertico-autoloads vundo-autoloads with-editor-autoloads info compat-autoloads xpm-autoloads queue-autoloads yaml-autoloads yaml-mode-autoloads yasnippet-autoloads zig-mode-autoloads reformatter-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads xwidget-internal dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 672577 585595) (symbols 48 39874 485) (strings 32 183934 60222) (string-bytes 1 5724204) (vectors 16 69084) (vector-slots 8 1236810 764574) (floats 8 489 1785) (intervals 56 649 178) (buffers 992 11)) -- Andrey Listopadov