From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Thu, 14 Dec 2023 19:02:13 +0000 Message-ID: <87y1dwobey.fsf@localhost> References: <878r919qfh.fsf@localhost> <87y1dzvvf0.fsf@localhost> <83plzas3pg.fsf@gnu.org> <87r0jqw8u9.fsf@localhost> <83jzpis08a.fsf@gnu.org> <87il52w744.fsf@localhost> <83fs06rz10.fsf@gnu.org> <87fs06w4ui.fsf@localhost> <83bkaurut9.fsf@gnu.org> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29054"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, Eli Zaretskii , mattias.engdegard@gmail.com, 66117@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 14 20:00:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDqwU-0007K0-9w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Dec 2023 20:00:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDqwI-0002rO-B7; Thu, 14 Dec 2023 14:00:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDqwG-0002rB-Iw for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:00:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDqwG-0002ZJ-23 for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:00:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDqwE-0003Pw-PB for bug-gnu-emacs@gnu.org; Thu, 14 Dec 2023 14:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Dec 2023 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170258035913037 (code B ref 66117); Thu, 14 Dec 2023 19:00:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 14 Dec 2023 18:59:19 +0000 Original-Received: from localhost ([127.0.0.1]:50933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqvX-0003OD-5U for submit@debbugs.gnu.org; Thu, 14 Dec 2023 13:59:19 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:48005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDqvV-0003Nw-Rt for 66117@debbugs.gnu.org; Thu, 14 Dec 2023 13:59:18 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 96B1B24002A for <66117@debbugs.gnu.org>; Thu, 14 Dec 2023 19:59:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702580352; bh=FPNjHC7w8Edpp2cEEsZftfjZ/4+1o/7wpoI7nKZe/Ng=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=F+Y0/IuawhL3EnS2iS7Q1Dbz0Np/OoLQL3y1EV3Ux5pOb0QMODG7QfSlrfvtI6KEM t3C6dpBa8BXR3y/lxCL9v8311fakFrdXE486YvSSWpDZK3aKDDS3QG3mWyQ2opHiEc VDa8V9VOGvP1BAPJrEgcOUSMUIReJSbQF7dG3EXDA5gn4Wo91WmkjsjYkbFTuzGhko 33XSm3hUV0VqK1sXrIzn1KUs+yJCRhqg3e58T5bHn7+G1Yq+Blqh1wImO30xozhjnQ ekqY7sGFlX2EECby1KHBSCHcy+osf3ZhQEZYyEcbeb1StfPzX/Mx1xzP0CsIWnKew1 aGOYvQFbfLVMg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SrhTq0PPyz6txS; Thu, 14 Dec 2023 19:59:10 +0100 (CET) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276209 Archived-At: Stefan Monnier writes: >>>> It won't be buffer-local-if-changed, so binding it will not be costly. >>> As mentioned elsewhere in this bug-report we can make `case-fold-search` >>> into a `DEFVAR_LISP`: it would have no visible impact to ELisp and would >>> avoid the costly let-bindings. >> Wouldn't DEFVAR_LISP break major modes that do (setq case-fold-search ...)? > > No, it makes no difference to Lisp. It only changes the implementation > strategy: DEFVAR_LISP stores the value in a global C variable (which > thus requires more processing when the var is buffer-local, more > specifically updating the C var when we `set-buffer`), whereas > DEFVAR_PER_BUFFER stores the value inside the buffer object (which > thus requires more processing when the var is *not* buffer-local since > the global value is duplicated in all the buffers where it's not made > buffer-local). Do I understand correctly that what is needed to implement your suggestion is 1. Remove case_fold_search_ slot from buffer objects 2. Use DEFVAR_LISP for case-fold-search 3. Declare case-fold-search buffer-local 4. Replace BVAR(...) references in C with Vcase_fold_search ? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at