From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Fri, 08 Mar 2024 16:44:03 +0100 Message-ID: <87y1asybi4.fsf@epfl.ch> References: <6BAFD8BF-8F18-4D9F-9DB3-A185AEF2EBCA@gmail.com> <8B4172D0-FC31-4437-99C4-683C892C5F86@gmail.com> <3A206D3C-E193-4240-A6DB-D3EC7DAAE7C2@gmail.com> <16E39FDF-5F8E-4C1B-8BCD-A0147B97F2B8@gmail.com> <7150E568-B07D-4D92-8073-979387553394@gmail.com> <87bk80ve20.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: kobarity , Eli Zaretskii , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 68559@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 08 16:44:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ricP4-00024o-Bu for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Mar 2024 16:44:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ricOo-0006fi-Rj; Fri, 08 Mar 2024 10:44:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ricOc-0006YK-Ce for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 10:44:30 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ricOc-00032t-4Z for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 10:44:30 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ricP7-0003Mr-Tv for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 10:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2024 15:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.170991268912905 (code B ref 68559); Fri, 08 Mar 2024 15:45:01 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 8 Mar 2024 15:44:49 +0000 Original-Received: from localhost ([127.0.0.1]:59323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ricOu-0003M5-SC for submit@debbugs.gnu.org; Fri, 08 Mar 2024 10:44:49 -0500 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:39936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ricOq-0003Ln-B9 for 68559@debbugs.gnu.org; Fri, 08 Mar 2024 10:44:46 -0500 Original-Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4131658e439so305015e9.0 for <68559@debbugs.gnu.org>; Fri, 08 Mar 2024 07:44:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709912646; x=1710517446; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WAF/Ekwk/Vx2p1anXWHU2gtGWRzSsc8wDVrcYbIW50w=; b=cXAVcWLc0D3mCE42GT1Vgh8R4BKWsr3awElyjui3gSgdQFs+KV7QbecjJ5ssbkQZrf 45A86ZA1pADJ6nVioAXzv2P1vFqkG0SWh+fb+v0BUIAQMbY0SMeMBnsz/SR8pYewqsXM k8atBKIh8INKO5tCx5ATaBDzuOH8WRrZK0a+pekg/T1qazr5Rdtax8pRSdnien1QRTdH UcOFQOfojnoel7z//UKneYIEWoJQUPB3w/daIekRuKWLXoCWCYpAUaXJkVABxnEL6MAm cgsLC1X8ttTKE7A3yC8G95vSIJOzLcSttyuo3js3S0gJWA4fCVnwwFAgoFcLVrqer7ui n9lQ== X-Forwarded-Encrypted: i=1; AJvYcCUy0Pt57Ck/g9E7mKx3SoVq+RvBCmh5PYHdd5X+Xjn8BW0PP+HWPCzvtpGEvbqk6bvRMHjVo5afcE3jvlP4sG7itIaODZA= X-Gm-Message-State: AOJu0YzY5Xdzt3RskORGKNy0XxOocI+fN5eRdymeWooXz5SYyyTGxro3 A+NLQWrz2MiQEGBmM8yxAzsSs8UmrjlxVfkr5MjkAv5aVn3wQ896 X-Google-Smtp-Source: AGHT+IHh+Df2JfTGNsRh+Rphzb4RA0+hCWH9zA4BJHP/rX73Zl8oRMlYgBYSWOwcHvNsVNsSTUHbOQ== X-Received: by 2002:a05:600c:4f8e:b0:413:1bb8:b384 with SMTP id n14-20020a05600c4f8e00b004131bb8b384mr954371wmq.3.1709912646071; Fri, 08 Mar 2024 07:44:06 -0800 (PST) Original-Received: from localhost (vpn-254-211.epfl.ch. [128.179.254.211]) by smtp.gmail.com with ESMTPSA id q8-20020a05600c46c800b00413099fc248sm6339588wmo.3.2024.03.08.07.44.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Mar 2024 07:44:05 -0800 (PST) In-Reply-To: (Liu Hui's message of "Wed, 6 Mar 2024 18:14:00 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281237 Archived-At: Liu Hui [2024-03-06 18:14 +0800] wrote: > I have updated the patch. Thanks! The build and tests succeed here, without skipped tests. > + (unless (string-match-p "No readline support" output) Nit: why not plain 'string-search' instead of a regexp search? > - (string-match-p "ipython[23]?\\'" python-shell-interpreter))))) > + (or (string-match-p "ipython[23]?\\'" python-shell-interpreter) > + (string= python-shell-readline-completer-delims "")))))) Just curious: what does the empty string signify? [ If it's not just a dumb question, perhaps the meaning could be added to the variable's docstring/commentary. ] -- Basil