From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rahguzar@zohomail.eu, 69555-done@debbugs.gnu.org
Subject: bug#69555: 30.0.50; shr - Preserve indentation when shr-fill-text is nil
Date: Fri, 15 Mar 2024 08:10:09 +0100 [thread overview]
Message-ID: <87y1akj7hq.fsf@gmail.com> (raw)
In-Reply-To: <86v85pbe00.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Mar 2024 07:04:31 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Cc: 69555@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
>> Date: Wed, 13 Mar 2024 22:41:32 +0100
>>
>> Eli, am I clear to push & close?
>
> Yes, but please fix the following nits before installing:
>
> . use only ASCII characters in the commit log message
(ACK; FWIW I did check the repo log for a precedent when adding those
ellipses. Wondering if build-aux/git-hooks/commit-msg ought to report
this? It does seem to explicitly check for non-UTF-8)
> . make sure lines in the commit log message do not exceed 65 columns
(ACK; can't remember where I got my 70-odd filling came from, CONTRIBUTE
does explicitly mention "63". Maybe I got confused with the concurrent
discussion on emacs-devel)
> Thanks.
Nits picked, patch pushed, closing. Thank you both for the review!
next prev parent reply other threads:[~2024-03-15 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 22:02 bug#69555: 30.0.50; shr - Preserve indentation when shr-fill-text is nil Kévin Le Gouguec
2024-03-04 22:08 ` Kévin Le Gouguec
2024-03-05 12:09 ` Eli Zaretskii
2024-03-05 19:22 ` Kévin Le Gouguec
2024-03-05 19:47 ` Eli Zaretskii
2024-03-05 23:16 ` Kévin Le Gouguec
2024-03-06 11:53 ` Eli Zaretskii
2024-03-06 21:18 ` Kévin Le Gouguec
2024-03-07 6:39 ` Eli Zaretskii
2024-03-06 7:27 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-13 19:55 ` Kévin Le Gouguec
2024-03-13 20:28 ` Rahguzar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-13 21:41 ` Kévin Le Gouguec
2024-03-14 5:04 ` Eli Zaretskii
2024-03-15 7:10 ` Kévin Le Gouguec [this message]
2024-03-15 8:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1akj7hq.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=69555-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rahguzar@zohomail.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).