From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#67032: 30.0.50; ERC 5.6-git: Treat erc-send-message more responsibly Date: Thu, 28 Mar 2024 10:34:50 -0700 Message-ID: <87y1a28dl1.fsf__15643.675245677$1711647339$gmane$org@neverwas.me> References: <87v8aa9wd0.fsf@neverwas.me> <87h6lt850d.fsf@neverwas.me> <87fs19za5d.fsf@neverwas.me> <878r2l5zql.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33370"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 67032@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 28 18:35:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rptez-0008R5-K9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Mar 2024 18:35:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rpteb-0006qK-LK; Thu, 28 Mar 2024 13:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpteZ-0006py-Po for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2024 13:35:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rpteX-0005FB-P0 for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2024 13:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rpteY-0000fd-I9 for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2024 13:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Mar 2024 17:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67032-submit@debbugs.gnu.org id=B67032.17116473012567 (code B ref 67032); Thu, 28 Mar 2024 17:35:02 +0000 Original-Received: (at 67032) by debbugs.gnu.org; 28 Mar 2024 17:35:01 +0000 Original-Received: from localhost ([127.0.0.1]:41080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpteW-0000fK-Ky for submit@debbugs.gnu.org; Thu, 28 Mar 2024 13:35:00 -0400 Original-Received: from mail-108-mta172.mxroute.com ([136.175.108.172]:41179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpteU-0000fC-QZ for 67032@debbugs.gnu.org; Thu, 28 Mar 2024 13:34:59 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta172.mxroute.com (ZoneMTA) with ESMTPSA id 18e862100580003bea.001 for <67032@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 28 Mar 2024 17:34:53 +0000 X-Zone-Loop: affd0a205a03a9896becd328d18a15b42effc2881cc4 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2h4fcWW3w16B2ni89jjsYS1zrj8ZTjLHOuD0HRlgM3w=; b=fuFo335ZQxPoS52IjMPitKoRSt FqFCd8UuD3wBFH1bOi3X/9IDLIBwa+qHCZFshPQiVkTK7wFuv6heALUtihgr7/mV+0m6EeX/vJdUb C7YS7uo8RVOnPwMKeS/190d9UMoOakDup9cOREJewXgsxyDm4uF6LsPS/72iNDxByBbpRcUk0sGHJ CQEhGaW4zL6mgeRJrCqSY2d2dAXnga9e0BgQDGQjSPZcF9YAEFdzy59wmsAB/tpftCJMdFlA89lI0 Wp1DKFzMQBo2kwMGyTFLB/Id1OAiZqy79qFzYvtE6p9IKZzcBEj0zOAS71BGiTFyPQV1U6X/THreV mklhaIAA==; In-Reply-To: <878r2l5zql.fsf@neverwas.me> (J. P.'s message of "Wed, 13 Mar 2024 19:11:30 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282246 Archived-At: "J.P." writes: > One aspect this change should've addressed but didn't was using the > revived `command-indicator' facility in `erc-load-irc-script-lines' to > make its output more predictable and consistent with other displayed > messages. While leaving it to rot would of course be safer, I suspect > it's rarely used enough to warrant the risk. An ancillary benefit of > fixing this is that it helps clarify the role of boolean return values > for `erc-process-input-line', `erc-send-input-line-function', > `erc-message', and the various `erc-cmd-FOO' slash-command handlers. > See second patch (lacks tests). This has been installed as a46789b56af * Reuse command-indicator code for script lines in ERC This bug is already closed.