bug#71337: 30.0.50; `electric-pair-mode' and custom keybinding

[Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>]

On Tue, 4 Jun 2024 08:37:48 +0100 João Távora <joaotavora@gmail.com> wrote:

> On Tue, Jun 4, 2024 at 8:30 AM Stephen Berman <stephen.berman@gmx.net> wrote:
>>
>> On Tue, 04 Jun 2024 07:53:16 +0200 Arash Esbati <arash@gnu.org> wrote:
>>
>> > Stephen Berman <stephen.berman@gmx.net> writes:
>> >
>> >> If the pairing in electric-pair-mode should only be triggered by
>> >> self-inserting characters (as the current code seems to require), then
>> >> the attached patch appears to avoid the above problem.
>> >
>> > Thanks for your response.  Yes, your patch fixes the issue.  Do you want
>> > to install it?
>>
>> I think it would be prudent to wait for someone familiar with the
>> electric-pair-mode implementation (e.g. its author João Távora, Cc'd),
>> or failing that, an Emacs maintainer, to ok the patch.
>
> I will have a look if I can.

Thanks.

>                               It would also be prudent to make sure
> the unit tests all pass, like they presumably do before the patch.

All tests passed with and without the patch in batch runs, but when
running ert manually on test/lisp/electric-tests.el, two tests failed,
but again both with and without the patch:

F electric-pair-autowrapping-7-at-point-1-in-tex-mode
    Electricity test in a ‘tex-mode’ buffer.
    (ert-test-failed
     ((should
       (equal (buffer-substring-no-properties (point-min) (point-max))
	      expected-string))
      :form (equal "foo''" "``foo''") :value nil :explanation
      (arrays-of-different-length 5 7 "foo''" "``foo''" first-mismatch-at 0)))

F electric-pair-autowrapping-7-at-point-2-in-tex-mode-in-strings
    Electricity test in a ‘tex-mode’ buffer.
    (ert-test-failed
     ((should
       (equal (buffer-substring-no-properties (point-min) (point-max))
	      expected-string))
      :form (equal "\"foo''\"" "\"``foo''\"") :value nil :explanation
      (arrays-of-different-length 7 9 "\"foo''\"" "\"``foo''\"" first-mismatch-at
				  1)))

Steve Berman