From: Sean Whitton <spwhitton@spwhitton.name>
To: 73387@debbugs.gnu.org
Cc: juri@linkov.net, monnier@iro.umontreal.ca, dgutov@yandex.ru
Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n
Date: Sun, 22 Sep 2024 13:46:44 +0100 [thread overview]
Message-ID: <87y13jq2iz.fsf@zephyr.silentflame.com> (raw)
In-Reply-To: <87zfo28fzu.fsf@zephyr.silentflame.com> (Sean Whitton's message of "Fri, 20 Sep 2024 17:08:37 +0100")
Hello,
On Fri 20 Sep 2024 at 05:08pm +01, Sean Whitton wrote:
> If you do C-c C-n in a diff-mode buffer with multiple hunks, a
> subsequent C-x v v signals a user-error from diff-file-next. I think
> that the bug is in how diff-vc-deduce-fileset invokes diff-file-next.
> I'm not sure exactly how to rework diff-vc-deduce-fileset.
>
> It would be nice to fix this because then C-c C-n C-x v v would be a
> convenient way to commit just a single hunk.
I applied a brute force fix to diff-vc-deduce-fileset.
Attempting to commit a single hunk still fails because after C-c C-n the
file name header is not present, and 'git apply' can't handle a hunk
without a file name header.
We have diff-find-file-name to get the name; I wonder if we should try
to construct a fake file header?
--
Sean Whitton
next prev parent reply other threads:[~2024-09-22 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 16:08 bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Sean Whitton
2024-09-22 12:46 ` Sean Whitton [this message]
2024-09-23 22:41 ` Dmitry Gutov
2024-09-23 22:41 ` Dmitry Gutov
2024-09-24 6:32 ` Juri Linkov
2024-09-24 15:54 ` Sean Whitton
2024-09-24 17:36 ` Dmitry Gutov
2024-09-25 6:34 ` Sean Whitton
2024-09-25 23:46 ` Dmitry Gutov
2024-09-27 11:55 ` Sean Whitton
2024-09-27 19:13 ` Dmitry Gutov
2024-09-29 23:46 ` Sean Whitton
2024-09-30 0:27 ` Dmitry Gutov
2024-09-30 9:38 ` Sean Whitton
2024-09-30 10:11 ` Dmitry Gutov
2024-09-30 13:10 ` Sean Whitton
2024-09-30 13:25 ` Sean Whitton
2024-09-30 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y13jq2iz.fsf@zephyr.silentflame.com \
--to=spwhitton@spwhitton.name \
--cc=73387@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).