From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#73387: 30.0.90; C-x v v in diff-mode doesn't work after C-c C-n Date: Fri, 27 Sep 2024 12:55:28 +0100 Message-ID: <87y13dfgzz.fsf@melete.silentflame.com> References: <87zfo28fzu.fsf@zephyr.silentflame.com> <8d0b046e-4b29-4551-b421-e98e212a7b40@yandex.ru> <86msjxefkv.fsf@mail.linkov.net> <87cykt2gkl.fsf@zephyr.silentflame.com> <87jzf01bsk.fsf@zephyr.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73387@debbugs.gnu.org, monnier@iro.umontreal.ca, Juri Linkov To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 27 13:56:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1su9ah-0008R2-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Sep 2024 13:56:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1su9aQ-0000mJ-BQ; Fri, 27 Sep 2024 07:56:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su9aN-0000lx-1m for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 07:56:36 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1su9aM-0006z3-I1 for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 07:56:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=H2UP0LxyvKFj6yfOoQd9hf4iYDAjmSFmFOBi/WPcwOU=; b=OqqpAQTEfCVoLbg+DNSMKFDxC43RK+wuOfdPThpIIL1ds1mDKlMY5g48GRrlqkqCglXbgYshVlzRkwC58raw1oHQqnBxJt5N6m2ku4U77u3WHsJ3FFupfPsIfjmcWQ00c99UCxTSZpAo39LWhyUJhmzaN+3bkmC+O4WG6879LBw7BW6WHy98dv2SBeLKPkdkKNq0oAAWNyiE4J3HPIRb6zoa95RnVn9F8G3ZC0V9W512gUfMOpls/iLNRM1b8L+33hJAllpw78VbWY6SdJSVF00rUo3OOfC9Ne0oLOPWm6CHRHzZwtykZlpl37Bb2NdcqBoVSNViCtD+dEL2qswUEw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1su9ao-0004sc-Lg for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Sep 2024 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73387 X-GNU-PR-Package: emacs Original-Received: via spool by 73387-submit@debbugs.gnu.org id=B73387.172743816918652 (code B ref 73387); Fri, 27 Sep 2024 11:57:02 +0000 Original-Received: (at 73387) by debbugs.gnu.org; 27 Sep 2024 11:56:09 +0000 Original-Received: from localhost ([127.0.0.1]:55956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su9Zw-0004qm-OS for submit@debbugs.gnu.org; Fri, 27 Sep 2024 07:56:09 -0400 Original-Received: from sendmail.purelymail.com ([34.202.193.197]:43772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su9Zt-0004q3-Vl for 73387@debbugs.gnu.org; Fri, 27 Sep 2024 07:56:07 -0400 DKIM-Signature: a=rsa-sha256; b=V41rzYny6XnixzzQPAu3q6bJrBqoG6yZPwH5ymwnBrAc5SDHhe9uWzLsCmgzaxdn+1EsAnhg0T0apaBBHwRgWFd1og+w0JwVNQv6s5LeGVVzcw3fCgk7/OEA5wRovrXvUK2NKeXMR9Vk5o62xdWH0pCzx2pZrmNqk4WwNQVLexSnbrg8G3tTckfkm4kNhlu/0k3kwdXk9zX63ZncECCld//pPCJ50DluQuXMXNBcQ8rdXQPJQrcQvM7gVyEtzaNINLb38qIulGWlckNeSj62jUfa+s+TZz+gJkdbAVki3obxT8/4ZzE9zwEk/FosgkV4EMM3rJsgS8NWP3d2g9McwA==; s=purelymail1; d=spwhitton.name; v=1; bh=15BwIodTa/yIS/N/rGIH23M1rhP1YKM/32YqYIpf+tU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=tpIxBErbWHFBV6d7gCNsjzRoViOwQCQ4AfWethxHIhXID4H5UNg5FdpJcTY6NMSn4LXHPqk1ZGm1MZ4jCO337vVWFShhWoebHMRg9toLrd4jvqEpuuKlPjOKBlbXQTctkDs/wOIjCcYMnaOGrhoZ/ZkGM/BGejm6lB6deX95HSwRRpQ9sPJlxqcWINpFfSRpjjf0euXoMxQp1BVa+EYUWshFJeg3r+9A+7F4MjUqHqG8q00Q4ALHwAU8Ryc931gO/SgmpOtxF/gZpIPZ7R5Eut0F1Na2cHFdKhb7jbKI52rZFUJIdGk1f8ZusK7yFaorgI2j1z5GLOAXY57+ufeCJw==; s=purelymail1; d=purelymail.com; v=1; bh=15BwIodTa/yIS/N/rGIH23M1rhP1YKM/32YqYIpf+tU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 73387@debbugs.gnu.org Original-Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1582981533; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 27 Sep 2024 11:55:29 +0000 (UTC) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 100E47E3DFD; Fri, 27 Sep 2024 12:55:28 +0100 (BST) In-Reply-To: (Dmitry Gutov's message of "Thu, 26 Sep 2024 02:46:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292507 Archived-At: Hello, On Thu 26 Sep 2024 at 02:46am +03, Dmitry Gutov wrote: > Suppose C-c C-n (or probably a different but similar binding) edited the diff > instead of applying the narrowing, in a way that retained the file header(s), > but keeping only the hunks intersecting the region or just the current one. > > Would that work for you just as well, or do you prefer to use narrowing > anyway, for some other reasons? It would work for me, and has a few advantages: - it means you just hit 'g' afterwards, not C-x n w and then 'g' - it fits better with our general paradigm of killing what you don't want to include and then committing. On the other hand, it doesn't seem ideal that after C-c C-n you can, for example, use C-c C-a or C-c M-k, but not C-x v v. That could break you out of your mental flow. What do you think about this: - add a command which does the kill-all-but-this-hunk (or hunks in region if mark active) thing -- it's generally useful. - make C-x v v on a narrowed buffer, by default, issue a message saying "Cannot commit patch when narrowed, consider " - add a user option that when non-nil means C-x v v on a narrowed buffer automatically widens, invokes the new command, and then commits. My thinking is that the latter behaviour is complex and so shouldn't be the default, but once you understand what's going on then there is a good chance you want to enable it. -- Sean Whitton