bug#73909: [PATCH 2/2] quail/greek.el: Add greek-polytonic.

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Sun, 20 Oct 2024 22:35:36 +0300, Thanos Apollo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:

Thanks for this. A few minor comments below.

    Thanos> Git patches is not my area of expertise, if I've done anything wrong
    Thanos> feel free to correct me.

The commit message needs to be in ChangeLog format. See 'Generating
ChangeLog entries' in CONTRIBUTE in the Emacs sources for how to have
Emacs help you with that, and 'Commit messages' for other
recommendations. Since this is a new input method, thereʼs no need to
describe every single detail.

    Thanos> +(quail-define-package
    Thanos> + "greek-polytonic" "Greek" "ῶ" t
    Thanos> + "Greek input method, with support for polytonic & archaic Greek letters."
    Thanos> + nil t t t t nil nil nil nil nil t)
    Thanos> +
    Thanos> +(quail-define-rules
    Thanos> + ("1" ?1)
    Thanos> + ("2" ?2)
    Thanos> + ("3" ?3)
    Thanos> + ("4" ?4)
    Thanos> + ("5" ?5)
    Thanos> + ("6" ?6)
    Thanos> + ("7" ?7)
    Thanos> + ("8" ?8)
    Thanos> + ("9" ?9)
    Thanos> + ("0" ?0)
    Thanos> + ("-" ?-)
    Thanos> + ("=" ?=)
    Thanos> + ("[" ?\[)
    Thanos> + ("]" ?\])

Thereʼs no need for entries that map to themselves.

    Thanos> + ;; Changed punction from greek.el
    Thanos> + ("`" ?·)
    Thanos> + ("~" ?:)
    Thanos> + ;; tonoi
    Thanos> + (";" ?΄) ;; U+1FFD (oxia)
    Thanos> + ("q" ?`) ;; U+1FEF (varia)
    Thanos> + ("'" ?῀) ;; U+1FC0 (perispomeni)
    Thanos> + ("\"" ?ι) ;; U+1FBE (ypogegrammeni)
    Thanos> + ;; pneumata
    Thanos> + (":" ?᾿) ;; U+1FBF (psili)
    Thanos> + ("Q" ?῾) ;; U+1FFE (dasia)
    Thanos> + ("W" ?¨) ;; U+00A8 (dialytika)
    Thanos> + ;; apostrophe combinations
    Thanos> + ("; " ["’ "]) ;; U+2019 (apostrophe)

Strictly speaking, thatʼs a RIGHT SINGLE QUOTATION MARK. Apostrophe is
?ʼ U+2BC

    Thanos> + (";g" ["’γ"])
    Thanos> + (";d" ["’δ"])
    Thanos> + (";z" ["’ζ"])
    Thanos> + (";u" ["’θ"])
    Thanos> + (";k" ["’κ"])
    Thanos> + (";l" ["’λ"])
    Thanos> + (";m" ["’μ"])
    Thanos> + (";n" ["’ν"])
    Thanos> + (";j" ["’ξ"])
    Thanos> + (";p" ["’π"])
    Thanos> + (";ρ" ["’r"])
    Thanos> + (";s" ["’σ"])
    Thanos> + (";t" ["’τ"])
    Thanos> + (";f" ["’φ"])
    Thanos> + (";x" ["’χ"])
    Thanos> + (";c" ["’ψ"])
    Thanos> + ;;
    Thanos> + (";G" ["’Γ"])
    Thanos> + (";D" ["’Δ"])
    Thanos> + (";Z" ["’Ζ"])
    Thanos> + (";U" ["’Θ"])
    Thanos> + (";K" ["’Κ"])
    Thanos> + (";L" ["’Λ"])
    Thanos> + (";M" ["’Μ"])
    Thanos> + (";N" ["’Ν"])
    Thanos> + (";J" ["’Ξ"])
    Thanos> + (";P" ["’Π"])
    Thanos> + (";Ρ" ["’R"])
    Thanos> + (";S" ["’Σ"])
    Thanos> + (";T" ["’Τ"])
    Thanos> + (";F" ["’Φ"])
    Thanos> + (";X" ["’Χ"])
    Thanos> + (";C" ["’Ψ"])

This seems like a lot of work just to prepend ’ to the basic
letters. Perhaps just

(";;" ?’)

instead would be more general (and easier to type).

    Thanos> + ("QQ" ["“ ”"])

Iʼd investigate `electric-quote-mode'.

    Thanos> + ("," ?,)
    Thanos> + ("." ?.)
    Thanos> + ("/" ?/)
    Thanos> + ("!" ?!)
    Thanos> + ("@" ?@)
    Thanos> + ("#" ?#)
    Thanos> + ("$" ?$)
    Thanos> + ("%" ?%)
    Thanos> + ("^" ?^)
    Thanos> + ("&" ?&)
    Thanos> + ("*" ?*)
    Thanos> + ("(" ?\()
    Thanos> + (")" ?\))
    Thanos> + ("_" ?_)
    Thanos> + ("+" ?+)
    Thanos> + ("{" ?{)
    Thanos> + ("}" ?})
    Thanos> + (";;" "\"")
    Thanos> + ("<" ?<)
    Thanos> + (">" ?>)

These are all identity mappings again, so unnecessary (except for ";;")

Robert
--