From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74606: 31.0.50; Another rsvg API change Date: Mon, 02 Dec 2024 15:06:28 +0100 Message-ID: <87y10ydvrv.fsf@ledu-giraud.fr> References: <87ttbmi9fa.fsf@olaptop-dell.mail-host-address-is-not-set> <8734j6fbaq.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 74606-done@debbugs.gnu.org To: Osama Rebach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 02 15:07:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI74v-0008Iq-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Dec 2024 15:07:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI74r-0004SO-4m; Mon, 02 Dec 2024 09:07:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI74o-0004RN-Um for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 09:07:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tI74o-0004Wx-L3 for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 09:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ZNRVrbx0QMCkanu/hiGapgYgIDoKzusuJdlZZ3ifWlw=; b=s95kp2mRTMloZISviMuXTH/AayHH4t3FoYoC+QoEs6dsLI3cMHv8hQQtiuD1L8vjUHSg9SBPeKot1Y0RrZfmHjBDZI9g1WBdVnnXZxo4IVHnEAozcEzN0KUjwjZqYMm9U18qeKMdojPIDYoh6n3JEL5I49FJKqGkRfV/l8d94Ce15WVEfbmLb1p39FPqA2LqeGyIax8mFEWVvqKOPTRNm3lDhytXrqVVax6xl4BTnLHkQHZVzXvosL6nq+RG9W5LzC0nQtECTZrpVpdyDepT1pjehGZlQj4v5HupjS7UBXvfIRBRpfxXrYAPCN/NrOV7UifjoQQhm10jNPktYFqB0Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tI74o-00022E-Fb for bug-gnu-emacs@gnu.org; Mon, 02 Dec 2024 09:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2024 14:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74606 X-GNU-PR-Package: emacs Original-Received: via spool by 74606-done@debbugs.gnu.org id=D74606.17331483967769 (code D ref 74606); Mon, 02 Dec 2024 14:07:02 +0000 Original-Received: (at 74606-done) by debbugs.gnu.org; 2 Dec 2024 14:06:36 +0000 Original-Received: from localhost ([127.0.0.1]:54775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI74N-00021D-KF for submit@debbugs.gnu.org; Mon, 02 Dec 2024 09:06:35 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:48997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tI74K-000210-Qw for 74606-done@debbugs.gnu.org; Mon, 02 Dec 2024 09:06:34 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=fuqy13EH h0fjBArHJJO0G7PnTGuT80uGXM9oHoEGKZU=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=mStxHFDjxPjfUzk2+BVxXB10sfzgjs y2BlNY2uB0vREWJm4tuh/1EEGoq/bNmQ+euGPCLo1d2RgEtW1jgxWpAg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=fuqy13EHh0fjBArH JJO0G7PnTGuT80uGXM9oHoEGKZU=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=omBpKGiikIW8SphnRy+tM0X6iBOq/Aj+sOK3MV hCgD91PdJTZCgcyGPeR22WKeSRYpjSOMcBZkJhbBH8rcIP4gWKX7W0s1ALUBmWLFUM6y5K 0Vt438c7qbur6hgKYzf2ED7WEaIaBLUJzqA32cPECpKxDlkbw/CA0CcDF7hH3g9Ybdr6fS KIuJNjhFCaskNdN7G9x26QCqq25n3zu+/jpPnKWWItFJnBWEf0nzNJsuvyYw7/p7QIkupu XqlPE1kpnGgKvxFgCE/k9obPgRUJqyumJy71LE3/khDH3ZHczS7L13PXXILYGXfziJxWjr thU+qtlYlnAOu9b4TJYlsl5A== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 777dea91 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Dec 2024 15:06:29 +0100 (CET) In-Reply-To: <8734j6fbaq.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Mon, 02 Dec 2024 14:45:49 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296323 Archived-At: Manuel Giraud writes: > Osama Rebach writes: > >> rsvg_handle_get_pixbuf_and_error is defined in librsvg 2.59, so the patch >> should guard against 2.59 instead of 2.58 > > Thanks. I have based my patch on this comment: > https://gitlab.gnome.org/GNOME/librsvg/-/blob/main/include/librsvg/rsvg-pixbuf.h?ref_type=heads#L52 > > Now, I'm looking on the librsvg repo for a more valid source of > information. Ok, so if I'm not mistaken the patch that introduces the rsvg_handle_get_pixbuf_and_error API (and deprecated the other) is this one: https://gitlab.gnome.org/GNOME/librsvg/-/commit/85cdba02a3e126c1099a62b3d6421ac0cb2d790b On this page, when you unfold the link "Tags containing commit", you can see that 2.58.90 is the first one. So maybe, I should use this version instead. WDYT? The "Deprecated: 2.58" from the header looks like a copy/paste mistake. -- Manuel Giraud