From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pengji Zhang Newsgroups: gmane.emacs.bugs Subject: bug#74287: [PATCH] Rework history Isearch for Eshell Date: Wed, 11 Dec 2024 08:45:01 +0800 Message-ID: <87y10navzm.fsf@pengjiz.com> References: <871pzjkhmm.fsf@pengjiz.com> <8c80ae91-476e-e665-43be-86d72fb57ed1@gmail.com> <86v7waz603.fsf@gmx.net> <6fdd8386-8915-e3a8-046a-b18750a7057d@gmail.com> <87v7vzgtuq.fsf@mail.linkov.net> <87jzcecnc9.fsf@pengjiz.com> <87h67icmu1.fsf@pengjiz.com> <87cyi159vo.fsf@pengjiz.com> <87msh4n29s.fsf@mail.linkov.net> <8734iwl5kw.fsf@pengjiz.com> <8734iwq8to.fsf@mail.linkov.net> <87frmv245n.fsf@pengjiz.com> <87zfl3mo4z.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33843"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Jim Porter , 74287@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 01:46:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLAs3-0008ec-68 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 01:46:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLArh-00023q-C0; Tue, 10 Dec 2024 19:46:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLAra-00023U-At for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 19:46:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLAra-0000nH-2V for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 19:46:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=0jhtsFs6DihtH8w61rlNmkumuXxzRgYXlntjoU6OHzI=; b=j8WLD8VZm64IPKIAJeNdVnq10Bi5nUG2xa6yv/aW3WxK6SJnU2q5I+pU90SNMCs3n9VulqeyFIG1SwYObmm8ylEtOkd7bRgg7NXe5aexRhcPaNCkrj459zzjisiM5/p1n1Rzg1aVvUBGVK/uUNx3TD08/0/ZpqXGCOwuqkjn6OFnpwvZ33sz4QZkm3KthKIE2zBCkPWLWhos2F8IycuxDc4ROauwl28AX3zkqH6TJwfaUqv8cN6QA3g39vPyVqfgEb4dIKfp5i4mSXHyfdYiIaqiyVqkBma1y1hwyStIYYf6LavNFGlEwNRIr+Kspgg9SRE4DNaHo5KBDVTrSJW4Xg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLArZ-0002CJ-ND for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 19:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pengji Zhang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74287 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74287-submit@debbugs.gnu.org id=B74287.17338779158216 (code B ref 74287); Wed, 11 Dec 2024 00:46:01 +0000 Original-Received: (at 74287) by debbugs.gnu.org; 11 Dec 2024 00:45:15 +0000 Original-Received: from localhost ([127.0.0.1]:60217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLAqp-00028I-3K for submit@debbugs.gnu.org; Tue, 10 Dec 2024 19:45:15 -0500 Original-Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]:55493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLAql-000254-S1 for 74287@debbugs.gnu.org; Tue, 10 Dec 2024 19:45:13 -0500 Original-Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4D42E1140205; Tue, 10 Dec 2024 19:45:06 -0500 (EST) Original-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 10 Dec 2024 19:45:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1733877906; x=1733964306; bh=0jhtsFs6Di htH8w61rlNmkumuXxzRgYXlntjoU6OHzI=; b=SxbArvIeu0RvFgheGI2RrDZvof PPblD11d/QPt+TSfEnrO3+bXlJvEO+ZleL73fR9eHRkdHSbj0w4LEJmS/khgt1XU /dhk7IDGuaMSqNftCtF5xnUFEiwjtv+NzsV8Vygit5rsMdGXvYzjwDBNgLuUngrI 502LilcJUSziIL1F6o/37Z8w8FAYlVHCYxgSgFo5qf+vimwssCA/RiLMIKvCtFdu KUPCxZXPKtM1GJRZpdtpWKnF4z7PwTDXuE0slO/OKYjnTBYaFDxGQZjUX+H989uM QD3CxqfSwC4oY3nKQ7o27NXwRXiHDVx/gAux1bb9yXIaURMrwa0swnI7w4bA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1733877906; x=1733964306; bh=0jhtsFs6DihtH8w61rlNmkumuXxzRgYXlnt joU6OHzI=; b=XkMksV42G353a4pTWIMRaDOovu4Dy3OY/2IzGZ+6H6pXa31Tfg+ bA7unvfCpy5K2kqNpGYl6fHr061fEU5ndUqYdWNPh5XrxScO7zS+Y4fKo4gCKawS MLK2jIq2eCxcKn5ExHdqHzwdfA0G7XQyJz9g+mYMjhm6UkSrqL7oL3i2I9T9AFJx UvPTFIaOQir7DvuGR57pAlDuizwzza2FC30GHixM0G0tDyadzi2ac3f5yH0jf/U9 H+yrjDvbIPnP0It0FaCpqqsPLS4CebVZM2Lb85daGQRFexny0a62bJI0NsD1NJKF 1N7MY8y9gqxbyhb3B8qmpImot2/CSOb4BLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrjeelgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfh rhhomheprfgvnhhgjhhiucgkhhgrnhhguceomhgvsehpvghnghhjihiirdgtohhmqeenuc ggtffrrghtthgvrhhnpeegfeeiiedvudekiedtgedufedtvedtueetieffhfdvhefftefg ieejieelleehgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehmvgesphgvnhhgjhhiiidrtghomhdpnhgspghrtghpthhtohepfedpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepjhhurhhisehlihhnkhhovhdrnhgvthdprhgtph htthhopehjphhorhhtvghrsghughhssehgmhgrihhlrdgtohhmpdhrtghpthhtohepjeeg vdekjeesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i16614472:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Dec 2024 19:45:04 -0500 (EST) In-Reply-To: <87zfl3mo4z.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296791 Archived-At: Juri Linkov writes: >>> I agree this would be the right thing, because even in Isearch we >>> have variables that duplicate the user options such as e.g. the >>> option 'search-invisible' and the internal variable >>> 'isearch-invisible'. >> >> Thanks! > > Please also see the commit 98f8c5fb07dcb4e20b8ba6648bdabf5c0d3b5145 > that fixed this in dired by using a buffer-local variable. Do you > agree it's a good fix? Otherwise using a separate variable is also > fine. My concern with using a local variable is that users may also set the user option locally. That is perhaps not a problem for eshell or dired, but for comint, e.g., I may set 'comint-history-isearch' to 'dwim' only in 'M-x shell' via the mode hook. IMO, changing an internal variable feels a bit cleaner and safer than manipulating a user option. So I would prefer using a separate variable.