From: Pengji Zhang <me@pengjiz.com>
To: Juri Linkov <juri@linkov.net>
Cc: Jim Porter <jporterbugs@gmail.com>, 74287@debbugs.gnu.org
Subject: bug#74287: [PATCH] Rework history Isearch for Eshell
Date: Wed, 11 Dec 2024 08:45:01 +0800 [thread overview]
Message-ID: <87y10navzm.fsf@pengjiz.com> (raw)
In-Reply-To: <87zfl3mo4z.fsf@mail.linkov.net>
Juri Linkov <juri@linkov.net> writes:
>>> I agree this would be the right thing, because even in Isearch we
>>> have variables that duplicate the user options such as e.g. the
>>> option 'search-invisible' and the internal variable
>>> 'isearch-invisible'.
>>
>> Thanks!
>
> Please also see the commit 98f8c5fb07dcb4e20b8ba6648bdabf5c0d3b5145
> that fixed this in dired by using a buffer-local variable. Do you
> agree it's a good fix? Otherwise using a separate variable is also
> fine.
My concern with using a local variable is that users may also set the
user option locally. That is perhaps not a problem for eshell or dired,
but for comint, e.g., I may set 'comint-history-isearch' to 'dwim' only
in 'M-x shell' via the mode hook.
IMO, changing an internal variable feels a bit cleaner and safer than
manipulating a user option. So I would prefer using a separate variable.
next prev parent reply other threads:[~2024-12-11 0:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 1:22 bug#74287: [PATCH] Rework history Isearch for Eshell Pengji Zhang
2024-11-10 23:40 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-12 8:54 ` Pengji Zhang
2024-11-26 6:53 ` Jim Porter
2024-11-26 9:41 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-26 17:00 ` Jim Porter
2024-11-27 5:37 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-04 18:56 ` Juri Linkov
2024-12-05 12:43 ` Pengji Zhang
2024-12-05 12:53 ` Pengji Zhang
2024-12-09 4:34 ` Jim Porter
2024-12-09 12:16 ` Pengji Zhang
2024-12-09 13:35 ` Pengji Zhang
2024-12-09 19:06 ` Jim Porter
2024-12-09 18:23 ` Juri Linkov
2024-12-10 0:55 ` Pengji Zhang
2024-12-10 7:46 ` Juri Linkov
2024-12-10 11:01 ` Pengji Zhang
2024-12-10 17:41 ` Juri Linkov
2024-12-11 0:45 ` Pengji Zhang [this message]
2024-12-11 7:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y10navzm.fsf@pengjiz.com \
--to=me@pengjiz.com \
--cc=74287@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).