From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package Date: Tue, 17 Dec 2024 20:58:40 +0200 Organization: LINKOV.NET Message-ID: <87y10edtlr.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37277"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 74140@debbugs.gnu.org, eliz@gnu.org To: Paul Nelson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 17 20:01:44 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNcpE-0009Wj-7h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Dec 2024 20:01:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNcp5-0004Ho-Vu; Tue, 17 Dec 2024 14:01:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNcoo-0004GS-2D for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 14:01:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNcoY-0002yr-FH for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 14:01:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=R1TObEpCzN9RlC2m172Y4/Sp279l87EYE6dHGOXlEQg=; b=Eb0OzxliADZ5XKprAHGIY4B9xb/lfH/vcgtY2Xpd53k2vNOJWunqfIWMXfUo4eCNvgsy9eMSqXBPaieGPh7HunjW6RB0gymH76JPJjh2dod+MUFPt4IZuUeg84iZ8emUSXcvhcE/xbm+k0oeK6UEXiqz9Ggphrcf1vh5obqK/HpflP138CxBYFYfcb/F4MBsmSSbyfMTF0QmDofGvglbHY02YHt6RrBRKJmYigiv/dMIgrncRY99dgLx3YndgceltzdClFofM3Ao7GqL0JBC+iEN0I0azZbUawjiJPOgl5hmWr9jASpRSkCrVOcZcagZLSO+y6FOX3QAbZUF4Pk16Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNcoX-0008DM-TO for bug-gnu-emacs@gnu.org; Tue, 17 Dec 2024 14:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Dec 2024 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74140 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74140-submit@debbugs.gnu.org id=B74140.173446204431542 (code B ref 74140); Tue, 17 Dec 2024 19:01:01 +0000 Original-Received: (at 74140) by debbugs.gnu.org; 17 Dec 2024 19:00:44 +0000 Original-Received: from localhost ([127.0.0.1]:60278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNcoC-0008Cb-Q9 for submit@debbugs.gnu.org; Tue, 17 Dec 2024 14:00:44 -0500 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNco7-0008CF-H2 for 74140@debbugs.gnu.org; Tue, 17 Dec 2024 14:00:39 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 9EEFC1BF208; Tue, 17 Dec 2024 19:00:06 +0000 (UTC) In-Reply-To: (Paul Nelson's message of "Mon, 16 Dec 2024 21:01:57 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297312 Archived-At: > I think the repeat-map property is fine as is, but the logic should be a > bit different: > > - If a command is called while repeat map MAP is active, then: > > - If the command's repeat-continue-only property contains MAP, then > MAP remains active (i.e., that map "continues"). [Maybe a better > name for the property would be simply "repeat-continue".] So the property is renamed now to 'repeat-continue'. > - Otherwise, if the command has a repeat-map property, then that > becomes the new repeat map. > > - Otherwise, the repeat map deactivates. > > - If a command is called while no repeat map is active, then we proceed > as before. > > Do you agree that this is the desired behavior? The difference is that > with the current implementation, only the repeat-map property is > relevant for determining which repeat map a command activates or > continues. Thanks for the clear explanation. Now this is completely implemented with tests.