unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: 74902@debbugs.gnu.org
Subject: bug#74902: 31.0.50; Segfault when deleting frames
Date: Tue, 31 Dec 2024 08:53:23 -0800	[thread overview]
Message-ID: <87y0zveqv0.fsf@stebalien.com> (raw)
In-Reply-To: <87frmn5yu5.fsf@gmail.com>


Robert Pluim <rpluim@gmail.com> writes:
> If you do find a reproducer, then based on the trace above I think the
> following should fix it:
>
> diff --git a/src/frame.c b/src/frame.c
> index f6053fca3ef..ff9e1d24ea1 100644
> --- a/src/frame.c
> +++ b/src/frame.c
> @@ -2281,7 +2281,9 @@ delete_frame (Lisp_Object frame, Lisp_Object force)
>    delete_all_child_windows (f->root_window);
>    fset_root_window (f, Qnil);
>  
> +  block_input();
>    Vframe_list = Fdelq (frame, Vframe_list);
> +  unblock_input();
>    SET_FRAME_VISIBLE (f, 0);
>  
>    /* Allow the vector of menu bar contents to be freed in the next

From what I can tell (my reproducer isn't 100% effective), this does
indeed fix the issue. Thanks!





  parent reply	other threads:[~2024-12-31 16:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15 22:01 bug#74902: 31.0.50; Segfault when deleting frames Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-16 15:50 ` Eli Zaretskii
2024-12-16 16:12   ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-16 17:20     ` Robert Pluim
2024-12-28 11:35       ` Eli Zaretskii
2024-12-28 23:23         ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-29  6:50           ` Eli Zaretskii
2024-12-31 16:31             ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2025-01-07  9:43               ` Robert Pluim
2025-01-10 11:26                 ` Robert Pluim
2025-01-10 12:44                   ` Eli Zaretskii
2025-01-10 15:10                     ` Robert Pluim
2025-01-10 16:19                 ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-31 16:53       ` Steven Allen via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2025-01-04 12:02         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0zveqv0.fsf@stebalien.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=74902@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=steven@stebalien.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).