From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#4835: 23.1; Improper `Invalid face reference' messages. Performance degraded. Date: Sat, 31 Oct 2009 14:59:38 -0400 Message-ID: <87ws2bfkyt.fsf@stupidchicken.com> Reply-To: Chong Yidong , 4835@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257016069 12269 80.91.229.12 (31 Oct 2009 19:07:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2009 19:07:49 +0000 (UTC) Cc: 4835@emacsbugs.donarmstrong.com To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 31 20:07:42 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N4JIb-0006NZ-2X for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2009 20:07:41 +0100 Original-Received: from localhost ([127.0.0.1]:55477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4JIa-0000RU-Jx for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Oct 2009 15:07:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N4JIJ-0000IY-N5 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2009 15:07:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N4JIE-0000H2-J5 for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2009 15:07:23 -0400 Original-Received: from [199.232.76.173] (port=35039 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4JIE-0000Gn-4L for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2009 15:07:18 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36485) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N4JID-0006aG-Gy for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2009 15:07:17 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9VJ7F5n017863; Sat, 31 Oct 2009 12:07:15 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9VJ55wt017200; Sat, 31 Oct 2009 12:05:05 -0700 Resent-Date: Sat, 31 Oct 2009 12:05:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sat, 31 Oct 2009 19:05:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4835 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4835-submit@emacsbugs.donarmstrong.com id=B4835.125701558516182 (code B ref 4835); Sat, 31 Oct 2009 19:05:05 +0000 Original-Received: (at 4835) by emacsbugs.donarmstrong.com; 31 Oct 2009 18:59:45 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from pantheon-po44.its.yale.edu (pantheon-po44.its.yale.edu [130.132.50.78]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9VIxiAZ016179 for <4835@emacsbugs.donarmstrong.com>; Sat, 31 Oct 2009 11:59:45 -0700 Original-Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9VIxcmf032176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 31 Oct 2009 14:59:38 -0400 Original-Received: by furry (Postfix, from userid 1000) id A9B05C070; Sat, 31 Oct 2009 14:59:38 -0400 (EDT) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Sat, 31 Oct 2009 15:07:23 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32315 Archived-At: > 2. The code I had seems nevertheless to "work", in the sense that it > does what I expect (highlights the column). Except that it logs those > messages and the performance is terrible. I suspect this is because parts of font-lock do this: (if (stringp matcher) (re-search-forward matcher end t) (funcall matcher end))) while other parts do this: (font-lock-eval-keywords (if (fboundp keywords) (funcall keywords) (eval keywords))))) If `matcher' is a lambda expression, the first will work as expected, because you can pass a lambda to funcall. But the second will do the wrong thing. We should probably fix the code to check for and disallow lambda expressions (and the docs), assuming not too much external code is relying on the unintended behavior.