* bug#7609: 24.0.50; gratuitous renaming in bookmark.el breaks 3rd-party code
@ 2010-12-10 17:04 Drew Adams
2010-12-10 20:55 ` Karl Fogel
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2010-12-10 17:04 UTC (permalink / raw)
To: 7609; +Cc: kfogel
This renaming of `bookmark-name-from-full-record' to
`bookmark-name-from-record' by Karl on 2010-12-08 saves 5 chars at each
occurrence but breaks any 3rd-party code that uses
`bookmark-name-from-full-record'.
Please at least provide an alias and an obsolescence declaration.
This kind of thing seems like a trivial change to you, perhaps,
but Emacs Dev isn't in a vacuum.
Thx.
--------------8<--------------------
author Karl Fogel <kfogel@red-bean.com>
Wed, 8 Dec 2010 08:09:27 +0000 (03:09 -0500)
committer Karl Fogel <kfogel@red-bean.com>
Wed, 8 Dec 2010 08:09:27 +0000 (03:09 -0500)
commit 69b4ae84edd840480a630c55ee154adfa55dd77b
tree 6e3613207cd14fd5a10a17a18c62e6588fcda977 tree | snapshot (tar.gz zip)
parent 504caaa1119f0833a4457e2b3225995dd7f40437 commit | diff
Adjust parameter names and doc strings to resolve confusion over
whether "bookmark" meant a bookmark name or a bookmark record.
Along the way, shorten one function's name for similar reasons.
(Issue #7548)
* lisp/bookmark.el
(bookmark-name-from-record):
New name for `bookmark-name-from-full-record'. All callers changed.
--------------8<--------------------
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-12-06 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#7609: 24.0.50; gratuitous renaming in bookmark.el breaks 3rd-party code
2010-12-10 17:04 bug#7609: 24.0.50; gratuitous renaming in bookmark.el breaks 3rd-party code Drew Adams
@ 2010-12-10 20:55 ` Karl Fogel
0 siblings, 0 replies; 2+ messages in thread
From: Karl Fogel @ 2010-12-10 20:55 UTC (permalink / raw)
To: Drew Adams; +Cc: bug-gnu-emacs
"Drew Adams" <drew.adams@oracle.com> writes:
>This renaming of `bookmark-name-from-full-record' to
>`bookmark-name-from-record' by Karl on 2010-12-08 saves 5 chars at each
>occurrence but breaks any 3rd-party code that uses
>`bookmark-name-from-full-record'.
>
>Please at least provide an alias and an obsolescence declaration.
>This kind of thing seems like a trivial change to you, perhaps,
>but Emacs Dev isn't in a vacuum.
My apologies -- I should have left a forwarding alias at least (or just
not made that change). I will fix it ASAP. Thanks for letting me know!
-Karl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-10 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-10 17:04 bug#7609: 24.0.50; gratuitous renaming in bookmark.el breaks 3rd-party code Drew Adams
2010-12-10 20:55 ` Karl Fogel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).