From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text Date: Fri, 18 May 2012 11:03:52 +0300 Message-ID: <87wr49ex07.fsf@gmail.com> References: <87y5owjcto.fsf@gmail.com> <83pqa8vsxw.fsf@gnu.org> <87fwb1dagj.fsf_-_@gmail.com> <83wr4do1qv.fsf@gnu.org> <87bolor98t.fsf@gmail.com> <83sjf0nolt.fsf@gnu.org> <87pqa3csuc.fsf@gmail.com> <83likqojxl.fsf@gnu.org> <83fwayo6mz.fsf@gnu.org> <83ehqindec.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337328294 755 80.91.229.3 (18 May 2012 08:04:54 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 May 2012 08:04:54 +0000 (UTC) Cc: 11464@debbugs.gnu.org, Michael Welsh Duggan To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 18 10:04:53 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SVIBA-0004YD-1b for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2012 10:04:52 +0200 Original-Received: from localhost ([::1]:37329 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVIB9-0007vj-9e for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 May 2012 04:04:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVIB5-0007vQ-FG for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 04:04:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVIB0-0006aX-Ne for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 04:04:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVIB0-0006aP-Hr for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 04:04:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SVIBJ-0001g0-IN for bug-gnu-emacs@gnu.org; Fri, 18 May 2012 04:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 May 2012 08:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11464-submit@debbugs.gnu.org id=B11464.13373282726408 (code B ref 11464); Fri, 18 May 2012 08:05:01 +0000 Original-Received: (at 11464) by debbugs.gnu.org; 18 May 2012 08:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:60098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVIAp-0001fI-6X for submit@debbugs.gnu.org; Fri, 18 May 2012 04:04:32 -0400 Original-Received: from mail-lpp01m010-f44.google.com ([209.85.215.44]:39552) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVIAj-0001f2-Mi for 11464@debbugs.gnu.org; Fri, 18 May 2012 04:04:30 -0400 Original-Received: by lagv3 with SMTP id v3so1773695lag.3 for <11464@debbugs.gnu.org>; Fri, 18 May 2012 01:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Je6e8aVSSDYlta/OVmMdHqRZMyYEcnJ745slHbvUeFQ=; b=Ydb661B+dZ9Jxq/LDFC8/lGt2O2U3Fax84PskcqtUse52+P795R/4c5jOFb0m+3Wwm WyHrJx5/rjbReA7Ywp3aSEV2ZWPU3aJ4kfiJMWkJz0q8JR3XajllxjAppRKrx0u4mrvI 38KvHRxuym3vz9SdCsXUpRS/uLM9PlPLm+JYqlQ/iY+FzfmQQLuQ+Of81ERYmGyEwy16 sCkwoUwdPE4lXalK0uEn9TtzxIMKZX7PddLnRE6kLE4OH9Og20Q3ohPBF9s2/879Dipk 8DYd3K1nDEeAZs+73pXEivUSDHD18X7hKBk+Wf9X6Rh1bcpbGMfG0uOShu/VKS7Aq9Jz rhKA== Original-Received: by 10.112.85.200 with SMTP id j8mr4413673lbz.80.1337328239922; Fri, 18 May 2012 01:03:59 -0700 (PDT) Original-Received: from arirop (dsl-jklbrasgw1-fe82df00-79.dhcp.inet.fi. [80.223.130.79]) by mx.google.com with ESMTPS id gw17sm11345145lab.11.2012.05.18.01.03.58 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 May 2012 01:03:59 -0700 (PDT) In-Reply-To: <83ehqindec.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 May 2012 10:42:35 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60169 Archived-At: Eli Zaretskii writes: > > It's 270, yes. But the rest is correct: if visible_p is set in this > case, it will never be reset with the current code. My original code > used > > if (bottom_y >= it.last_visible_y > > which would have caught this case. > > Ari, can you please describe again what happens in this particular > case on your machine, step by step, when you step with a debugger > through the relevant fragment? I sent this reply tonight: http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-05/msg00476.html The summary is that the case you are wondering about didn't have the bug at all. I tried to reproduce the bug in all three cases with emacs-24 revision 107933. The first case "emacs -Q" had the bug; "emacs -nw" had the bug; "emacs -fn fixed" didn't have the bug. Then I updated to revision 107934 (your patch). That fixed the "emacs -nw" case. My tweak fixed the "emacs -Q" case. -- Ari Roponen