From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#12823: Invalid font name Date: Thu, 15 Nov 2012 22:30:52 +0900 Message-ID: <87wqxnro1f.fsf@gnu.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1352986411 9237 80.91.229.3 (15 Nov 2012 13:33:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Nov 2012 13:33:31 +0000 (UTC) Cc: 12823@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 15 14:33:41 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TYzZb-0001Tb-AL for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 14:33:39 +0100 Original-Received: from localhost ([::1]:52119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYzZR-0005M8-IC for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Nov 2012 08:33:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYzZM-0005LS-A5 for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 08:33:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYzZJ-0000jO-7b for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 08:33:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYzZJ-0000jJ-4U for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 08:33:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TYzZx-0005rI-Pt for bug-gnu-emacs@gnu.org; Thu, 15 Nov 2012 08:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Nov 2012 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12823-submit@debbugs.gnu.org id=B12823.135298641822489 (code B ref 12823); Thu, 15 Nov 2012 13:34:01 +0000 Original-Received: (at 12823) by debbugs.gnu.org; 15 Nov 2012 13:33:38 +0000 Original-Received: from localhost ([127.0.0.1]:44513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYzZY-0005qe-TH for submit@debbugs.gnu.org; Thu, 15 Nov 2012 08:33:38 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:54656) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TYzZV-0005qW-04 for 12823@debbugs.gnu.org; Thu, 15 Nov 2012 08:33:34 -0500 Original-Received: from 253.240.accsnet.ne.jp ([202.220.240.253]:51094 helo=mongkok) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1TYzYm-0003C1-Sd; Thu, 15 Nov 2012 08:32:51 -0500 In-Reply-To: (message from Andreas Schwab on Tue, 13 Nov 2012 20:25:01 +0100) X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-Spam-Score: -5.1 (-----) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66955 Archived-At: In article , Andreas Schwab writes: > Kenichi Handa writes: > > === modified file 'src/font.c' > > --- src/font.c 2012-11-03 05:11:34 +0000 > > +++ src/font.c 2012-11-13 11:50:50 +0000 > > @@ -1185,7 +1185,7 @@ > > font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) > > { > > char *p; > > - const char *f[XLFD_REGISTRY_INDEX + 1]; > > + char *f[XLFD_REGISTRY_INDEX + 1]; > This will provoke warnings that are turned into errors with > --enable-gcc-warnings. There is no need for that, just use a temporary > variable (there is already one above that is perfectly suitable). Thank you for the suggesiton. Do you mean something like this additional patch? === modified file 'src/font.c' --- src/font.c 2012-11-13 14:24:26 +0000 +++ src/font.c 2012-11-15 13:04:45 +0000 @@ -1185,7 +1185,7 @@ font_unparse_xlfd (Lisp_Object font, int pixel_size, char *name, int nbytes) { char *p; - char *f[XLFD_REGISTRY_INDEX + 1]; + const char *f[XLFD_REGISTRY_INDEX + 1]; Lisp_Object val; int i, j, len; @@ -1241,13 +1241,13 @@ alloc = SBYTES (val) + 1; if (nbytes <= alloc) return -1; - f[j] = alloca (alloc); + f[j] = p = alloca (alloc); /* Copy the name while excluding '-', '?', ',', and '"'. */ for (k = l = 0; k < alloc; k++) { c = SREF (val, k); if (c != '-' && c != '?' && c != ',' && c != '"') - f[j][l++] = c; + p[l++] = c; } } } --- Kenichi Handa handa@gnu.org